From 249d37a8c4ae113d4043f7bdc1213fbd1a22f3b8 Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Mon, 23 Sep 2024 10:25:53 +0200 Subject: [PATCH] reportdesign: Use NC_ to create a TranslateId I don't see any reason for handling `RID_STR_EXPLANATION` differently than all other translatable strings here. Change-Id: Ica678557124f4daf48c3759fe3640fe95a2bc8ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173810 Tested-by: Jenkins Reviewed-by: Michael Weghorn --- reportdesign/inc/strings.hrc | 2 +- reportdesign/source/ui/inspection/DataProviderHandler.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/reportdesign/inc/strings.hrc b/reportdesign/inc/strings.hrc index 5d3b8836570c..b1c4392a867a 100644 --- a/reportdesign/inc/strings.hrc +++ b/reportdesign/inc/strings.hrc @@ -64,7 +64,7 @@ #define RID_STR_TYPE NC_("RID_STR_TYPE", "Data Field Type") #define RID_STR_MASTERFIELDS NC_("RID_STR_MASTERFIELDS", "Link master fields") #define RID_STR_DETAILFIELDS NC_("RID_STR_DETAILFIELDS", "Link slave fields") -#define RID_STR_EXPLANATION ("Charts can be used to display detailed data about the current record of the report. To do this, you can specify which columns in the chart match which columns in the report.") +#define RID_STR_EXPLANATION NC_("RID_STR_EXPLANATION", "Charts can be used to display detailed data about the current record of the report. To do this, you can specify which columns in the chart match which columns in the report.") #define RID_STR_DETAILLABEL NC_("RID_STR_DETAILLABEL", "Chart") #define RID_STR_MASTERLABEL NC_("RID_STR_MASTERLABEL", "Report") #define RID_STR_PREVIEW_COUNT NC_("RID_STR_PREVIEW_COUNT", "Preview Row(s)") diff --git a/reportdesign/source/ui/inspection/DataProviderHandler.cxx b/reportdesign/source/ui/inspection/DataProviderHandler.cxx index b8c6a1c15fce..18d4c286339d 100644 --- a/reportdesign/source/ui/inspection/DataProviderHandler.cxx +++ b/reportdesign/source/ui/inspection/DataProviderHandler.cxx @@ -470,7 +470,7 @@ bool DataProviderHandler::impl_dialogLinkedFields_nothrow( ::osl::ClearableMutex {"ParentWindow", m_xContext->getValueByName(u"DialogParentWindow"_ustr)}, {"Detail", uno::Any(m_xDataProvider)}, {"Master", uno::Any(m_xReportComponent->getSection()->getReportDefinition())}, - {"Explanation", uno::Any(RptResId(TranslateId(nullptr, RID_STR_EXPLANATION)))}, + {"Explanation", uno::Any(RptResId(RID_STR_EXPLANATION))}, {"DetailLabel", uno::Any(RptResId(RID_STR_DETAILLABEL))}, {"MasterLabel", uno::Any(RptResId(RID_STR_MASTERLABEL))}, }));