mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:passstuffbyref improved return in basic,framework

Browse Source 
Change-Id: Ib19836febb59f4e2bb07dc874cfc6baabc653237
Reviewed-on: https://gerrit.libreoffice.org/47065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-12-26 08:32:51 +02:00
parent 2bf1cc7372
commit 2a421b26c0
13 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
basic/source/classes/sb.cxx
View File

@@ -1448,7 +1448,7 @@ sal_uInt16 StarBASIC::GetCol1() { return GetSbData()->nCol1; }
sal_uInt16 StarBASIC::GetCol2() { return GetSbData()->nCol2; } sal_uInt16 StarBASIC::GetCol2() { return GetSbData()->nCol2; }
// Specific to error handler // Specific to error handler
ErrCode StarBASIC::GetErrorCode() { return GetSbData()->nCode; } ErrCode const & StarBASIC::GetErrorCode() { return GetSbData()->nCode; }
const OUString& StarBASIC::GetErrorText() { return GetSbData()->aErrMsg; } const OUString& StarBASIC::GetErrorText() { return GetSbData()->aErrMsg; }
// From 1996-03-29: // From 1996-03-29:
@@ -1763,7 +1763,7 @@ bool StarBASIC::ErrorHdl()
return aErrorHdl.Call( this ); return aErrorHdl.Call( this );
} }
Link<StarBASIC*,bool> StarBASIC::GetGlobalErrorHdl() Link<StarBASIC*,bool> const & StarBASIC::GetGlobalErrorHdl()
{ {
return GetSbData()->aErrHdl; return GetSbData()->aErrHdl;
} }

6
basic/source/inc/iosys.hxx
View File

@@ -60,10 +60,10 @@ class SbiStream
public: public:
SbiStream(); SbiStream();
~SbiStream(); ~SbiStream();
ErrCode Open( const OString&, StreamMode, SbiStreamFlags, short ); ErrCode const & Open( const OString&, StreamMode, SbiStreamFlags, short );
ErrCode Close(); ErrCode const & Close();
ErrCode Read(OString&, sal_uInt16 = 0, bool bForceReadingPerByte=false); ErrCode Read(OString&, sal_uInt16 = 0, bool bForceReadingPerByte=false);
ErrCode Read( char& ); ErrCode const & Read( char& );
ErrCode Write( const OString& ); ErrCode Write( const OString& );
bool IsText() const { return !bool(nMode & SbiStreamFlags::Binary); } bool IsText() const { return !bool(nMode & SbiStreamFlags::Binary); }

4
basic/source/inc/runtime.hxx
View File

@@ -167,7 +167,7 @@ public:
void Abort(); // with current error code void Abort(); // with current error code
void Stop(); void Stop();
ErrCode GetErr() { return nErr; } ErrCode const & GetErr() { return nErr; }
const OUString& GetErrorMsg() { return aErrorMsg; } const OUString& GetErrorMsg() { return aErrorMsg; }
sal_Int32 GetErl() { return nErl; } sal_Int32 GetErl() { return nErl; }
void EnableReschedule( bool bEnable ) { bReschedule = bEnable; } void EnableReschedule( bool bEnable ) { bReschedule = bEnable; }
@@ -186,7 +186,7 @@ public:
SbiDllMgr* GetDllMgr(); SbiDllMgr* GetDllMgr();
SbiRTLData* GetRTLData() const { return const_cast<SbiRTLData*>(&aRTLData); } SbiRTLData* GetRTLData() const { return const_cast<SbiRTLData*>(&aRTLData); }
std::shared_ptr<SvNumberFormatter> GetNumberFormatter(); std::shared_ptr<SvNumberFormatter> const & GetNumberFormatter();
sal_uInt32 GetStdDateIdx() const { return nStdDateIdx; } sal_uInt32 GetStdDateIdx() const { return nStdDateIdx; }
sal_uInt32 GetStdTimeIdx() const { return nStdTimeIdx; } sal_uInt32 GetStdTimeIdx() const { return nStdTimeIdx; }
sal_uInt32 GetStdDateTimeIdx() const { return nStdDateTimeIdx; } sal_uInt32 GetStdDateTimeIdx() const { return nStdDateTimeIdx; }

6
basic/source/runtime/iosys.cxx
View File

@@ -445,7 +445,7 @@ void UCBStream::SetSize( sal_uInt64 )
} }
ErrCode SbiStream::Open ErrCode const & SbiStream::Open
( const OString& rName, StreamMode nStrmMode, SbiStreamFlags nFlags, short nL ) ( const OString& rName, StreamMode nStrmMode, SbiStreamFlags nFlags, short nL )
{ {
nMode = nFlags; nMode = nFlags;
@@ -511,7 +511,7 @@ ErrCode SbiStream::Open
return nError; return nError;
} }
ErrCode SbiStream::Close() ErrCode const & SbiStream::Close()
{ {
if( pStrm ) if( pStrm )
{ {
@@ -553,7 +553,7 @@ ErrCode SbiStream::Read(OString& rBuf, sal_uInt16 n, bool bForceReadingPerByte)
return nError; return nError;
} }
ErrCode SbiStream::Read( char& ch ) ErrCode const & SbiStream::Read( char& ch )
{ {
nExpandOnWriteTo = 0; nExpandOnWriteTo = 0;
if (aLine.isEmpty()) if (aLine.isEmpty())

2
basic/source/runtime/runtime.cxx
View File

@@ -357,7 +357,7 @@ SbiDllMgr* SbiInstance::GetDllMgr()
} }
// #39629 create NumberFormatter with the help of a static method now // #39629 create NumberFormatter with the help of a static method now
std::shared_ptr<SvNumberFormatter> SbiInstance::GetNumberFormatter() std::shared_ptr<SvNumberFormatter> const & SbiInstance::GetNumberFormatter()
{ {
LanguageType eLangType = Application::GetSettings().GetLanguageTag().getLanguageType(); LanguageType eLangType = Application::GetSettings().GetLanguageTag().getLanguageType();
SvtSysLocale aSysLocale; SvtSysLocale aSysLocale;

2
basic/source/sbx/sbxbase.cxx
View File

@@ -94,7 +94,7 @@ void SbxBase::SetModified( bool b )
ResetFlag( SbxFlagBits::Modified ); ResetFlag( SbxFlagBits::Modified );
} }
ErrCode SbxBase::GetError() ErrCode const & SbxBase::GetError()
{ {
return GetSbxData_Impl().eErrCode; return GetSbxData_Impl().eErrCode;
} }

2
framework/inc/classes/imagewrapper.hxx
View File

@@ -43,7 +43,7 @@ class FWE_DLLPUBLIC ImageWrapper :
return m_aImage; return m_aImage;
} }
static css::uno::Sequence< sal_Int8 > GetUnoTunnelId(); static css::uno::Sequence< sal_Int8 > const & GetUnoTunnelId();
// XBitmap // XBitmap
virtual css::awt::Size SAL_CALL getSize() override; virtual css::awt::Size SAL_CALL getSize() override;

2
framework/inc/xml/xmlnamespaces.hxx
View File

@@ -47,7 +47,7 @@ class FWE_DLLPUBLIC XMLNamespaces final
typedef ::std::map< OUString, OUString > NamespaceMap; typedef ::std::map< OUString, OUString > NamespaceMap;
/// @throws css::xml::sax::SAXException /// @throws css::xml::sax::SAXException
OUString getNamespaceValue( const OUString& aNamespace ) const; OUString const & getNamespaceValue( const OUString& aNamespace ) const;
OUString m_aDefaultNamespace; OUString m_aDefaultNamespace;
OUString m_aXMLAttributeNamespace; OUString m_aXMLAttributeNamespace;

2
framework/source/fwe/classes/imagewrapper.cxx
View File

@@ -46,7 +46,7 @@ ImageWrapper::~ImageWrapper()
{ {
} }
Sequence< sal_Int8 > ImageWrapper::GetUnoTunnelId() Sequence< sal_Int8 > const & ImageWrapper::GetUnoTunnelId()
{ {
return impl_getStaticIdentifier(); return impl_getStaticIdentifier();
} }

2
framework/source/fwe/xml/xmlnamespaces.cxx
View File

@@ -143,7 +143,7 @@ OUString XMLNamespaces::applyNSToElementName( const OUString& aName ) const
return aElementName; return aElementName;
} }
OUString XMLNamespaces::getNamespaceValue( const OUString& aNamespace ) const OUString const & XMLNamespaces::getNamespaceValue( const OUString& aNamespace ) const
{ {
if ( aNamespace.isEmpty() ) if ( aNamespace.isEmpty() )
return m_aDefaultNamespace; return m_aDefaultNamespace;

2
include/basic/basmgr.hxx
View File

@@ -55,7 +55,7 @@ public:
BasicError( const BasicError& rErr ); BasicError( const BasicError& rErr );
BasicError( ErrCode nId, BasicErrorReason nR ); BasicError( ErrCode nId, BasicErrorReason nR );
ErrCode GetErrorId() const { return nErrorId; } ErrCode const & GetErrorId() const { return nErrorId; }
}; };
class ErrorManager; class ErrorManager;

4
include/basic/sbstar.hxx
View File

@@ -130,12 +130,12 @@ public:
// Specific to error handler // Specific to error handler
static void MakeErrorText( ErrCode, const OUString& aMsg ); static void MakeErrorText( ErrCode, const OUString& aMsg );
static const OUString& GetErrorText(); static const OUString& GetErrorText();
static ErrCode GetErrorCode(); static ErrCode const & GetErrorCode();
static sal_uInt16 GetVBErrorCode( ErrCode nError ); static sal_uInt16 GetVBErrorCode( ErrCode nError );
static ErrCode GetSfxFromVBError( sal_uInt16 nError ); static ErrCode GetSfxFromVBError( sal_uInt16 nError );
bool IsBreak() const { return bBreak; } bool IsBreak() const { return bBreak; }
static Link<StarBASIC*,bool> GetGlobalErrorHdl(); static Link<StarBASIC*,bool> const & GetGlobalErrorHdl();
static void SetGlobalErrorHdl( const Link<StarBASIC*,bool>& rNewHdl ); static void SetGlobalErrorHdl( const Link<StarBASIC*,bool>& rNewHdl );
static void SetGlobalBreakHdl( const Link<StarBASIC*,BasicDebugFlags>& rNewHdl ); static void SetGlobalBreakHdl( const Link<StarBASIC*,BasicDebugFlags>& rNewHdl );

2
include/basic/sbxcore.hxx
View File

@@ -81,7 +81,7 @@ public:
bool Store( SvStream& ); bool Store( SvStream& );
virtual bool LoadCompleted(); virtual bool LoadCompleted();
static ErrCode GetError(); static ErrCode const & GetError();
static void SetError( ErrCode ); static void SetError( ErrCode );
static bool IsError(); static bool IsError();
static void ResetError(); static void ResetError();