mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in SwFlowFrame::ShouldBwdMoved

Browse Source 
Change-Id: Ife69fe8c9023682278c02d037d35d15bd015f127
Reviewed-on: https://gerrit.libreoffice.org/81014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2019-10-17 13:57:35 +02:00
parent 2785ea58db
commit 2ac038e2b3
9 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@ -325,9 +325,6 @@ sw/inc/swcrsr.hxx:161
sw/source/core/access/acccontext.hxx:348 sw/source/core/access/acccontext.hxx:348
_Bool SwAccessibleContext::SetSelectedState(_Bool,) _Bool SwAccessibleContext::SetSelectedState(_Bool,)
0 0
sw/source/core/inc/flowfrm.hxx:145
_Bool SwFlowFrame::ShouldBwdMoved(class SwLayoutFrame *,_Bool,_Bool &,)
101
sw/source/core/inc/txmsrt.hxx:145 sw/source/core/inc/txmsrt.hxx:145
void SwTOXSortTabBase::FillText(class SwTextNode &,const class SwIndex &,unsigned short,const class SwRootFrame *const,)const void SwTOXSortTabBase::FillText(class SwTextNode &,const class SwIndex &,unsigned short,const class SwRootFrame *const,)const
1100 1100

2
sw/source/core/inc/cntfrm.hxx
View File

@ -49,7 +49,7 @@ class SAL_DLLPUBLIC_RTTI SwContentFrame: public SwFrame, public SwFlowFrame
void UpdateAttr_( const SfxPoolItem*, const SfxPoolItem*, sal_uInt8 &, void UpdateAttr_( const SfxPoolItem*, const SfxPoolItem*, sal_uInt8 &,
SwAttrSetChg *pa = nullptr, SwAttrSetChg *pb = nullptr ); SwAttrSetChg *pa = nullptr, SwAttrSetChg *pb = nullptr );
virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool, bool& ) override; virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool& ) override;
const SwContentFrame* ImplGetNextContentFrame( bool bFwd ) const; const SwContentFrame* ImplGetNextContentFrame( bool bFwd ) const;

2
sw/source/core/inc/flowfrm.hxx
View File

@ -142,7 +142,7 @@ protected:
bool CheckMoveFwd( bool& rbMakePage, bool bKeep, bool bIgnoreMyOwnKeepValue ); bool CheckMoveFwd( bool& rbMakePage, bool bKeep, bool bIgnoreMyOwnKeepValue );
bool MoveFwd( bool bMakePage, bool bPageBreak, bool bMoveAlways = false ); bool MoveFwd( bool bMakePage, bool bPageBreak, bool bMoveAlways = false );
bool MoveBwd( bool &rbReformat ); bool MoveBwd( bool &rbReformat );
virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool bHead, bool &rReformat )=0; virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool &rReformat )=0;
public: public:
SwFlowFrame( SwFrame &rFrame ); SwFlowFrame( SwFrame &rFrame );

2
sw/source/core/inc/sectfrm.hxx
View File

@ -58,7 +58,7 @@ class SwSectionFrame: public SwLayoutFrame, public SwFlowFrame
protected: protected:
virtual void MakeAll(vcl::RenderContext* pRenderContext) override; virtual void MakeAll(vcl::RenderContext* pRenderContext) override;
virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool bHead, bool &rReformat ) override; virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool &rReformat ) override;
virtual void Format( vcl::RenderContext* pRenderContext, const SwBorderAttrs *pAttrs = nullptr ) override; virtual void Format( vcl::RenderContext* pRenderContext, const SwBorderAttrs *pAttrs = nullptr ) override;
virtual void Modify( const SfxPoolItem*, const SfxPoolItem* ) override; virtual void Modify( const SfxPoolItem*, const SfxPoolItem* ) override;
virtual void SwClientNotify( const SwModify&, const SfxHint& ) override; virtual void SwClientNotify( const SwModify&, const SfxHint& ) override;

2
sw/source/core/inc/tabfrm.hxx
View File

@ -100,7 +100,7 @@ class SwTabFrame: public SwLayoutFrame, public SwFlowFrame
SwAttrSetChg *pa = nullptr, SwAttrSetChg *pa = nullptr,
SwAttrSetChg *pb = nullptr ); SwAttrSetChg *pb = nullptr );
virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool bHead, bool &rReformat ) override; virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool &rReformat ) override;
virtual void DestroyImpl() override; virtual void DestroyImpl() override;
virtual ~SwTabFrame() override; virtual ~SwTabFrame() override;

2
sw/source/core/layout/calcmove.cxx
View File

@ -50,7 +50,7 @@
// Move methods // Move methods
/// Return value tells whether the Frame should be moved. /// Return value tells whether the Frame should be moved.
bool SwContentFrame::ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool, bool & ) bool SwContentFrame::ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool & )
{ {
if ( SwFlowFrame::IsMoveBwdJump() || !IsPrevObjMove() ) if ( SwFlowFrame::IsMoveBwdJump() || !IsPrevObjMove() )
{ {

2
sw/source/core/layout/flowfrm.cxx
View File

@ -2379,7 +2379,7 @@ bool SwFlowFrame::MoveBwd( bool &rbReformat )
pNewUpper = nullptr; pNewUpper = nullptr;
} }
} }
if ( pNewUpper && !ShouldBwdMoved( pNewUpper, true, rbReformat ) ) if ( pNewUpper && !ShouldBwdMoved( pNewUpper, rbReformat ) )
{ {
if( !pNewUpper->Lower() ) if( !pNewUpper->Lower() )
{ {

2
sw/source/core/layout/sectfrm.cxx
View File

@ -853,7 +853,7 @@ void SwSectionFrame::MakeAll(vcl::RenderContext* pRenderContext)
DelEmpty( false ); DelEmpty( false );
} }
bool SwSectionFrame::ShouldBwdMoved( SwLayoutFrame *, bool , bool & ) bool SwSectionFrame::ShouldBwdMoved( SwLayoutFrame *, bool & )
{ {
OSL_FAIL( "Oops, where is my tinfoil hat?" ); OSL_FAIL( "Oops, where is my tinfoil hat?" );
return false; return false;

6
sw/source/core/layout/tabfrm.cxx
View File

@ -2053,7 +2053,7 @@ void SwTabFrame::MakeAll(vcl::RenderContext* pRenderContext)
{ {
SwTabFrame *pMaster = FindMaster(); SwTabFrame *pMaster = FindMaster();
bool bDummy; bool bDummy;
if ( ShouldBwdMoved( pMaster->GetUpper(), false, bDummy ) ) if ( ShouldBwdMoved( pMaster->GetUpper(), bDummy ) )
pMaster->InvalidatePos(); pMaster->InvalidatePos();
} }
} }
@ -2143,7 +2143,7 @@ void SwTabFrame::MakeAll(vcl::RenderContext* pRenderContext)
if ( !bSplit && GetFollow() ) if ( !bSplit && GetFollow() )
{ {
bool bDummy; bool bDummy;
if ( GetFollow()->ShouldBwdMoved( GetUpper(), false, bDummy ) ) if ( GetFollow()->ShouldBwdMoved( GetUpper(), bDummy ) )
{ {
SwFrame *pTmp = GetUpper(); SwFrame *pTmp = GetUpper();
SwTwips nDeadLine = aRectFnSet.GetPrtBottom(*pTmp); SwTwips nDeadLine = aRectFnSet.GetPrtBottom(*pTmp);
@ -3418,7 +3418,7 @@ SwContentFrame *SwTabFrame::FindLastContent()
} }
/// Return value defines if the frm needs to be relocated /// Return value defines if the frm needs to be relocated
bool SwTabFrame::ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool, bool &rReformat ) bool SwTabFrame::ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool &rReformat )
{ {
rReformat = false; rReformat = false;
if ( SwFlowFrame::IsMoveBwdJump() || !IsPrevObjMove() ) if ( SwFlowFrame::IsMoveBwdJump() || !IsPrevObjMove() )