From 2c366aae9263dc4115b054fe74b90cabea61fa0b Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Wed, 29 Apr 2020 20:12:21 +0300 Subject: [PATCH] Use a less extreme entitlement for our run-time machine code generation See https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_cs_disable-executable-page-protection and https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_cs_allow-jit Change-Id: I192038efa9cff4fb723bf4bdc8644f0b09f0fcda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93181 Tested-by: Jenkins Reviewed-by: Tor Lillqvist --- bridges/source/cpp_uno/shared/vtablefactory.cxx | 6 ++++++ hardened_runtime.xcent.in | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/bridges/source/cpp_uno/shared/vtablefactory.cxx b/bridges/source/cpp_uno/shared/vtablefactory.cxx index 018b808d89e6..036b81c4218a 100644 --- a/bridges/source/cpp_uno/shared/vtablefactory.cxx +++ b/bridges/source/cpp_uno/shared/vtablefactory.cxx @@ -77,6 +77,11 @@ extern "C" void * allocExec( std::size_t n = (*size + (pagesize - 1)) & ~(pagesize - 1); void * p; #if defined SAL_UNX +#if defined MACOSX + p = mmap( + nullptr, n, PROT_READ | PROT_WRITE | PROT_EXEC, MAP_PRIVATE | MAP_ANON | MAP_JIT, -1, + 0); +#else p = mmap( nullptr, n, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0); @@ -88,6 +93,7 @@ extern "C" void * allocExec( munmap (p, n); p = nullptr; } +#endif #elif defined _WIN32 p = VirtualAlloc(nullptr, n, MEM_COMMIT, PAGE_EXECUTE_READWRITE); #endif diff --git a/hardened_runtime.xcent.in b/hardened_runtime.xcent.in index d270c93ec694..2bbcda34f18c 100644 --- a/hardened_runtime.xcent.in +++ b/hardened_runtime.xcent.in @@ -6,7 +6,7 @@ com.apple.security.automation.apple-events - com.apple.security.cs.disable-executable-page-protection + com.apple.security.cs.allow-jit com.apple.security.cs.disable-library-validation