mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang-tidy performance-unnecessary-value-param in vbahelper

Browse Source 
Change-Id: Ifbe78c4a43b9d77d6ecf481bb1a9aaac6bcd01a6
This commit is contained in:
Noel Grandin
2016-04-11 15:11:42 +02:00
parent fb42d03b5a
commit 2c93d340ae
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/vbahelper/vbashapes.hxx
View File

@@ -52,8 +52,8 @@ protected:
public: public:
ScVbaShapes( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xShapes, const css::uno::Reference< css::frame::XModel >& xModel ); ScVbaShapes( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xShapes, const css::uno::Reference< css::frame::XModel >& xModel );
static void setDefaultShapeProperties( css::uno::Reference< css::drawing::XShape > xShape ) throw (css::uno::RuntimeException); static void setDefaultShapeProperties( const css::uno::Reference< css::drawing::XShape >& xShape ) throw (css::uno::RuntimeException);
static void setShape_NameProperty( css::uno::Reference< css::drawing::XShape > xShape, const OUString& sName ); static void setShape_NameProperty( const css::uno::Reference< css::drawing::XShape >& xShape, const OUString& sName );
//XEnumerationAccess //XEnumerationAccess
virtual css::uno::Type SAL_CALL getElementType() throw (css::uno::RuntimeException) override; virtual css::uno::Type SAL_CALL getElementType() throw (css::uno::RuntimeException) override;
virtual css::uno::Reference< css::container::XEnumeration > SAL_CALL createEnumeration() throw (css::uno::RuntimeException) override; virtual css::uno::Reference< css::container::XEnumeration > SAL_CALL createEnumeration() throw (css::uno::RuntimeException) override;

2
vbahelper/source/vbahelper/vbafillformat.cxx
View File

@@ -26,7 +26,7 @@
using namespace ooo::vba; using namespace ooo::vba;
using namespace com::sun::star; using namespace com::sun::star;
ScVbaFillFormat::ScVbaFillFormat( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< drawing::XShape > xShape ) : ScVbaFillFormat_BASE( xParent, xContext ), m_xShape( xShape ) ScVbaFillFormat::ScVbaFillFormat( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< drawing::XShape >& xShape ) : ScVbaFillFormat_BASE( xParent, xContext ), m_xShape( xShape )
{ {
m_xPropertySet.set( xShape, uno::UNO_QUERY_THROW ); m_xPropertySet.set( xShape, uno::UNO_QUERY_THROW );
m_nFillStyle = drawing::FillStyle_SOLID; m_nFillStyle = drawing::FillStyle_SOLID;

2
vbahelper/source/vbahelper/vbafillformat.hxx
View File

@@ -43,7 +43,7 @@ protected:
virtual css::uno::Sequence<OUString> getServiceNames() override; virtual css::uno::Sequence<OUString> getServiceNames() override;
public: public:
ScVbaFillFormat( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::drawing::XShape > xShape ); ScVbaFillFormat( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::drawing::XShape >& xShape );
void setForeColorAndInternalStyle( sal_Int32 nForeColor ) throw (css::uno::RuntimeException); void setForeColorAndInternalStyle( sal_Int32 nForeColor ) throw (css::uno::RuntimeException);
// Attributes // Attributes

4
vbahelper/source/vbahelper/vbashapes.cxx
View File

@@ -409,7 +409,7 @@ ScVbaShapes::AddTextboxInWriter( sal_Int32 /*_nOrientation*/, sal_Int32 _nLeft,
} }
void void
ScVbaShapes::setDefaultShapeProperties( uno::Reference< drawing::XShape > xShape ) throw (uno::RuntimeException) ScVbaShapes::setDefaultShapeProperties( const uno::Reference< drawing::XShape >& xShape ) throw (uno::RuntimeException)
{ {
uno::Reference< beans::XPropertySet > xPropertySet( xShape, uno::UNO_QUERY_THROW ); uno::Reference< beans::XPropertySet > xPropertySet( xShape, uno::UNO_QUERY_THROW );
xPropertySet->setPropertyValue( "FillStyle", uno::makeAny( OUString("SOLID") ) ); xPropertySet->setPropertyValue( "FillStyle", uno::makeAny( OUString("SOLID") ) );
@@ -420,7 +420,7 @@ ScVbaShapes::setDefaultShapeProperties( uno::Reference< drawing::XShape > xShape
} }
void void
ScVbaShapes::setShape_NameProperty( uno::Reference< css::drawing::XShape > xShape, const OUString& sName ) ScVbaShapes::setShape_NameProperty( const uno::Reference< css::drawing::XShape >& xShape, const OUString& sName )
{ {
uno::Reference< beans::XPropertySet > xPropertySet( xShape, uno::UNO_QUERY_THROW ); uno::Reference< beans::XPropertySet > xPropertySet( xShape, uno::UNO_QUERY_THROW );
try try