mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)

Browse Source 
...which is a confusing overload with unexpectedly different semantics from the
one-parameter form.  In preparation of marking it as deprecated.

Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
This commit is contained in:
Stephan Bergmann
2013-03-20 13:02:46 +01:00
parent dc06576d88
commit 2d9ce9191d
36 changed files with 59 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
View File

@@ -1263,11 +1263,11 @@ struct SortInternalSchemasLastAndPublicFirst
a[0] >>= valueA;
b[0] >>= valueB;
bool ret = false;
if( valueA.compareToAscii( RTL_CONSTASCII_STRINGPARAM( "public" ) ) == 0 )
if( valueA.startsWith( "public" ) )
{
ret = true;
}
else if( valueB.compareToAscii( RTL_CONSTASCII_STRINGPARAM( "public" ) ) == 0 )
else if( valueB.startsWith( "public" ) )
{
ret = false;
}
@@ -2202,9 +2202,9 @@ struct TypeInfoByDataTypeSorter
OUString nameB;
a[0 /*TYPE_NAME*/] >>= nameA;
b[0 /*TYPE_NAME*/] >>= nameB;
if( nameA.compareToAscii( RTL_CONSTASCII_STRINGPARAM( "int4" ) ) == 0 )
if( nameA.startsWith( "int4" ) )
return 1;
if( nameB.compareToAscii( RTL_CONSTASCII_STRINGPARAM( "int4" ) ) == 0 )
if( nameB.startsWith( "int4" ) )
return 0;
return nameA.compareTo( nameB ) < 0;
}