mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang: Uninitialized argument value

Browse Source 
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
This commit is contained in:
Caolán McNamara 2014-06-26 10:03:54 +01:00
parent cd29cab883
commit 2daceb87b9
3 changed files with 22 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
basic/source/sbx/sbxarray.cxx
View File

@ -680,6 +680,8 @@ bool SbxDimArray::GetDim( short n, short& rlb, short& rub ) const
{ {
sal_Int32 rlb32, rub32; sal_Int32 rlb32, rub32;
bool bRet = GetDim32( n, rlb32, rub32 ); bool bRet = GetDim32( n, rlb32, rub32 );
rub = (short)rub32;
rlb = (short)rlb32;
if( bRet ) if( bRet )
{ {
if( rlb32 < -SBX_MAXINDEX || rub32 > SBX_MAXINDEX ) if( rlb32 < -SBX_MAXINDEX || rub32 > SBX_MAXINDEX )
@ -687,8 +689,6 @@ bool SbxDimArray::GetDim( short n, short& rlb, short& rub ) const
SetError( SbxERR_BOUNDS ); SetError( SbxERR_BOUNDS );
return false; return false;
} }
rub = (short)rub32;
rlb = (short)rlb32;
} }
return bRet; return bRet;
} }
@ -753,9 +753,7 @@ void SbxDimArray::Put32( SbxVariable* p, const sal_Int32* pIdx )
SbxArray::Put32( p, Offset32( pIdx ) ); SbxArray::Put32( p, Offset32( pIdx ) );
} }
// Element-Number with the help of Parameter-Array // Element-Number with the help of Parameter-Array
sal_uInt32 SbxDimArray::Offset32( SbxArray* pPar ) sal_uInt32 SbxDimArray::Offset32( SbxArray* pPar )
{ {
#ifndef DISABLE_SCRIPTING #ifndef DISABLE_SCRIPTING
@ -793,7 +791,7 @@ bool SbxDimArray::LoadData( SvStream& rStrm, sal_uInt16 nVer )
rStrm.ReadInt16( nDimension ); rStrm.ReadInt16( nDimension );
for( short i = 0; i < nDimension && rStrm.GetError() == SVSTREAM_OK; i++ ) for( short i = 0; i < nDimension && rStrm.GetError() == SVSTREAM_OK; i++ )
{ {
sal_Int16 lb, ub; sal_Int16 lb(0), ub(0);
rStrm.ReadInt16( lb ).ReadInt16( ub ); rStrm.ReadInt16( lb ).ReadInt16( ub );
AddDim( lb, ub ); AddDim( lb, ub );
} }
@ -807,7 +805,7 @@ bool SbxDimArray::StoreData( SvStream& rStrm ) const
{ {
short lb, ub; short lb, ub;
GetDim( i, lb, ub ); GetDim( i, lb, ub );
rStrm.WriteInt16( (sal_Int16) lb ).WriteInt16( (sal_Int16) ub ); rStrm.WriteInt16( lb ).WriteInt16( ub );
} }
return SbxArray::StoreData( rStrm ); return SbxArray::StoreData( rStrm );
} }

18
chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx
View File

@ -198,7 +198,7 @@ bool ErrorBarItemConverter::ApplySpecialItem(
double fValue = double fValue =
static_cast< const SvxDoubleItem & >( static_cast< const SvxDoubleItem & >(
rItemSet.Get( nWhichId )).GetValue(); rItemSet.Get( nWhichId )).GetValue();
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
if( ! ( ::rtl::math::approxEqual( fPos, fValue ) && if( ! ( ::rtl::math::approxEqual( fPos, fValue ) &&
@ -216,7 +216,7 @@ bool ErrorBarItemConverter::ApplySpecialItem(
double fValue = double fValue =
static_cast< const SvxDoubleItem & >( static_cast< const SvxDoubleItem & >(
rItemSet.Get( nWhichId )).GetValue(); rItemSet.Get( nWhichId )).GetValue();
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( GetPropertySet(), fPos, fNeg ); lcl_getErrorValues( GetPropertySet(), fPos, fNeg );
if( ! ::rtl::math::approxEqual( fPos, fValue )) if( ! ::rtl::math::approxEqual( fPos, fValue ))
@ -234,7 +234,7 @@ bool ErrorBarItemConverter::ApplySpecialItem(
double fValue = double fValue =
static_cast< const SvxDoubleItem & >( static_cast< const SvxDoubleItem & >(
rItemSet.Get( nWhichId )).GetValue(); rItemSet.Get( nWhichId )).GetValue();
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
if( ! ::rtl::math::approxEqual( fNeg, fValue )) if( ! ::rtl::math::approxEqual( fNeg, fValue ))
@ -256,7 +256,7 @@ bool ErrorBarItemConverter::ApplySpecialItem(
bool bNewIndPos = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_UP ); bool bNewIndPos = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_UP );
bool bNewIndNeg = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_DOWN ); bool bNewIndNeg = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_DOWN );
bool bShowPos, bShowNeg; bool bShowPos(false), bShowNeg(false);
lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg ); lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg );
if( ( bShowPos != bNewIndPos || if( ( bShowPos != bNewIndPos ||
@ -369,7 +369,7 @@ void ErrorBarItemConverter::FillSpecialItem(
case SCHATTR_STAT_PERCENT: case SCHATTR_STAT_PERCENT:
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( GetPropertySet(), fPos, fNeg ); lcl_getErrorValues( GetPropertySet(), fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId )); rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId ));
} }
@ -377,7 +377,7 @@ void ErrorBarItemConverter::FillSpecialItem(
case SCHATTR_STAT_BIGERROR: case SCHATTR_STAT_BIGERROR:
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( GetPropertySet(), fPos, fNeg ); lcl_getErrorValues( GetPropertySet(), fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId )); rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId ));
} }
@ -385,7 +385,7 @@ void ErrorBarItemConverter::FillSpecialItem(
case SCHATTR_STAT_CONSTPLUS: case SCHATTR_STAT_CONSTPLUS:
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( GetPropertySet(), fPos, fNeg ); lcl_getErrorValues( GetPropertySet(), fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( fPos, nWhichId )); rOutItemSet.Put( SvxDoubleItem( fPos, nWhichId ));
} }
@ -393,7 +393,7 @@ void ErrorBarItemConverter::FillSpecialItem(
case SCHATTR_STAT_CONSTMINUS: case SCHATTR_STAT_CONSTMINUS:
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( GetPropertySet(), fPos, fNeg ); lcl_getErrorValues( GetPropertySet(), fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( fNeg, nWhichId )); rOutItemSet.Put( SvxDoubleItem( fNeg, nWhichId ));
} }
@ -402,7 +402,7 @@ void ErrorBarItemConverter::FillSpecialItem(
case SCHATTR_STAT_INDICATE: case SCHATTR_STAT_INDICATE:
{ {
SvxChartIndicate eIndicate = CHINDICATE_BOTH; SvxChartIndicate eIndicate = CHINDICATE_BOTH;
bool bShowPos, bShowNeg; bool bShowPos(false), bShowNeg(false);
lcl_getErrorIndicatorValues( GetPropertySet(), bShowPos, bShowNeg ); lcl_getErrorIndicatorValues( GetPropertySet(), bShowPos, bShowNeg );
if( bShowPos ) if( bShowPos )

18
chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
View File

@ -392,7 +392,7 @@ bool StatisticsItemConverter::ApplySpecialItem(
double fValue = double fValue =
static_cast< const SvxDoubleItem & >( static_cast< const SvxDoubleItem & >(
rItemSet.Get( nWhichId )).GetValue(); rItemSet.Get( nWhichId )).GetValue();
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
if( bOldHasErrorBar && if( bOldHasErrorBar &&
@ -418,7 +418,7 @@ bool StatisticsItemConverter::ApplySpecialItem(
double fValue = double fValue =
static_cast< const SvxDoubleItem & >( static_cast< const SvxDoubleItem & >(
rItemSet.Get( nWhichId )).GetValue(); rItemSet.Get( nWhichId )).GetValue();
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
if( bOldHasErrorBar && if( bOldHasErrorBar &&
@ -441,7 +441,7 @@ bool StatisticsItemConverter::ApplySpecialItem(
double fValue = double fValue =
static_cast< const SvxDoubleItem & >( static_cast< const SvxDoubleItem & >(
rItemSet.Get( nWhichId )).GetValue(); rItemSet.Get( nWhichId )).GetValue();
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
if( bOldHasErrorBar && if( bOldHasErrorBar &&
@ -573,7 +573,7 @@ bool StatisticsItemConverter::ApplySpecialItem(
bool bNewIndPos = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_UP ); bool bNewIndPos = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_UP );
bool bNewIndNeg = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_DOWN ); bool bNewIndNeg = (eIndicate == CHINDICATE_BOTH || eIndicate == CHINDICATE_DOWN );
bool bShowPos, bShowNeg; bool bShowPos(false), bShowNeg(false);
lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg ); lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg );
if( bOldHasErrorBar && if( bOldHasErrorBar &&
@ -704,7 +704,7 @@ void StatisticsItemConverter::FillSpecialItem(
uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError)); uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError));
if( xErrorBarProp.is()) if( xErrorBarProp.is())
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId )); rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId ));
} }
@ -718,7 +718,7 @@ void StatisticsItemConverter::FillSpecialItem(
uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError)); uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError));
if( xErrorBarProp.is()) if( xErrorBarProp.is())
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId )); rOutItemSet.Put( SvxDoubleItem( ( fPos + fNeg ) / 2.0, nWhichId ));
} }
@ -732,7 +732,7 @@ void StatisticsItemConverter::FillSpecialItem(
uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError)); uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError));
if( xErrorBarProp.is()) if( xErrorBarProp.is())
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( fPos, nWhichId )); rOutItemSet.Put( SvxDoubleItem( fPos, nWhichId ));
} }
@ -746,7 +746,7 @@ void StatisticsItemConverter::FillSpecialItem(
uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError)); uno::Reference< beans::XPropertySet > xErrorBarProp( lcl_GetErrorBar( GetPropertySet(),bYError));
if( xErrorBarProp.is()) if( xErrorBarProp.is())
{ {
double fPos, fNeg; double fPos(0.0), fNeg(0.0);
lcl_getErrorValues( xErrorBarProp, fPos, fNeg ); lcl_getErrorValues( xErrorBarProp, fPos, fNeg );
rOutItemSet.Put( SvxDoubleItem( fNeg, nWhichId )); rOutItemSet.Put( SvxDoubleItem( fNeg, nWhichId ));
} }
@ -836,7 +836,7 @@ void StatisticsItemConverter::FillSpecialItem(
SvxChartIndicate eIndicate = CHINDICATE_BOTH; SvxChartIndicate eIndicate = CHINDICATE_BOTH;
if( xErrorBarProp.is()) if( xErrorBarProp.is())
{ {
bool bShowPos, bShowNeg; bool bShowPos(false), bShowNeg(false);
lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg ); lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg );
if( bShowPos ) if( bShowPos )