mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

logerrit: for review, we need to grep for revision, not ref

Browse Source 
Change-Id: I0fb8b1e4f14e153adae7a2ec1b3adbb0dab5c847
This commit is contained in:
Miklos Vajna
2012-07-05 13:22:47 +02:00
parent f3b1a15813
commit 2fab1a73b1
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
logerrit
View File

@@ -8,6 +8,10 @@ get_SHA_for_change() {
SHA=`ssh ${GERRITHOST?} gerrit query --all-approvals change:$1|grep ref|tail -1|cut -d: -f2` SHA=`ssh ${GERRITHOST?} gerrit query --all-approvals change:$1|grep ref|tail -1|cut -d: -f2`
} }
get_REVISION_for_change() {
REVISION=`ssh ${GERRITHOST?} gerrit query --all-approvals change:$1|grep revision|tail -1|cut -d: -f2`
}
ask_tristate() { ask_tristate() {
case $1 in case $1 in
[yY] | [yY][Ee][Ss] | [+] ) [yY] | [yY][Ee][Ss] | [+] )
@@ -159,8 +163,8 @@ case "$1" in
;; ;;
esac esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
get_SHA_for_change $CHANGEID get_REVISION_for_change $CHANGEID
ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SHA ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $REVISION
;; ;;
checkout) checkout)
get_SHA_for_change $2 get_SHA_for_change $2