mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Following "Simplify a bit SfxAllEnumItem (svl)"

Browse Source 
As Mike suggested in:
https://gerrit.libreoffice.org/#/c/80089/

Change-Id: Ie33cb1464907215ec23bf7be7cf5ce3fafdf6113
Reviewed-on: https://gerrit.libreoffice.org/80161
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Julien Nabet
2019-10-03 20:45:02 +02:00
parent 34095197fc
commit 30308a8b4c
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
svl/source/items/aeitem.cxx
View File

@@ -108,10 +108,9 @@ void SfxAllEnumItem::InsertValue( sal_uInt16 nValue, const OUString &rValue )
SfxAllEnumValue_Impl aVal; SfxAllEnumValue_Impl aVal;
aVal.nValue = nValue; aVal.nValue = nValue;
aVal.aText = rValue; aVal.aText = rValue;
sal_uInt16 nPos = GetPosByValue(nValue);
if ( !pValues ) if ( !pValues )
pValues.reset( new SfxAllEnumValueArr ); pValues.reset( new SfxAllEnumValueArr );
else if ( nPos != USHRT_MAX ) else if ( sal_uInt16 nPos = GetPosByValue(nValue); nPos != USHRT_MAX )
{ {
// remove when exists // remove when exists
pValues->erase( pValues->begin() + nPos ); pValues->erase( pValues->begin() + nPos );