mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unusedfields

Browse Source 
Change-Id: If0df5216dccd2c0a7aa790668471993f5d4d5d32
Reviewed-on: https://gerrit.libreoffice.org/80183
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2019-10-04 09:42:28 +02:00
parent ffa35b82ce
commit 316557d6f4
16 changed files with 34 additions and 86 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
compilerplugins/clang/unusedfields.only-used-in-constructor.results
View File

@ -146,7 +146,7 @@ cui/source/inc/tabstpge.hxx:87
SvxTabulatorTabPage m_aCenterWin class TabWin_Impl
cui/source/inc/tabstpge.hxx:88
SvxTabulatorTabPage m_aDezWin class TabWin_Impl
cui/source/options/optcolor.cxx:237
cui/source/options/optcolor.cxx:235
ColorConfigWindow_Impl::Entry m_aDefaultColor class Color
dbaccess/source/core/api/RowSet.hxx:111
dbaccess::ORowSet m_aURL class rtl::OUString
@ -570,10 +570,6 @@ sc/source/ui/inc/msgpool.hxx:44
ScMessagePool aCondFormatDlgItem class ScCondFormatDlgItem
sc/source/ui/inc/notemark.hxx:46
ScNoteMarker m_aTimer class Timer
sc/source/ui/inc/output.hxx:188
ScOutputData nTilePosX long
sc/source/ui/inc/output.hxx:189
ScOutputData nTilePosY long
sc/source/ui/inc/PivotLayoutTreeListBase.hxx:48
ScPivotLayoutTreeListBase maDropTargetHelper class ScPivotLayoutTreeDropTarget
sc/source/ui/inc/xmlsourcedlg.hxx:62
@ -630,10 +626,10 @@ sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition array rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition dict_begin rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition value rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition dict_end rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition value rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:264
PDFGrammar::definition object_end rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:264
@ -806,8 +802,6 @@ vcl/inc/salmenu.hxx:43
SalMenuButtonItem maImage class Image
vcl/inc/salmenu.hxx:44
SalMenuButtonItem maToolTipText class rtl::OUString
vcl/inc/unx/gtk/gtkframe.hxx:186
GtkSalFrame m_nWorkArea int
vcl/inc/unx/i18n_ic.hxx:40
SalI18N_InputContext maPreeditStartCallback XIMCallback
vcl/inc/unx/i18n_ic.hxx:41
@ -832,9 +826,9 @@ vcl/inc/WidgetThemeLibrary.hxx:90
vcl::ControlDrawParameters eState enum ControlState
vcl/inc/WidgetThemeLibrary.hxx:106
vcl::WidgetThemeLibrary_t nSize uint32_t
vcl/source/app/salvtables.cxx:2870
vcl/source/app/salvtables.cxx:2890
SalInstanceEntry m_aTextFilter class (anonymous namespace)::WeldTextFilter
vcl/source/app/salvtables.cxx:5358
vcl/source/app/salvtables.cxx:5378
SalInstanceComboBoxWithEdit m_aTextFilter class (anonymous namespace)::WeldTextFilter
vcl/source/gdi/jobset.cxx:35
ImplOldJobSetupData cDeviceName char [32]

46
compilerplugins/clang/unusedfields.readonly.results
View File

@ -158,7 +158,7 @@ cppu/source/uno/check.cxx:134
(anonymous namespace)::Char3 c3 char
cppu/source/uno/check.cxx:138
(anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
cui/source/options/optcolor.cxx:255
cui/source/options/optcolor.cxx:253
ColorConfigWindow_Impl aModuleOptions class SvtModuleOptions
cui/source/options/optpath.cxx:67
OptPath_Impl m_aDefOpt class SvtDefaultOptions
@ -178,9 +178,7 @@ dbaccess/source/ui/inc/charsetlistbox.hxx:44
dbaui::CharSetListBox m_aCharSets class dbaui::OCharsetDisplay
dbaccess/source/ui/inc/directsql.hxx:65
dbaui::DirectSQLDialog m_aColorConfig const svtools::ColorConfig
dbaccess/source/ui/inc/indexdialog.hxx:43
dbaui::DbaIndexDialog m_bEditingActive _Bool
dbaccess/source/ui/inc/WCopyTable.hxx:263
dbaccess/source/ui/inc/WCopyTable.hxx:261
dbaui::OCopyTableWizard m_aLocale css::lang::Locale
drawinglayer/source/processor2d/vclprocessor2d.hxx:84
drawinglayer::processor2d::VclProcessor2D maDrawinglayerOpt const class SvtOptionsDrawinglayer
@ -374,22 +372,16 @@ include/unoidl/unoidl.hxx:453
unoidl::ConstantValue::(anonymous) doubleValue double
include/unotest/bootstrapfixturebase.hxx:52
test::BootstrapFixtureBase m_directories class test::Directories
include/vcl/edit.hxx:88
Edit maUpdateDataHdl Link<class Edit &, void>
include/vcl/opengl/OpenGLContext.hxx:48
OpenGLCapabilitySwitch mbLimitedShaderRegisters _Bool
include/vcl/opengl/OpenGLContext.hxx:167
OpenGLContext mpLastFramebuffer class OpenGLFramebuffer *
include/vcl/ppdparser.hxx:127
psp::PPDParser::PPDConstraint m_pKey1 const class psp::PPDKey *
include/vcl/settings.hxx:149
DialogStyle content_area_spacing int
include/vcl/settings.hxx:162
FrameStyle left int
include/vcl/settings.hxx:163
FrameStyle right int
include/vcl/settings.hxx:164
FrameStyle top int
include/vcl/settings.hxx:165
FrameStyle bottom int
include/vcl/vclmedit.hxx:85
VclMultiLineEdit aUpdateDataHdlLink Link<class Edit &, void>
io/source/stm/odata.cxx:571
io_stm::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n2 sal_uInt32
io/source/stm/odata.cxx:571
@ -536,7 +528,7 @@ sdext/source/pdfimport/inc/pdfihelper.hxx:102
pdfi::GraphicsContext BlendMode sal_Int8
sdext/source/pdfimport/tree/style.hxx:43
pdfi::StyleContainer::Style Contents const class rtl::OUString
sfx2/source/appl/lnkbase2.cxx:96
sfx2/source/appl/lnkbase2.cxx:95
sfx2::ImplDdeItem pLink class sfx2::SvBaseLink *
slideshow/source/engine/slideshowimpl.cxx:156
(anonymous namespace)::FrameSynchronization maTimer const canvas::tools::ElapsedTime
@ -546,14 +538,6 @@ starmath/source/view.cxx:862
SmViewShell_Impl aOpts class SvtMiscOptions
store/source/storbios.cxx:57
OStoreSuperBlock m_aMarked OStoreSuperBlock::L
svgio/inc/svgstyleattributes.hxx:185
svgio::svgreader::SvgStyleAttributes mpSvgGradientNodeFill const class svgio::svgreader::SvgGradientNode *
svgio/inc/svgstyleattributes.hxx:186
svgio::svgreader::SvgStyleAttributes mpSvgGradientNodeStroke const class svgio::svgreader::SvgGradientNode *
svgio/inc/svgstyleattributes.hxx:187
svgio::svgreader::SvgStyleAttributes mpSvgPatternNodeFill const class svgio::svgreader::SvgPatternNode *
svgio/inc/svgstyleattributes.hxx:188
svgio::svgreader::SvgStyleAttributes mpSvgPatternNodeStroke const class svgio::svgreader::SvgPatternNode *
svl/source/crypto/cryptosign.cxx:283
(anonymous namespace)::PKIStatusInfo status SECItem
svl/source/crypto/cryptosign.cxx:303
@ -726,6 +710,10 @@ unotools/source/config/saveopt.cxx:76
SvtSaveOptions_Impl bROUserAutoSave _Bool
vcl/inc/BitmapFastScaleFilter.hxx:31
BitmapFastScaleFilter maSize const class Size
vcl/inc/openglgdiimpl.hxx:52
TextureCombo mpTexture std::unique_ptr<OpenGLTexture>
vcl/inc/openglgdiimpl.hxx:53
TextureCombo mpMask std::unique_ptr<OpenGLTexture>
vcl/inc/printerinfomanager.hxx:74
psp::PrinterInfoManager::SystemPrintQueue m_aComment class rtl::OUString
vcl/inc/salwtype.hxx:157
@ -736,14 +724,8 @@ vcl/inc/salwtype.hxx:205
SalSurroundingTextSelectionChangeEvent mnEnd const sal_uLong
vcl/inc/salwtype.hxx:211
SalQueryCharPositionEvent mnCharPos sal_uLong
vcl/inc/svdata.hxx:269
ImplSVNWFData mnMenuSeparatorBorderX int
vcl/inc/svdata.hxx:272
vcl/inc/svdata.hxx:271
ImplSVNWFData mbMenuBarDockingAreaCommonBG _Bool
vcl/inc/svdata.hxx:276
ImplSVNWFData mbToolboxDropDownSeparate _Bool
vcl/inc/svdata.hxx:279
ImplSVNWFData mbOpenMenuOnF10 _Bool
vcl/inc/toolbox.h:108
vcl::ToolBoxLayoutData m_aLineItemIds std::vector<sal_uInt16>
vcl/inc/unx/saldisp.hxx:282
@ -898,6 +880,10 @@ vcl/inc/WidgetThemeLibrary.hxx:135
vcl::WidgetThemeLibrary_t drawListHeader _Bool (*)(const struct vcl::ControlDrawParameters &, long, long)
vcl/inc/WidgetThemeLibrary.hxx:137
vcl::WidgetThemeLibrary_t updateSettings _Bool (*)(struct vcl::WidgetDrawStyle &)
vcl/inc/wizdlg.hxx:78
vcl::RoadmapWizard maActivateHdl Link<class vcl::RoadmapWizard *, void>
vcl/source/app/settings.cxx:184
ImplStyleData maDialogStyle struct DialogStyle
vcl/source/control/roadmapwizard.cxx:62
vcl::RoadmapWizardImpl aStateDescriptors vcl::(anonymous namespace)::StateDescriptions
vcl/source/control/tabctrl.cxx:79

14
compilerplugins/clang/unusedfields.untouched.results
View File

@ -118,10 +118,10 @@ include/sfx2/msg.hxx:138
SfxType7 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:138
SfxType7 pType const std::type_info *
include/sfx2/msg.hxx:139
SfxType8 nAttribs sal_uInt16
include/sfx2/msg.hxx:139
SfxType8 pType const std::type_info *
include/sfx2/msg.hxx:139
SfxType8 nAttribs sal_uInt16
include/sfx2/msg.hxx:139
SfxType8 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:139
@ -146,10 +146,10 @@ include/sfx2/msg.hxx:143
SfxType13 pType const std::type_info *
include/sfx2/msg.hxx:143
SfxType13 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:143
SfxType13 aAttrib struct SfxTypeAttrib [13]
include/sfx2/msg.hxx:143
SfxType13 nAttribs sal_uInt16
include/sfx2/msg.hxx:143
SfxType13 aAttrib struct SfxTypeAttrib [13]
include/sfx2/msg.hxx:144
SfxType14 pType const std::type_info *
include/sfx2/msg.hxx:144
@ -326,10 +326,6 @@ sc/source/filter/inc/sheetdatacontext.hxx:62
oox::xls::SheetDataContext aReleaser const class SolarMutexReleaser
sc/source/ui/inc/docsh.hxx:455
ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
sc/source/ui/inc/output.hxx:188
ScOutputData nTilePosX long
sc/source/ui/inc/output.hxx:189
ScOutputData nTilePosY long
sc/source/ui/inc/PivotLayoutTreeListBase.hxx:48
ScPivotLayoutTreeListBase maDropTargetHelper class ScPivotLayoutTreeDropTarget
sd/source/ui/remotecontrol/ZeroconfService.hxx:34
@ -426,8 +422,6 @@ vcl/inc/qt5/Qt5Graphics.hxx:58
Qt5Graphics m_lastPopupRect class QRect
vcl/inc/salprn.hxx:45
SalPrinterQueueInfo mpPortName std::unique_ptr<OUString>
vcl/inc/unx/gtk/gtkframe.hxx:186
GtkSalFrame m_nWorkArea int
vcl/inc/WidgetThemeLibrary.hxx:87
vcl::ControlDrawParameters nSize uint32_t
vcl/inc/WidgetThemeLibrary.hxx:88

26
compilerplugins/clang/unusedfields.writeonly.results
View File

@ -2,9 +2,9 @@ basctl/source/basicide/moduldlg.hxx:131
basctl::ObjectPage m_xDropTarget std::unique_ptr<SbTreeListBoxDropTarget>
basctl/source/inc/basidesh.hxx:87
basctl::Shell m_aNotifier class basctl::DocumentEventNotifier
basctl/source/inc/bastype2.hxx:183
basctl/source/inc/bastype2.hxx:182
basctl::TreeListBox m_aNotifier class basctl::DocumentEventNotifier
basctl/source/inc/bastype2.hxx:255
basctl/source/inc/bastype2.hxx:251
basctl::SbTreeListBox m_aNotifier class basctl::DocumentEventNotifier
basctl/source/inc/IDEComboBox.hxx:101
basctl::DocListenerBox maNotifier class basctl::DocumentEventNotifier
@ -230,10 +230,10 @@ dbaccess/source/filter/xml/dbloader2.cxx:227
dbaxml::DBContentLoader m_xMySelf Reference<class com::sun::star::frame::XFrameLoader>
dbaccess/source/ui/browser/dbloader.cxx:69
DBContentLoader m_xListener Reference<class com::sun::star::frame::XLoadEventListener>
dbaccess/source/ui/inc/FieldDescControl.hxx:112
dbaui::OFieldDescControl m_bRightAligned _Bool
dbaccess/source/ui/inc/RelationController.hxx:33
dbaui::ORelationController m_pWaitObject std::unique_ptr<WaitObject>
dbaccess/source/ui/inc/WTypeSelect.hxx:74
dbaui::OWizTypeSelectList m_pParentTabPage class dbaui::OWizTypeSelect *
desktop/qa/desktop_lib/test_desktop_lib.cxx:223
DesktopLOKTest m_bModified _Bool
desktop/source/app/app.cxx:1209
@ -352,6 +352,8 @@ include/editeng/adjustitem.hxx:37
SvxAdjustItem bLeft _Bool
include/editeng/outlobj.hxx:43
OutlinerParaObjData mbIsEditDoc _Bool
include/editeng/splwrap.hxx:59
SvxSpellWrapper bHyphen _Bool
include/editeng/unotext.hxx:415
SvxUnoTextBase xParentText css::uno::Reference<css::text::XText>
include/editeng/unotext.hxx:584
@ -408,10 +410,10 @@ include/svx/srchdlg.hxx:162
SvxSearchDialog pSearchController std::unique_ptr<SvxSearchController>
include/svx/srchdlg.hxx:163
SvxSearchDialog pOptionsController std::unique_ptr<SvxSearchController>
include/svx/viewpt3d.hxx:62
Viewport3D::(anonymous) X double
include/svx/viewpt3d.hxx:62
Viewport3D::(anonymous) H double
include/svx/viewpt3d.hxx:62
Viewport3D::(anonymous) X double
include/svx/viewpt3d.hxx:62
Viewport3D::(anonymous) Y double
include/test/beans/xpropertyset.hxx:56
@ -784,10 +786,6 @@ sw/inc/unoframe.hxx:313
SwXOLEListener m_xOLEModel css::uno::Reference<css::frame::XModel>
sw/inc/view.hxx:184
SwView m_xGlueDocShell std::unique_ptr<SwViewGlueDocShell>
sw/qa/api/SwXTextFrame.cxx:46
(anonymous namespace)::SwXTextFrame mxTextRange uno::Reference<text::XTextRange>
sw/qa/api/SwXTextFrame.cxx:47
(anonymous namespace)::SwXTextFrame mxTextContent uno::Reference<text::XTextContent>
sw/source/core/inc/swfont.hxx:986
SvStatistics nGetTextSize sal_uInt16
sw/source/core/inc/swfont.hxx:987
@ -950,7 +948,7 @@ vcl/inc/salwtype.hxx:250
SalSwipeEvent mnVelocityY double
vcl/inc/sft.hxx:478
vcl::TrueTypeFont mapper sal_uInt32 (*)(const sal_uInt8 *, sal_uInt32, sal_uInt32)
vcl/inc/svdata.hxx:408
vcl/inc/svdata.hxx:403
ImplSVEvent mpInstanceRef VclPtr<vcl::Window>
vcl/inc/unx/gtk/gtkframe.hxx:80
GtkSalFrame::IMHandler::PreviousKeyPress window GdkWindow *
@ -958,12 +956,6 @@ vcl/inc/unx/gtk/gtkframe.hxx:81
GtkSalFrame::IMHandler::PreviousKeyPress send_event gint8
vcl/inc/unx/gtk/gtkframe.hxx:82
GtkSalFrame::IMHandler::PreviousKeyPress time guint32
vcl/inc/unx/gtk/gtkframe.hxx:191
GtkSalFrame m_bWindowIsGtkPlug _Bool
vcl/inc/unx/gtk/gtkframe.hxx:192
GtkSalFrame m_aTitle class rtl::OUString
vcl/inc/unx/salframe.h:99
X11SalFrame mbInShow _Bool
vcl/inc/WidgetThemeLibrary.hxx:20
vcl::WidgetDrawStyle nSize uint32_t
vcl/inc/WidgetThemeLibrary.hxx:91

2
dbaccess/source/ui/control/ColumnControlWindow.cxx
View File

@ -43,8 +43,6 @@ OColumnControlWindow::OColumnControlWindow(vcl::Window* pParent
, m_sTypeNames(DBA_RES(STR_TABLEDESIGN_DBFIELDTYPES))
, m_bAutoIncrementEnabled(true)
{
setRightAligned();
m_aLocale = SvtSysLocale().GetLanguageTag().getLocale();
}

1
dbaccess/source/ui/control/FieldDescControl.cxx
View File

@ -88,7 +88,6 @@ OFieldDescControl::OFieldDescControl(weld::Container* pPage, vcl::Window* pParen
,aNo(DBA_RES(STR_VALUE_NO))
,m_nEditWidth(50)
,m_bAdded(false)
,m_bRightAligned(false)
,pActFieldDescr(nullptr)
{
}

3
dbaccess/source/ui/inc/FieldDescControl.hxx
View File

@ -109,7 +109,6 @@ namespace dbaui
sal_Int32 m_nEditWidth;
bool m_bAdded;
bool m_bRightAligned;
OFieldDescription* pActFieldDescr;
@ -130,8 +129,6 @@ namespace dbaui
void InitializeControl(OPropListBoxCtrl* _pControl,const OString& _sHelpId,bool _bAddChangeHandler);
protected:
void setRightAligned() { m_bRightAligned = true; }
void saveCurrentFieldDescData() { SaveData( pActFieldDescr ); }
OFieldDescription* getCurrentFieldDescData() { return pActFieldDescr; }
void setCurrentFieldDescData( OFieldDescription* _pDesc ) { pActFieldDescr = _pDesc; }

2
editeng/source/misc/splwrap.cxx
View File

@ -144,7 +144,6 @@ SvxSpellWrapper::SvxSpellWrapper( vcl::Window* pWn,
pWin ( pWn ),
bOtherCntnt ( false ),
bHyphen ( false ),
bStartChk ( false ),
bRevAllowed ( true ),
bAllRight ( bIsAllRight )
@ -163,7 +162,6 @@ SvxSpellWrapper::SvxSpellWrapper( vcl::Window* pWn,
pWin ( pWn ),
xHyph ( xHyphenator ),
bOtherCntnt ( bOther ),
bHyphen ( false ),
bReverse ( false ),
bStartDone ( bOther || bStart ),
bEndDone ( false ),

2
include/editeng/splwrap.hxx
View File

@ -56,7 +56,6 @@ private:
css::uno::Reference<
css::linguistic2::XHyphenator > xHyph;
bool bOtherCntnt : 1; // set => Check special sections initially
bool bHyphen : 1; // Split instead of spell checking
bool bReverse : 1; // Reverse spell check
bool bStartDone : 1; // Beginning already corrected
bool bEndDone : 1; // End part already corrected
@ -92,7 +91,6 @@ public:
void SpellDocument(); // Perform Spell Checking
bool IsStartDone() const { return bStartDone; }
bool IsEndDone() const { return bEndDone; }
void SetHyphen() { bHyphen = true; }
bool IsAllRight() const { return bAllRight; }
protected:

1
include/vcl/edit.hxx
View File

@ -85,7 +85,6 @@ private:
mbForceControlBackground:1,
mbPassword;
Link<Edit&,void> maModifyHdl;
Link<Edit&,void> maUpdateDataHdl;
Link<Edit&,void> maAutocompleteHdl;
Link<Edit&,bool> maActivateHdl;
std::unique_ptr<VclBuilder> mpUIBuilder;

1
include/vcl/vclmedit.hxx
View File

@ -82,7 +82,6 @@ private:
Link<Edit&,void> aModifyHdlLink;
std::unique_ptr<Timer> pUpdateDataTimer;
Link<Edit&,void> aUpdateDataHdlLink;
protected:

1
sw/source/uibase/lingu/hyp.cxx
View File

@ -55,7 +55,6 @@ SwHyphWrapper::SwHyphWrapper( SwView* pVw,
{
uno::Reference< linguistic2::XLinguProperties > xProp( GetLinguPropertySet() );
bAutomatic = xProp.is() && xProp->getIsHyphAuto();
SetHyphen();
}
void SwHyphWrapper::SpellStart( SvxSpellArea eSpell )

1
vcl/inc/wizdlg.hxx
View File

@ -75,7 +75,6 @@ namespace vcl
VclPtr<vcl::Window> mpViewWindow;
sal_uInt16 mnCurLevel;
WindowAlign meViewAlign;
Link<RoadmapWizard*,void> maActivateHdl;
sal_Int16 mnLeftAlignCount;
bool mbEmptyViewMargin;

1
vcl/source/control/edit.cxx
View File

@ -2350,7 +2350,6 @@ void Edit::Modify()
void Edit::UpdateData()
{
maUpdateDataHdl.Call( *this );
}
IMPL_LINK_NOARG(Edit, ImplUpdateDataHdl, Timer *, void)

2
vcl/source/control/wizardmachine.cxx
View File

@ -562,8 +562,6 @@ namespace vcl
void RoadmapWizard::ActivatePage()
{
maActivateHdl.Call( this );
WizardTypes::WizardState nCurrentLevel = GetCurLevel();
GetOrCreatePage( nCurrentLevel );

1
vcl/source/edit/vclmedit.cxx
View File

@ -1007,7 +1007,6 @@ IMPL_LINK_NOARG(VclMultiLineEdit, ImpUpdateDataHdl, Timer *, void)
void VclMultiLineEdit::UpdateData()
{
aUpdateDataHdlLink.Call( *this );
}
void VclMultiLineEdit::SetModifyFlag()