New --enable-compiler-plugins=debug mode

...to enable debug-only code in the plugins.  Some situations in the plugin code
should never happen, yet must not by default report errors or trigger
assertions, as some newly written LO code could trigger them nevertheless (in
which case the plugin code will likely need to be adapted, to cater for these
presumed-impossible situations).

Such code can now be included in the plugins behind an if(isDebugMode()) guard,
and can explicitly be enabled with --enable-compiler-plugins=debug.

I deliberately made this a runtime rather than a compile time option (using
some #ifdef guards in the plugin code, say), as it IMO keeps the code more
readable, and also allows overridding COMPILER_PLUGINS_DEBUG=... on the make
command line.

Change-Id: Iea4f0c2783ad968a0de097fa710b3be1a248de73
Reviewed-on: https://gerrit.libreoffice.org/46096
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2017-12-08 16:31:34 +01:00
parent 3985483707
commit 32c31c03d0
8 changed files with 32 additions and 1 deletions

View File

@@ -113,6 +113,8 @@ void PluginHandler::handleOption( const std::string& option )
warningsAsErrors = true;
else if( option == "unit-test-mode" )
unitTestMode = true;
else if (option == "debug")
debugMode = true;
else
report( DiagnosticsEngine::Fatal, "unknown option %0" ) << option;
}