mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in Animation::prefetch

Browse Source 
Change-Id: I7eaf01548567ce560b0e32f222880d21b966c78d
Reviewed-on: https://gerrit.libreoffice.org/81071
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2019-10-17 14:42:29 +02:00
parent c66e8c7f94
commit 33e176552d
8 changed files with 13 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@ -292,9 +292,6 @@ slideshow/source/engine/opengl/TransitionImpl.hxx:174
slideshow/source/engine/opengl/TransitionImpl.hxx:180
void OGLTransitionImpl::finish(double,double,double,double,double,)
00000
slideshow/source/inc/animation.hxx:61
void slideshow::internal::Animation::prefetch(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
00
starmath/source/wordexportbase.hxx:37
void SmWordExportBase::HandleText(const class SmNode *,int,)
10

9
slideshow/source/engine/animationfactory.cxx
View File

@ -88,8 +88,7 @@ namespace slideshow
// Animation interface
virtual void prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& ) override
virtual void prefetch() override
{}
virtual void start( const AnimatableShapeSharedPtr& rShape,
@ -242,8 +241,7 @@ namespace slideshow
// Animation interface
virtual void prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& ) override
virtual void prefetch() override
{}
virtual void start( const AnimatableShapeSharedPtr& rShape,
@ -440,8 +438,7 @@ namespace slideshow
// Animation interface
virtual void prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& )
virtual void prefetch()
{}
virtual void start( const AnimatableShapeSharedPtr& rShape,

3
slideshow/source/engine/animationnodes/animationcolornode.cxx
View File

@ -49,8 +49,7 @@ public:
"HSLWrapper::HSLWrapper(): Invalid color animation delegate" );
}
virtual void prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& ) override
virtual void prefetch() override
{}
virtual void start( const AnimatableShapeSharedPtr& rShape,

4
slideshow/source/engine/slideshowimpl.cxx
View File

@ -852,9 +852,7 @@ ActivitySharedPtr SlideShowImpl::createSlideTransition(
// reached final size
maEventQueue.addEvent(
makeEvent( [pTransition] () {
pTransition->prefetch(
AnimatableShapeSharedPtr(),
ShapeAttributeLayerSharedPtr()); },
pTransition->prefetch(); },
"Animation::prefetch"));
return ActivitySharedPtr(

6
slideshow/source/engine/transitions/shapetransitionfactory.cxx
View File

@ -63,8 +63,7 @@ public:
// Animation interface
virtual void prefetch( const AnimatableShapeSharedPtr& rShape,
const ShapeAttributeLayerSharedPtr& rAttrLayer ) override;
virtual void prefetch() override;
virtual void start( const AnimatableShapeSharedPtr& rShape,
const ShapeAttributeLayerSharedPtr& rAttrLayer ) override;
virtual void end() override;
@ -116,8 +115,7 @@ ClippingAnimation::~ClippingAnimation()
}
}
void ClippingAnimation::prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& )
void ClippingAnimation::prefetch()
{
}

9
slideshow/source/engine/transitions/slidechangebase.cxx
View File

@ -169,8 +169,7 @@ void SlideChangeBase::renderBitmap(
pSlideBitmap->draw( pDevicePixelCanvas );
}
void SlideChangeBase::prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& )
void SlideChangeBase::prefetch()
{
// we're a one-shot activity, and already finished
if( mbFinished || mbPrefetched )
@ -186,14 +185,14 @@ void SlideChangeBase::prefetch( const AnimatableShapeSharedPtr&,
mbPrefetched = true;
}
void SlideChangeBase::start( const AnimatableShapeSharedPtr& rShape,
const ShapeAttributeLayerSharedPtr& rLayer )
void SlideChangeBase::start( const AnimatableShapeSharedPtr& /*rShape*/,
const ShapeAttributeLayerSharedPtr& /*rLayer*/ )
{
// we're a one-shot activity, and already finished
if( mbFinished )
return;
prefetch(rShape,rLayer); // no-op, if already done
prefetch(); // no-op, if already done
// get the subclasses a chance to do any specific initialization before run
for ( ViewsVecT::const_iterator aCurr( beginViews() ), aEnd( endViews() ); aCurr != aEnd; ++aCurr )

3
slideshow/source/engine/transitions/slidechangebase.hxx
View File

@ -57,8 +57,7 @@ public:
virtual double getUnderlyingValue() const override;
// Animation
virtual void prefetch( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& ) override;
virtual void prefetch() override;
virtual void start( const AnimatableShapeSharedPtr&,
const ShapeAttributeLayerSharedPtr& ) override;
virtual void end() override;

3
slideshow/source/inc/animation.hxx
View File

@ -58,8 +58,7 @@ namespace slideshow
@param rAttrLayer
Attribute layer to play the animation on.
*/
virtual void prefetch( const AnimatableShapeSharedPtr& rShape,
const ShapeAttributeLayerSharedPtr& rAttrLayer ) = 0;
virtual void prefetch( ) = 0;
/** Notify that the animation is about to begin.