mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

comphelper,connectivity: prefer passing OUString by reference

Browse Source 
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
This commit is contained in:
Noel Grandin
2014-03-14 07:46:08 +02:00
parent eb4fb12fdb
commit 358be80f65
74 changed files with 90 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
comphelper/source/container/embeddedobjectcontainer.cxx
View File

@@ -52,7 +52,7 @@ namespace comphelper
struct hashObjectName_Impl struct hashObjectName_Impl
{ {
size_t operator()(const OUString Str) const size_t operator()(const OUString & Str) const
{ {
return (size_t)Str.hashCode(); return (size_t)Str.hashCode();
} }
@@ -60,7 +60,7 @@ struct hashObjectName_Impl
struct eqObjectName_Impl struct eqObjectName_Impl
{ {
bool operator()(const OUString Str1, const OUString Str2) const bool operator()(const OUString & Str1, const OUString & Str2) const
{ {
return ( Str1 == Str2 ); return ( Str1 == Str2 );
} }

2
comphelper/source/xml/ofopxmlhelper.cxx
View File

@@ -38,7 +38,7 @@ using namespace ::com::sun::star;
namespace comphelper { namespace comphelper {
uno::Sequence< uno::Sequence< beans::StringPair > > SAL_CALL OFOPXMLHelper::ReadRelationsInfoSequence( const uno::Reference< io::XInputStream >& xInStream, const OUString aStreamName, const uno::Reference< uno::XComponentContext > xContext ) uno::Sequence< uno::Sequence< beans::StringPair > > SAL_CALL OFOPXMLHelper::ReadRelationsInfoSequence( const uno::Reference< io::XInputStream >& xInStream, const OUString & aStreamName, const uno::Reference< uno::XComponentContext > xContext )
throw( uno::Exception ) throw( uno::Exception )
{ {
OUString aStringID = "_rels/"; OUString aStringID = "_rels/";

2
connectivity/source/commontools/TColumnsHelper.cxx
View File

@@ -192,7 +192,7 @@ sdbcx::ObjectType OColumnsHelper::appendObject( const OUString& _rForName, const
} }
// XDrop // XDrop
void OColumnsHelper::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OColumnsHelper::dropObject(sal_Int32 /*_nPos*/, const OUString& _sElementName)
{ {
OSL_ENSURE(m_pTable,"OColumnsHelper::dropByName: Table is null!"); OSL_ENSURE(m_pTable,"OColumnsHelper::dropByName: Table is null!");
if ( m_pTable && !m_pTable->isNew() ) if ( m_pTable && !m_pTable->isNew() )

2
connectivity/source/commontools/TIndexes.cxx
View File

@@ -209,7 +209,7 @@ sdbcx::ObjectType OIndexesHelper::appendObject( const OUString& _rForName, const
} }
// XDrop // XDrop
void OIndexesHelper::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OIndexesHelper::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
Reference< XConnection> xConnection = m_pTable->getConnection(); Reference< XConnection> xConnection = m_pTable->getConnection();
if( xConnection.is() && !m_pTable->isNew()) if( xConnection.is() && !m_pTable->isNew())

2
connectivity/source/commontools/TKeys.cxx
View File

@@ -260,7 +260,7 @@ OUString OKeysHelper::getDropForeignKey() const
} }
// XDrop // XDrop
void OKeysHelper::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OKeysHelper::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{ {
Reference< XConnection> xConnection = m_pTable->getConnection(); Reference< XConnection> xConnection = m_pTable->getConnection();
if ( xConnection.is() && !m_pTable->isNew() ) if ( xConnection.is() && !m_pTable->isNew() )

2
connectivity/source/drivers/ado/AColumns.cxx
View File

@@ -127,7 +127,7 @@ sdbcx::ObjectType OColumns::appendObject( const OUString&, const Reference< XPro
} }
// XDrop // XDrop
void OColumns::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OColumns::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
if(!m_aCollection.Delete(_sElementName)) if(!m_aCollection.Delete(_sElementName))
ADOS::ThrowException(*m_pConnection->getConnection(),static_cast<XTypeProvider*>(this)); ADOS::ThrowException(*m_pConnection->getConnection(),static_cast<XTypeProvider*>(this));

2
connectivity/source/drivers/ado/AGroups.cxx
View File

@@ -66,7 +66,7 @@ sdbcx::ObjectType OGroups::appendObject( const OUString& _rForName, const Refere
} }
// XDrop // XDrop
void OGroups::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OGroups::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
m_aCollection.Delete(_sElementName); m_aCollection.Delete(_sElementName);
} }

2
connectivity/source/drivers/ado/AIndexes.cxx
View File

@@ -71,7 +71,7 @@ sdbcx::ObjectType OIndexes::appendObject( const OUString& _rForName, const Refer
} }
// XDrop // XDrop
void OIndexes::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OIndexes::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
m_aCollection.Delete(_sElementName); m_aCollection.Delete(_sElementName);
} }

2
connectivity/source/drivers/ado/AKeys.cxx
View File

@@ -97,7 +97,7 @@ sdbcx::ObjectType OKeys::appendObject( const OUString&, const Reference< XProper
} }
// XDrop // XDrop
void OKeys::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OKeys::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
if(!m_aCollection.Delete(OLEVariant(_sElementName))) if(!m_aCollection.Delete(OLEVariant(_sElementName)))
ADOS::ThrowException(*m_pConnection->getConnection(),static_cast<XTypeProvider*>(this)); ADOS::ThrowException(*m_pConnection->getConnection(),static_cast<XTypeProvider*>(this));

2
connectivity/source/drivers/ado/ATables.cxx
View File

@@ -77,7 +77,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString&, const Reference< XProp
} }
// XDrop // XDrop
void OTables::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OTables::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
OSL_ENSURE(m_aCollection.IsValid(),"Collection isn't valid"); OSL_ENSURE(m_aCollection.IsValid(),"Collection isn't valid");
if ( !m_aCollection.Delete(_sElementName) ) if ( !m_aCollection.Delete(_sElementName) )

2
connectivity/source/drivers/ado/AUsers.cxx
View File

@@ -66,7 +66,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen
} }
// XDrop // XDrop
void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
m_aCollection.Delete(_sElementName); m_aCollection.Delete(_sElementName);
} }

2
connectivity/source/drivers/ado/AViews.cxx
View File

@@ -83,7 +83,7 @@ sdbcx::ObjectType OViews::appendObject( const OUString& _rForName, const Referen
} }
// XDrop // XDrop
void OViews::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OViews::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
if(!m_aCollection.Delete(_sElementName)) if(!m_aCollection.Delete(_sElementName))
ADOS::ThrowException(*m_pCatalog->getConnection()->getConnection(),static_cast<XTypeProvider*>(this)); ADOS::ThrowException(*m_pCatalog->getConnection()->getConnection(),static_cast<XTypeProvider*>(this));

2
connectivity/source/drivers/dbase/DColumns.cxx
View File

@@ -70,7 +70,7 @@ sdbcx::ObjectType ODbaseColumns::appendObject( const OUString& _rForName, const
// XDrop // XDrop
void ODbaseColumns::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) void ODbaseColumns::dropObject(sal_Int32 _nPos, const OUString& /*_sElementName*/)
{ {
if(!m_pTable->isNew()) if(!m_pTable->isNew())
m_pTable->dropColumn(_nPos); m_pTable->dropColumn(_nPos);

2
connectivity/source/drivers/dbase/DIndexes.cxx
View File

@@ -104,7 +104,7 @@ sdbcx::ObjectType ODbaseIndexes::appendObject( const OUString& _rForName, const
} }
// XDrop // XDrop
void ODbaseIndexes::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) void ODbaseIndexes::dropObject(sal_Int32 _nPos, const OUString& /*_sElementName*/)
{ {
Reference< XUnoTunnel> xTunnel(getObject(_nPos),UNO_QUERY); Reference< XUnoTunnel> xTunnel(getObject(_nPos),UNO_QUERY);
if ( xTunnel.is() ) if ( xTunnel.is() )

2
connectivity/source/drivers/dbase/DTables.cxx
View File

@@ -92,7 +92,7 @@ sdbcx::ObjectType ODbaseTables::appendObject( const OUString& _rForName, const R
} }
// XDrop // XDrop
void ODbaseTables::dropObject(sal_Int32 _nPos,const OUString _sElementName) void ODbaseTables::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{ {
Reference< XUnoTunnel> xTunnel; Reference< XUnoTunnel> xTunnel;
try try

4
connectivity/source/drivers/firebird/Indexes.cxx
View File

@@ -26,8 +26,8 @@ Indexes::Indexes(Table* pTable, Mutex& rMutex, const vector< OUString>& rVector)
} }
// XDrop // XDrop
void Indexes::dropObject(sal_Int32 /*nPosition*/, const OUString sIndexName) void Indexes::dropObject(sal_Int32 /*nPosition*/, const OUString& sIndexName)
{ {
OUString sSql("DROP INDEX \"" + sIndexName +"\""); OUString sSql("DROP INDEX \"" + sIndexName +"\"");
m_pTable->getConnection()->createStatement()->execute(sSql); m_pTable->getConnection()->createStatement()->execute(sSql);
} }

2
connectivity/source/drivers/firebird/Indexes.hxx
View File

@@ -30,7 +30,7 @@ namespace connectivity
protected: protected:
// XDrop // XDrop
virtual void dropObject(sal_Int32 nPosition, virtual void dropObject(sal_Int32 nPosition,
const ::rtl::OUString sIndexName); const ::rtl::OUString& sIndexName);
public: public:
Indexes(Table* pTable, Indexes(Table* pTable,
::osl::Mutex& rMutex, ::osl::Mutex& rMutex,

4
connectivity/source/drivers/firebird/Keys.cxx
View File

@@ -32,7 +32,7 @@ Keys::Keys(Table* pTable, Mutex& rMutex, const TStringVector& rNames):
} }
//----- XDrop ---------------------------------------------------------------- //----- XDrop ----------------------------------------------------------------
void Keys::dropObject(sal_Int32 nPosition, const OUString sName) void Keys::dropObject(sal_Int32 nPosition, const OUString& sName)
{ {
Reference< XConnection> xConnection = m_pTable->getConnection(); Reference< XConnection> xConnection = m_pTable->getConnection();
@@ -53,4 +53,4 @@ void Keys::dropObject(sal_Int32 nPosition, const OUString sName)
} }
} }
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

4
connectivity/source/drivers/firebird/Keys.hxx
View File

@@ -31,11 +31,11 @@ namespace connectivity
const ::connectivity::TStringVector& rNames); const ::connectivity::TStringVector& rNames);
// OKeysHelper / XDrop // OKeysHelper / XDrop
void dropObject(sal_Int32 nPosition, const ::rtl::OUString sName); void dropObject(sal_Int32 nPosition, const ::rtl::OUString& sName);
}; };
} }
} }
#endif // CONNECTIVITY_FIREBIRD_KEYS_HXX #endif // CONNECTIVITY_FIREBIRD_KEYS_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

4
connectivity/source/drivers/firebird/Tables.cxx
View File

@@ -98,7 +98,7 @@ ObjectType Tables::appendObject(const OUString& rName,
} }
//----- XDrop ----------------------------------------------------------------- //----- XDrop -----------------------------------------------------------------
void Tables::dropObject(sal_Int32 nPosition, const OUString sName) void Tables::dropObject(sal_Int32 nPosition, const OUString& sName)
{ {
uno::Reference< XPropertySet > xTable(getObject(nPosition)); uno::Reference< XPropertySet > xTable(getObject(nPosition));
@@ -117,4 +117,4 @@ void Tables::dropObject(sal_Int32 nPosition, const OUString sName)
} }
} }
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

4
connectivity/source/drivers/firebird/Tables.hxx
View File

@@ -53,7 +53,7 @@ namespace connectivity
// XAppend, etc., but all are optional. // XAppend, etc., but all are optional.
// XDrop // XDrop
virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString rName); virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString& rName);
}; };
@@ -63,4 +63,4 @@ namespace connectivity
#endif // CONNECTIVITY_FIREBIRD_TABLES_HXX #endif // CONNECTIVITY_FIREBIRD_TABLES_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

2
connectivity/source/drivers/firebird/Users.cxx
View File

@@ -75,7 +75,7 @@ ObjectType Users::appendObject(const OUString& rName,
} }
//----- XDrop ----------------------------------------------------------------- //----- XDrop -----------------------------------------------------------------
void Users::dropObject(sal_Int32 nPosition, const OUString sName) void Users::dropObject(sal_Int32 nPosition, const OUString& sName)
{ {
uno::Reference< XPropertySet > xUser(getObject(nPosition)); uno::Reference< XPropertySet > xUser(getObject(nPosition));

2
connectivity/source/drivers/firebird/Users.hxx
View File

@@ -49,7 +49,7 @@ namespace connectivity
// XAppend, etc., but all are optional. // XAppend, etc., but all are optional.
// XDrop // XDrop
virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString rName); virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString& rName);
}; };

2
connectivity/source/drivers/hsqldb/HTables.cxx
View File

@@ -116,7 +116,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString& _rForName, const Refere
} }
// XDrop // XDrop
void OTables::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OTables::dropObject(sal_Int32 _nPos,const OUString& _sElementName)
{ {
Reference< XInterface > xObject( getObject( _nPos ) ); Reference< XInterface > xObject( getObject( _nPos ) );
sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject ); sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject );

2
connectivity/source/drivers/hsqldb/HTools.cxx
View File

@@ -27,7 +27,7 @@ namespace connectivity { namespace hsqldb
void HTools::appendTableFilterCrit( OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog, void HTools::appendTableFilterCrit( OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog,
const OUString _rSchema, const OUString _rName, bool _bShortForm ) const OUString& _rSchema, const OUString& _rName, bool _bShortForm )
{ {
_inout_rBuffer.appendAscii( " WHERE " ); _inout_rBuffer.appendAscii( " WHERE " );
if ( !_rCatalog.isEmpty() ) if ( !_rCatalog.isEmpty() )

2
connectivity/source/drivers/hsqldb/HUsers.cxx
View File

@@ -87,7 +87,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen
} }
// XDrop // XDrop
void OUsers::dropObject(sal_Int32 /*nPos*/,const OUString _sElementName) void OUsers::dropObject(sal_Int32 /*nPos*/,const OUString& _sElementName)
{ {
{ {
OUString aSql( "REVOKE ALL ON * FROM " ); OUString aSql( "REVOKE ALL ON * FROM " );

2
connectivity/source/drivers/hsqldb/HViews.cxx
View File

@@ -99,7 +99,7 @@ sdbcx::ObjectType HViews::appendObject( const OUString& _rForName, const Referen
} }
// XDrop // XDrop
void HViews::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) void HViews::dropObject(sal_Int32 _nPos,const OUString& /*_sElementName*/)
{ {
if ( m_bInDrop ) if ( m_bInDrop )
return; return;

2
connectivity/source/drivers/jdbc/tools.cxx
View File

@@ -35,7 +35,7 @@ using namespace ::com::sun::star::sdbc;
using namespace ::com::sun::star::container; using namespace ::com::sun::star::container;
using namespace ::com::sun::star::lang; using namespace ::com::sun::star::lang;
void java_util_Properties::setProperty(const OUString key, const OUString& value) void java_util_Properties::setProperty(const OUString& key, const OUString& value)
{ {
SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!"); SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!");
jobject out(0); jobject out(0);

2
connectivity/source/drivers/mork/MNSProfileDiscover.cxx
View File

@@ -27,7 +27,7 @@ namespace connectivity
{ {
namespace mork namespace mork
{ {
ProfileStruct::ProfileStruct(MozillaProductType aProduct,OUString aProfileName, ProfileStruct::ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
const OUString& aProfilePath const OUString& aProfilePath
) )
{ {

4
connectivity/source/drivers/mork/MNSProfileDiscover.hxx
View File

@@ -49,7 +49,7 @@ namespace connectivity
class ProfileStruct class ProfileStruct
{ {
public: public:
ProfileStruct(MozillaProductType aProduct,OUString aProfileName, ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
const OUString &aProfilePath const OUString &aProfilePath
); );
MozillaProductType getProductType() { return product;} MozillaProductType getProductType() { return product;}
@@ -64,7 +64,7 @@ namespace connectivity
class ProductStruct class ProductStruct
{ {
public: public:
void setCurrentProfile(OUString aProfileName){mCurrentProfileName = aProfileName;} void setCurrentProfile(const OUString& aProfileName){mCurrentProfileName = aProfileName;}
OUString mCurrentProfileName; OUString mCurrentProfileName;

6
connectivity/source/drivers/mork/MQueryHelper.hxx
View File

@@ -81,9 +81,9 @@ namespace connectivity
public: public:
MQueryExpressionString( OUString& lhs, MQueryExpressionString( const OUString& lhs,
MQueryOp::cond_type cond, MQueryOp::cond_type cond,
OUString rhs ) const OUString& rhs )
: MQueryExpressionBase( MQueryExpressionBase::StringExpr ) : MQueryExpressionBase( MQueryExpressionBase::StringExpr )
, m_aName( lhs ) , m_aName( lhs )
, m_aBooleanCondition( cond ) , m_aBooleanCondition( cond )
@@ -91,7 +91,7 @@ namespace connectivity
{ {
} }
MQueryExpressionString( OUString& lhs, MQueryExpressionString( const OUString& lhs,
MQueryOp::cond_type cond ) MQueryOp::cond_type cond )
: MQueryExpressionBase( MQueryExpressionBase::StringExpr ) : MQueryExpressionBase( MQueryExpressionBase::StringExpr )
, m_aName( lhs ) , m_aName( lhs )

2
connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx
View File

@@ -85,7 +85,7 @@ namespace connectivity
{ {
namespace mozab namespace mozab
{ {
ProfileStruct::ProfileStruct(MozillaProductType aProduct,OUString aProfileName, ProfileStruct::ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
#ifdef MINIMAL_PROFILEDISCOVER #ifdef MINIMAL_PROFILEDISCOVER
const OUString& aProfilePath const OUString& aProfilePath
#else #else

4
connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx
View File

@@ -51,7 +51,7 @@ namespace connectivity
class ProfileStruct class ProfileStruct
{ {
public: public:
ProfileStruct(MozillaProductType aProduct,OUString aProfileName, ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
#ifdef MINIMAL_PROFILEDISCOVER #ifdef MINIMAL_PROFILEDISCOVER
const OUString &aProfilePath const OUString &aProfilePath
#else #else
@@ -77,7 +77,7 @@ namespace connectivity
class ProductStruct class ProductStruct
{ {
public: public:
void setCurrentProfile(OUString aProfileName){mCurrentProfileName = aProfileName;} void setCurrentProfile(const OUString& aProfileName){mCurrentProfileName = aProfileName;}
OUString mCurrentProfileName; OUString mCurrentProfileName;

2
connectivity/source/drivers/mysql/YTables.cxx
View File

@@ -121,7 +121,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString& _rForName, const Refere
} }
// XDrop // XDrop
void OTables::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OTables::dropObject(sal_Int32 _nPos,const OUString& _sElementName)
{ {
Reference< XInterface > xObject( getObject( _nPos ) ); Reference< XInterface > xObject( getObject( _nPos ) );
sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject ); sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject );

2
connectivity/source/drivers/mysql/YUsers.cxx
View File

@@ -91,7 +91,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen
} }
// XDrop // XDrop
void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{ {
OUString aSql( "DROP USER " ); OUString aSql( "DROP USER " );
OUString aQuote = m_xConnection->getMetaData()->getIdentifierQuoteString( ); OUString aQuote = m_xConnection->getMetaData()->getIdentifierQuoteString( );

2
connectivity/source/drivers/mysql/YViews.cxx
View File

@@ -93,7 +93,7 @@ sdbcx::ObjectType OViews::appendObject( const OUString& _rForName, const Referen
} }
// XDrop // XDrop
void OViews::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) void OViews::dropObject(sal_Int32 _nPos,const OUString& /*_sElementName*/)
{ {
if ( m_bInDrop ) if ( m_bInDrop )
return; return;

2
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
View File

@@ -910,7 +910,7 @@ sal_Int32 DatabaseMetaData::getMaxCharLiteralLength( ) throw (SQLException, Run
} }
// Copied / adapted / simplified from JDBC driver // Copied / adapted / simplified from JDBC driver
sal_Int32 DatabaseMetaData::getIntSetting(OUString settingName) sal_Int32 DatabaseMetaData::getIntSetting(const OUString& settingName)
throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException)
{ {
MutexGuard guard( m_refMutex->mutex ); MutexGuard guard( m_refMutex->mutex );

2
connectivity/source/drivers/postgresql/pq_databasemetadata.hxx
View File

@@ -57,7 +57,7 @@ class DatabaseMetaData :
::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XPreparedStatement > m_getColumnPrivs_stmt; ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XPreparedStatement > m_getColumnPrivs_stmt;
void checkClosed() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); void checkClosed() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
sal_Int32 getIntSetting(OUString settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); sal_Int32 getIntSetting(const OUString& settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
sal_Int32 getMaxIndexKeys() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); sal_Int32 getMaxIndexKeys() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
sal_Int32 getMaxNameLength() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); sal_Int32 getMaxNameLength() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSet > getImportedExportedKeys( ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSet > getImportedExportedKeys(

4
connectivity/source/drivers/postgresql/pq_tools.cxx
View File

@@ -92,12 +92,12 @@ OUString concatQualified( const OUString & a, const OUString &b)
return buf.makeStringAndClear(); return buf.makeStringAndClear();
} }
static inline OString iOUStringToOString( const OUString str, ConnectionSettings *settings) { static inline OString iOUStringToOString( const OUString& str, ConnectionSettings *settings) {
OSL_ENSURE(settings, "pgsql-sdbc: OUStringToOString got NULL settings"); OSL_ENSURE(settings, "pgsql-sdbc: OUStringToOString got NULL settings");
return OUStringToOString( str, settings->encoding ); return OUStringToOString( str, settings->encoding );
} }
OString OUStringToOString( const OUString str, ConnectionSettings *settings) { OString OUStringToOString( const OUString& str, ConnectionSettings *settings) {
return iOUStringToOString( str, settings ); return iOUStringToOString( str, settings );
} }

2
connectivity/source/drivers/postgresql/pq_tools.hxx
View File

@@ -53,7 +53,7 @@ bool isWhitespace( sal_Unicode c );
OUString concatQualified( const OUString & a, const OUString &b); OUString concatQualified( const OUString & a, const OUString &b);
OString OUStringToOString( OUString str, ConnectionSettings *settings); OString OUStringToOString( const OUString& str, ConnectionSettings *settings);
void bufferQuoteConstant( OUStringBuffer & buf, const OUString & str, ConnectionSettings *settings ); void bufferQuoteConstant( OUStringBuffer & buf, const OUString & str, ConnectionSettings *settings );
void bufferQuoteAnyConstant( OUStringBuffer & buf, const com::sun::star::uno::Any &val, ConnectionSettings *settings ); void bufferQuoteAnyConstant( OUStringBuffer & buf, const com::sun::star::uno::Any &val, ConnectionSettings *settings );

2
connectivity/source/inc/ado/AColumns.hxx
View File

@@ -40,7 +40,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OColumns( ::cppu::OWeakObject& _rParent, OColumns( ::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/ado/AGroups.hxx
View File

@@ -38,7 +38,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OGroups(OCatalog* _pParent, OGroups(OCatalog* _pParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/ado/AIndexes.hxx
View File

@@ -37,7 +37,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OIndexes(::cppu::OWeakObject& _rParent, OIndexes(::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/ado/AKeys.hxx
View File

@@ -38,7 +38,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OKeys(::cppu::OWeakObject& _rParent, OKeys(::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/ado/ATables.hxx
View File

@@ -38,7 +38,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OTables(OCatalog* _pParent, ::osl::Mutex& _rMutex, OTables(OCatalog* _pParent, ::osl::Mutex& _rMutex,
const TStringVector &_rVector, const TStringVector &_rVector,

2
connectivity/source/inc/ado/AUsers.hxx
View File

@@ -38,7 +38,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OUsers( OCatalog* _pParent, OUsers( OCatalog* _pParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/ado/AViews.hxx
View File

@@ -40,7 +40,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OViews(OCatalog* _pParent, ::osl::Mutex& _rMutex, OViews(OCatalog* _pParent, ::osl::Mutex& _rMutex,
const TStringVector &_rVector, const TStringVector &_rVector,

2
connectivity/source/inc/dbase/DColumns.hxx
View File

@@ -33,7 +33,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
ODbaseColumns(file::OFileTable* _pTable, ODbaseColumns(file::OFileTable* _pTable,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/dbase/DIndexes.hxx
View File

@@ -39,7 +39,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
ODbaseIndexes(ODbaseTable* _pTable, ::osl::Mutex& _rMutex, ODbaseIndexes(ODbaseTable* _pTable, ::osl::Mutex& _rMutex,
const TStringVector &_rVector) : ODbaseIndexes_BASE(*_pTable,_pTable->getConnection()->getMetaData()->supportsMixedCaseQuotedIdentifiers(),_rMutex,_rVector) const TStringVector &_rVector) : ODbaseIndexes_BASE(*_pTable,_pTable->getConnection()->getMetaData()->supportsMixedCaseQuotedIdentifiers(),_rMutex,_rVector)

2
connectivity/source/inc/dbase/DTables.hxx
View File

@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
ODbaseTables(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData >& _rMetaData,::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, ODbaseTables(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData >& _rMetaData,::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex,
const TStringVector &_rVector) : ODbaseTables_BASE(_rMetaData,_rParent,_rMutex,_rVector) const TStringVector &_rVector) : ODbaseTables_BASE(_rMetaData,_rParent,_rMutex,_rVector)

2
connectivity/source/inc/file/quotedstring.hxx
View File

@@ -39,7 +39,7 @@ namespace connectivity
sal_Int32 GetTokenCount( sal_Unicode cTok , sal_Unicode cStrDel ) const; sal_Int32 GetTokenCount( sal_Unicode cTok , sal_Unicode cStrDel ) const;
OUString GetTokenSpecial(sal_Int32& nStartPos, sal_Unicode cTok = ';', sal_Unicode cStrDel = '\0') const; OUString GetTokenSpecial(sal_Int32& nStartPos, sal_Unicode cTok = ';', sal_Unicode cStrDel = '\0') const;
inline OUString& GetString() { return m_sString; } inline OUString& GetString() { return m_sString; }
inline void SetString(OUString aStr) { m_sString = aStr;} inline void SetString(const OUString& aStr) { m_sString = aStr;}
inline sal_Int32 Len() const { return m_sString.getLength(); } inline sal_Int32 Len() const { return m_sString.getLength(); }
inline operator OUString&() { return m_sString; } inline operator OUString&() { return m_sString; }
}; };

2
connectivity/source/inc/hsqldb/HTables.hxx
View File

@@ -34,7 +34,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject); virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject);

2
connectivity/source/inc/hsqldb/HTools.hxx
View File

@@ -42,7 +42,7 @@ namespace connectivity { namespace hsqldb
*/ */
static void appendTableFilterCrit( static void appendTableFilterCrit(
OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog, OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog,
const OUString _rSchema, const OUString _rName, const OUString& _rSchema, const OUString& _rName,
bool _bShortForm bool _bShortForm
); );
}; };

2
connectivity/source/inc/hsqldb/HUsers.hxx
View File

@@ -39,7 +39,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
OUsers( ::cppu::OWeakObject& _rParent, OUsers( ::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/hsqldb/HViews.hxx
View File

@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
public: public:

2
connectivity/source/inc/java/util/Property.hxx
View File

@@ -34,7 +34,7 @@ namespace connectivity
// A ctor that is needed for returning the object // A ctor that is needed for returning the object
java_util_Properties( JNIEnv * pEnv, jobject myObj ) : java_lang_Object( pEnv, myObj ){} java_util_Properties( JNIEnv * pEnv, jobject myObj ) : java_lang_Object( pEnv, myObj ){}
java_util_Properties( ); java_util_Properties( );
void setProperty(const OUString key, const OUString& value); void setProperty(const OUString& key, const OUString& value);
}; };
} }

2
connectivity/source/inc/mysql/YTables.hxx
View File

@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject); virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject);

2
connectivity/source/inc/mysql/YUsers.hxx
View File

@@ -39,7 +39,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OUsers( ::cppu::OWeakObject& _rParent, OUsers( ::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
connectivity/source/inc/mysql/YViews.hxx
View File

@@ -35,7 +35,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
public: public:

2
connectivity/source/parse/sqliterator.cxx
View File

@@ -119,7 +119,7 @@ namespace connectivity
OUString m_sForbiddenQueryName; OUString m_sForbiddenQueryName;
public: public:
ForbidQueryName( OSQLParseTreeIteratorImpl& _rIteratorImpl, const OUString _rForbiddenQueryName ) ForbidQueryName( OSQLParseTreeIteratorImpl& _rIteratorImpl, const OUString& _rForbiddenQueryName )
:m_rpAllForbiddenNames( _rIteratorImpl.m_pForbiddenQueryNames ) :m_rpAllForbiddenNames( _rIteratorImpl.m_pForbiddenQueryNames )
,m_sForbiddenQueryName( _rForbiddenQueryName ) ,m_sForbiddenQueryName( _rForbiddenQueryName )
{ {

6
connectivity/source/sdbcx/VCollection.cxx
View File

@@ -118,7 +118,7 @@ namespace
m_aElements.push_back(m_aNameMap.insert(m_aNameMap.begin(), ObjectEntry(*i,ObjectType()))); m_aElements.push_back(m_aNameMap.insert(m_aNameMap.begin(), ObjectEntry(*i,ObjectType())));
} }
virtual bool rename(const OUString _sOldName,const OUString _sNewName) virtual bool rename(const OUString& _sOldName, const OUString& _sNewName)
{ {
bool bRet = false; bool bRet = false;
ObjectIter aIter = m_aNameMap.find(_sOldName); ObjectIter aIter = m_aNameMap.find(_sOldName);
@@ -518,7 +518,7 @@ void OCollection::insertElement(const OUString& _sElementName,const ObjectType&
m_pElements->insert(_sElementName,_xElement); m_pElements->insert(_sElementName,_xElement);
} }
void OCollection::renameObject(const OUString _sOldName,const OUString _sNewName) void OCollection::renameObject(const OUString& _sOldName, const OUString& _sNewName)
{ {
OSL_ENSURE(m_pElements->exists(_sOldName),"Element doesn't exist"); OSL_ENSURE(m_pElements->exists(_sOldName),"Element doesn't exist");
OSL_ENSURE(!m_pElements->exists(_sNewName),"Element already exists"); OSL_ENSURE(!m_pElements->exists(_sNewName),"Element already exists");
@@ -583,7 +583,7 @@ ObjectType OCollection::appendObject( const OUString& /*_rForName*/, const Refer
return cloneDescriptor( descriptor ); return cloneDescriptor( descriptor );
} }
void OCollection::dropObject(sal_Int32 /*_nPos*/,const OUString /*_sElementName*/) void OCollection::dropObject(sal_Int32 /*_nPos*/, const OUString& /*_sElementName*/)
{ {
} }

2
dbaccess/source/core/api/CIndexes.cxx
View File

@@ -70,7 +70,7 @@ ObjectType OIndexes::appendObject( const OUString& _rForName, const Reference< X
} }
// XDrop // XDrop
void OIndexes::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OIndexes::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{ {
if ( m_xIndexes.is() ) if ( m_xIndexes.is() )
{ {

2
dbaccess/source/core/api/CIndexes.hxx
View File

@@ -31,7 +31,7 @@ namespace dbaccess
virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName); virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
OIndexes(connectivity::OTableHelper* _pTable, OIndexes(connectivity::OTableHelper* _pTable,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
dbaccess/source/core/api/column.cxx
View File

@@ -390,7 +390,7 @@ sdbcx::ObjectType OColumns::appendObject( const OUString& _rForName, const Refer
} }
// XDrop // XDrop
void OColumns::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OColumns::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{ {
Reference< XDrop > xDrop( m_xDrvColumns, UNO_QUERY ); Reference< XDrop > xDrop( m_xDrvColumns, UNO_QUERY );
if ( xDrop.is() ) if ( xDrop.is() )

2
dbaccess/source/core/api/tablecontainer.cxx
View File

@@ -348,7 +348,7 @@ ObjectType OTableContainer::appendObject( const OUString& _rForName, const Refer
} }
// XDrop // XDrop
void OTableContainer::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OTableContainer::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{ {
SAL_INFO("dbaccess", "dbaccess Ocke.Janssen@sun.com OTableContainer::dropObject" ); SAL_INFO("dbaccess", "dbaccess Ocke.Janssen@sun.com OTableContainer::dropObject" );
m_bInDrop = sal_True; m_bInDrop = sal_True;

2
dbaccess/source/core/api/viewcontainer.cxx
View File

@@ -163,7 +163,7 @@ ObjectType OViewContainer::appendObject( const OUString& _rForName, const Refere
} }
// XDrop // XDrop
void OViewContainer::dropObject(sal_Int32 _nPos,const OUString _sElementName) void OViewContainer::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{ {
if ( !m_bInElementRemoved ) if ( !m_bInElementRemoved )
{ {

2
dbaccess/source/core/inc/column.hxx
View File

@@ -165,7 +165,7 @@ namespace dbaccess
virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName); virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
connectivity::sdbcx::ObjectType createBaseObject(const OUString& _rName) connectivity::sdbcx::ObjectType createBaseObject(const OUString& _rName)

2
dbaccess/source/core/inc/tablecontainer.hxx
View File

@@ -59,7 +59,7 @@ namespace dbaccess
virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName); virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
virtual void SAL_CALL disposing(); virtual void SAL_CALL disposing();

2
dbaccess/source/core/inc/viewcontainer.hxx
View File

@@ -90,7 +90,7 @@ namespace dbaccess
virtual ::connectivity::sdbcx::ObjectType createObject(const OUString& _rName); virtual ::connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
using OFilteredContainer::disposing; using OFilteredContainer::disposing;

2
include/comphelper/ofopxmlhelper.hxx
View File

@@ -72,7 +72,7 @@ public:
SAL_CALL SAL_CALL
ReadRelationsInfoSequence( ReadRelationsInfoSequence(
const ::com::sun::star::uno::Reference< ::com::sun::star::io::XInputStream >& xInStream, const ::com::sun::star::uno::Reference< ::com::sun::star::io::XInputStream >& xInStream,
const OUString aStreamName, const OUString & aStreamName,
const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext ) const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext )
throw( ::com::sun::star::uno::Exception ); throw( ::com::sun::star::uno::Exception );

2
include/connectivity/TColumnsHelper.hxx
View File

@@ -41,7 +41,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public: public:
OColumnsHelper( ::cppu::OWeakObject& _rParent OColumnsHelper( ::cppu::OWeakObject& _rParent
,sal_Bool _bCase ,sal_Bool _bCase

2
include/connectivity/TIndexes.hxx
View File

@@ -35,7 +35,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public: public:
OIndexesHelper(OTableHelper* _pTable, OIndexesHelper(OTableHelper* _pTable,
::osl::Mutex& _rMutex, ::osl::Mutex& _rMutex,

2
include/connectivity/TKeys.hxx
View File

@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
virtual OUString getDropForeignKey() const; virtual OUString getDropForeignKey() const;

8
include/connectivity/sdbcx/VCollection.hxx
View File

@@ -71,8 +71,8 @@ namespace connectivity
virtual void swap() = 0; virtual void swap() = 0;
virtual void clear() = 0; virtual void clear() = 0;
virtual void reFill(const TStringVector &_rVector) = 0; virtual void reFill(const TStringVector &_rVector) = 0;
virtual void insert(const OUString& _sName,const ObjectType& _xObject) = 0; virtual void insert(const OUString& _sName, const ObjectType& _xObject) = 0;
virtual bool rename(const OUString _sOldName,const OUString _sNewName) = 0; virtual bool rename(const OUString& _sOldName, const OUString& _sNewName) = 0;
virtual sal_Int32 size() = 0; virtual sal_Int32 size() = 0;
virtual ::com::sun::star::uno::Sequence< OUString > getElementNames() = 0; virtual ::com::sun::star::uno::Sequence< OUString > getElementNames() = 0;
virtual OUString getName(sal_Int32 _nIndex) = 0; virtual OUString getName(sal_Int32 _nIndex) = 0;
@@ -126,7 +126,7 @@ namespace connectivity
virtual ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
// called when XDrop was called // called when XDrop was called
virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
/** returns the name for the object. The default implementation ask for the property NAME. If this doesn't satisfy, it has to be overloaded. /** returns the name for the object. The default implementation ask for the property NAME. If this doesn't satisfy, it has to be overloaded.
@param _xObject The object where the name should be extracted. @param _xObject The object where the name should be extracted.
@@ -182,7 +182,7 @@ namespace connectivity
void reFill(const TStringVector &_rVector); void reFill(const TStringVector &_rVector);
inline sal_Bool isCaseSensitive() const { return m_pElements->isCaseSensitive(); } inline sal_Bool isCaseSensitive() const { return m_pElements->isCaseSensitive(); }
void renameObject(const OUString _sOldName,const OUString _sNewName); void renameObject(const OUString& _sOldName, const OUString& _sNewName);
// only the name is identical to ::cppu::OComponentHelper // only the name is identical to ::cppu::OComponentHelper
virtual void SAL_CALL disposing(void); virtual void SAL_CALL disposing(void);