mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer switch-case to cascaded ifs

Browse Source 
Change-Id: I0848676dcdf6f96fe90f34be018b1c3d9d3d370a
This commit is contained in:
Matteo Casalin
2015-12-15 21:16:43 +01:00
parent 801801bbca
commit 3806388288
1 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
vcl/source/edit/vclmedit.cxx
View File

@@ -512,17 +512,19 @@ OUString ImpVclMEdit::GetTextLines( LineEnd aSeparator ) const
void ImpVclMEdit::Notify( SfxBroadcaster&, const SfxHint& rHint ) void ImpVclMEdit::Notify( SfxBroadcaster&, const SfxHint& rHint )
{ {
const TextHint* pTextHint = dynamic_cast<const TextHint*>(&rHint); const TextHint* pTextHint = dynamic_cast<const TextHint*>(&rHint);
if ( pTextHint ) if ( !pTextHint )
{ return;
if( pTextHint->GetId() == TEXT_HINT_VIEWSCROLLED )
switch (pTextHint->GetId())
{ {
case TEXT_HINT_VIEWSCROLLED:
if ( mpHScrollBar ) if ( mpHScrollBar )
ImpSetHScrollBarThumbPos(); ImpSetHScrollBarThumbPos();
if ( mpVScrollBar ) if ( mpVScrollBar )
mpVScrollBar->SetThumbPos( mpTextWindow->GetTextView()->GetStartDocPos().Y() ); mpVScrollBar->SetThumbPos( mpTextWindow->GetTextView()->GetStartDocPos().Y() );
} break;
else if( pTextHint->GetId() == TEXT_HINT_TEXTHEIGHTCHANGED )
{ case TEXT_HINT_TEXTHEIGHTCHANGED:
if ( mpTextWindow->GetTextView()->GetStartDocPos().Y() ) if ( mpTextWindow->GetTextView()->GetStartDocPos().Y() )
{ {
long nOutHeight = mpTextWindow->GetOutputSizePixel().Height(); long nOutHeight = mpTextWindow->GetOutputSizePixel().Height();
@@ -530,11 +532,10 @@ void ImpVclMEdit::Notify( SfxBroadcaster&, const SfxHint& rHint )
if ( nTextHeight < nOutHeight ) if ( nTextHeight < nOutHeight )
mpTextWindow->GetTextView()->Scroll( 0, mpTextWindow->GetTextView()->GetStartDocPos().Y() ); mpTextWindow->GetTextView()->Scroll( 0, mpTextWindow->GetTextView()->GetStartDocPos().Y() );
} }
ImpSetScrollBarRanges(); ImpSetScrollBarRanges();
} break;
else if( pTextHint->GetId() == TEXT_HINT_TEXTFORMATTED )
{ case TEXT_HINT_TEXTFORMATTED:
if ( mpHScrollBar ) if ( mpHScrollBar )
{ {
const long nWidth = mpTextWindow->GetTextEngine()->CalcTextWidth(); const long nWidth = mpTextWindow->GetTextEngine()->CalcTextWidth();
@@ -545,20 +546,20 @@ void ImpVclMEdit::Notify( SfxBroadcaster&, const SfxHint& rHint )
ImpSetHScrollBarThumbPos(); ImpSetHScrollBarThumbPos();
} }
} }
} break;
else if( pTextHint->GetId() == TEXT_HINT_MODIFIED )
{ case TEXT_HINT_MODIFIED:
ImpUpdateSrollBarVis(pVclMultiLineEdit->GetStyle()); ImpUpdateSrollBarVis(pVclMultiLineEdit->GetStyle());
pVclMultiLineEdit->Modify(); pVclMultiLineEdit->Modify();
} break;
else if( pTextHint->GetId() == TEXT_HINT_VIEWSELECTIONCHANGED )
{ case TEXT_HINT_VIEWSELECTIONCHANGED:
pVclMultiLineEdit->SelectionChanged(); pVclMultiLineEdit->SelectionChanged();
} break;
else if( pTextHint->GetId() == TEXT_HINT_VIEWCARETCHANGED )
{ case TEXT_HINT_VIEWCARETCHANGED:
pVclMultiLineEdit->CaretChanged(); pVclMultiLineEdit->CaretChanged();
} break;
} }
} }