mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better loplugin:unnecessaryparen check for vexing parse

Browse Source 
Change-Id: Id7b09a8556da25b81c056d5811ba721e781682d6
Reviewed-on: https://gerrit.libreoffice.org/68025
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2019-02-19 17:38:24 +01:00
parent 87d46dc80a
commit 38642dafb6
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
compilerplugins/clang/unnecessaryparen.cxx
View File

@@ -447,8 +447,9 @@ bool UnnecessaryParen::VisitVarDecl(const VarDecl* varDecl)
return true; return true;
// these two are for "parentheses were disambiguated as a function declaration [-Werror,-Wvexing-parse]" // these two are for "parentheses were disambiguated as a function declaration [-Werror,-Wvexing-parse]"
if (isa<CXXBindTemporaryExpr>(sub) auto const sub2 = sub->IgnoreImplicit();
|| isa<CXXFunctionalCastExpr>(sub)) if (isa<CXXTemporaryObjectExpr>(sub2)
|| isa<CXXFunctionalCastExpr>(sub2))
return true; return true;
report( report(

4
extensions/source/propctrlr/propertycomposer.cxx
View File

@@ -160,7 +160,7 @@ namespace pcr
// loop through the secondary sets // loop through the secondary sets
PropertyState eSecondaryState = PropertyState_DIRECT_VALUE; PropertyState eSecondaryState = PropertyState_DIRECT_VALUE;
for ( HandlerArray::const_iterator loop = ( m_aSlaveHandlers.begin() + 1 ); for ( HandlerArray::const_iterator loop = m_aSlaveHandlers.begin() + 1;
loop != m_aSlaveHandlers.end(); loop != m_aSlaveHandlers.end();
++loop ++loop
) )
@@ -210,7 +210,7 @@ namespace pcr
putIntoBag( (*m_aSlaveHandlers.begin())->getSupportedProperties(), m_aSupportedProperties ); putIntoBag( (*m_aSlaveHandlers.begin())->getSupportedProperties(), m_aSupportedProperties );
// now intersect with the properties of *all* other handlers // now intersect with the properties of *all* other handlers
for ( HandlerArray::const_iterator loop = ( m_aSlaveHandlers.begin() + 1 ); for ( HandlerArray::const_iterator loop = m_aSlaveHandlers.begin() + 1;
loop != m_aSlaveHandlers.end(); loop != m_aSlaveHandlers.end();
++loop ++loop
) )