mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adapt loplugin:overrideparam to recent Clang trunk change

Browse Source 
Change-Id: Ia372e39bc7e51f290a6d631bf0b81fd75f4fdc1d
This commit is contained in:
Stephan Bergmann
2017-01-12 15:19:22 +01:00
parent ff30d20c1a
commit 38d1c303e1
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
compilerplugins/clang/overrideparam.cxx
View File

@@ -179,11 +179,20 @@ bool OverrideParam::hasSameDefaultParams(const ParmVarDecl * parmVarDecl, const
{ {
return true; return true;
} }
#if CLANG_VERSION >= 30900 return true;
return false; // for one, Clang 3.8 doesn't have EvaluateAsFloat; for another, since
#else // <http://llvm.org/viewvc/llvm-project?view=revision&revision=291318>
return true; // clang3-8 doesn't have EvaluateAsFloat, so we can't be as precise // "PR23135: Don't instantiate constexpr functions referenced in
#endif // unevaluated operands where possible", default args are not
// necessarily evaluated, so the above calls to EvaluateAsInt etc. may
// fail (as they do e.g. for SfxViewShell::SetPrinter and derived
// classes' 'SfxPrinterChangeFlags nDiffFlags = SFX_PRINTER_ALL' arg,
// include/sfx2/viewsh.hxx; what appears would help is to call
// 'compiler.getSema().MarkDeclarationsReferencedInExpr()' on
// defaultArgExpr and superDefaultArgExpr before any of the calls to
// EvaluateAsInt etc., cf. the implementation of
// Sema::CheckCXXDefaultArgExpr in Clang's lib/Sema/SemaExpr.cpp, but
// that would probably have unwanted side-effects)
} }
bool OverrideParam::evaluate(const Expr* expr, APSInt& x) bool OverrideParam::evaluate(const Expr* expr, APSInt& x)