mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cppcheck: noExplicitConstructor

Browse Source 
Change-Id: Ib80e7f6d055bead246db3028b4eab6edfabe3d2c
This commit is contained in:
Caolán McNamara
2015-07-22 20:12:48 +01:00
parent a6c47236a4
commit 442ab9ceee
14 changed files with 23 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx
View File

@@ -29,7 +29,7 @@ namespace dbaui
class OQueryAddTabConnUndoAction : public OQueryTabConnUndoAction class OQueryAddTabConnUndoAction : public OQueryTabConnUndoAction
{ {
public: public:
OQueryAddTabConnUndoAction(OQueryTableView* pOwner); explicit OQueryAddTabConnUndoAction(OQueryTableView* pOwner);
virtual void Undo() SAL_OVERRIDE; virtual void Undo() SAL_OVERRIDE;
virtual void Redo() SAL_OVERRIDE; virtual void Redo() SAL_OVERRIDE;
@@ -40,7 +40,7 @@ namespace dbaui
class OQueryDelTabConnUndoAction : public OQueryTabConnUndoAction class OQueryDelTabConnUndoAction : public OQueryTabConnUndoAction
{ {
public: public:
OQueryDelTabConnUndoAction(OQueryTableView* pOwner); explicit OQueryDelTabConnUndoAction(OQueryTableView* pOwner);
virtual void Undo() SAL_OVERRIDE; virtual void Undo() SAL_OVERRIDE;
virtual void Redo() SAL_OVERRIDE; virtual void Redo() SAL_OVERRIDE;

14
dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
View File

@@ -57,12 +57,12 @@ namespace dbaui
sal_Int32 m_nCellIndex; sal_Int32 m_nCellIndex;
public: public:
OTabFieldCellModifiedUndoAct(OSelectionBrowseBox* pSelBrwBox) explicit OTabFieldCellModifiedUndoAct(OSelectionBrowseBox* pSelBrwBox)
: OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_MODIFY_CELL) : OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_MODIFY_CELL)
,m_nCellIndex(BROWSER_INVALIDID){ } ,m_nCellIndex(BROWSER_INVALIDID){ }
inline void SetCellContents(const OUString& str) { m_strNextCellContents = str; } void SetCellContents(const OUString& str) { m_strNextCellContents = str; }
inline void SetCellIndex(sal_Int32 nIndex) { m_nCellIndex = nIndex; } void SetCellIndex(sal_Int32 nIndex) { m_nCellIndex = nIndex; }
virtual void Undo() SAL_OVERRIDE; virtual void Undo() SAL_OVERRIDE;
virtual void Redo() SAL_OVERRIDE { Undo(); } virtual void Redo() SAL_OVERRIDE { Undo(); }
@@ -76,7 +76,7 @@ namespace dbaui
long m_nNextWidth; long m_nNextWidth;
public: public:
OTabFieldSizedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_SIZE_COLUMN), m_nNextWidth(0) { } explicit OTabFieldSizedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_SIZE_COLUMN), m_nNextWidth(0) { }
inline void SetOriginalWidth(long nWidth) { m_nNextWidth = nWidth; } inline void SetOriginalWidth(long nWidth) { m_nNextWidth = nWidth; }
@@ -106,7 +106,7 @@ namespace dbaui
virtual void Redo() SAL_OVERRIDE { pOwner->EnterUndoMode();pOwner->RemoveColumn(pDescr->GetColumnId());pOwner->LeaveUndoMode(); } virtual void Redo() SAL_OVERRIDE { pOwner->EnterUndoMode();pOwner->RemoveColumn(pDescr->GetColumnId());pOwner->LeaveUndoMode(); }
public: public:
OTabFieldDelUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDDELETE) { } explicit OTabFieldDelUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDDELETE) { }
}; };
// OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes // OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes
@@ -119,7 +119,7 @@ namespace dbaui
virtual void Redo() SAL_OVERRIDE { pOwner->EnterUndoMode();pOwner->InsertColumn(pDescr, m_nColumnPostion);pOwner->LeaveUndoMode();} virtual void Redo() SAL_OVERRIDE { pOwner->EnterUndoMode();pOwner->InsertColumn(pDescr, m_nColumnPostion);pOwner->LeaveUndoMode();}
public: public:
OTabFieldCreateUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDCREATE) { } explicit OTabFieldCreateUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDCREATE) { }
}; };
// OTabFieldMovedUndoAct - Undo class when a field was moved inside the selection // OTabFieldMovedUndoAct - Undo class when a field was moved inside the selection
@@ -134,7 +134,7 @@ namespace dbaui
} }
public: public:
OTabFieldMovedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDMOVED) { } explicit OTabFieldMovedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDMOVED) { }
}; };
} }
#endif // INCLUDED_DBACCESS_SOURCE_UI_QUERYDESIGN_QUERYDESIGNFIELDUNDOACT_HXX #endif // INCLUDED_DBACCESS_SOURCE_UI_QUERYDESIGN_QUERYDESIGNFIELDUNDOACT_HXX

4
dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx
View File

@@ -29,7 +29,7 @@ namespace dbaui
class OQueryTabWinShowUndoAct : public OQueryTabWinUndoAct class OQueryTabWinShowUndoAct : public OQueryTabWinUndoAct
{ {
public: public:
OQueryTabWinShowUndoAct(OQueryTableView* pOwner); explicit OQueryTabWinShowUndoAct(OQueryTableView* pOwner);
virtual ~OQueryTabWinShowUndoAct(); virtual ~OQueryTabWinShowUndoAct();
virtual void Undo() SAL_OVERRIDE; virtual void Undo() SAL_OVERRIDE;
@@ -41,7 +41,7 @@ namespace dbaui
class OQueryTabWinDelUndoAct : public OQueryTabWinUndoAct class OQueryTabWinDelUndoAct : public OQueryTabWinUndoAct
{ {
public: public:
OQueryTabWinDelUndoAct(OQueryTableView* pOwner); explicit OQueryTabWinDelUndoAct(OQueryTableView* pOwner);
virtual ~OQueryTabWinDelUndoAct(); virtual ~OQueryTabWinDelUndoAct();
virtual void Undo() SAL_OVERRIDE; virtual void Undo() SAL_OVERRIDE;

2
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
View File

@@ -250,7 +250,7 @@ namespace
protected: protected:
virtual void Select() SAL_OVERRIDE; virtual void Select() SAL_OVERRIDE;
public: public:
OSelectionBrwBoxHeader(OSelectionBrowseBox* pParent); explicit OSelectionBrwBoxHeader(OSelectionBrowseBox* pParent);
virtual ~OSelectionBrwBoxHeader() { disposeOnce(); } virtual ~OSelectionBrwBoxHeader() { disposeOnce(); }
virtual void dispose() SAL_OVERRIDE { m_pBrowseBox.clear(); ::svt::EditBrowserHeader::dispose(); } virtual void dispose() SAL_OVERRIDE { m_pBrowseBox.clear(); ::svt::EditBrowserHeader::dispose(); }
}; };

3
dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx
View File

@@ -78,7 +78,8 @@ namespace dbaui
bool m_bInUndoMode; bool m_bInUndoMode;
DECL_LINK_TYPED(OnInvalidateTimer, Timer*, void); DECL_LINK_TYPED(OnInvalidateTimer, Timer*, void);
public: OSelectionBrowseBox( vcl::Window* pParent ); public:
explicit OSelectionBrowseBox( vcl::Window* pParent );
virtual ~OSelectionBrowseBox(); virtual ~OSelectionBrowseBox();
virtual void dispose() SAL_OVERRIDE; virtual void dispose() SAL_OVERRIDE;

2
dbaccess/source/ui/querydesign/limitboxcontroller.hxx
View File

@@ -31,7 +31,7 @@ class LimitBoxController: public svt::ToolboxController,
public ::com::sun::star::lang::XServiceInfo public ::com::sun::star::lang::XServiceInfo
{ {
public: public:
LimitBoxController( explicit LimitBoxController(
const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& rxContext ); const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& rxContext );
virtual ~LimitBoxController(); virtual ~LimitBoxController();

2
dbaccess/source/ui/querydesign/querycontroller.cxx
View File

@@ -110,7 +110,7 @@ namespace dbaui
} }
public: public:
OViewController(const Reference< XComponentContext >& _rM) : OQueryController(_rM){} explicit OViewController(const Reference< XComponentContext >& _rM) : OQueryController(_rM){}
// need by registration // need by registration
static OUString getImplementationName_Static() throw( RuntimeException ) static OUString getImplementationName_Static() throw( RuntimeException )

2
dbaccess/source/ui/tabledesign/TEditControl.hxx
View File

@@ -121,7 +121,7 @@ namespace dbaui
DECL_LINK(ControlPreNotifyHdl, NotifyEvent*); DECL_LINK(ControlPreNotifyHdl, NotifyEvent*);
public: public:
OTableEditorCtrl(vcl::Window* pParentWin); explicit OTableEditorCtrl(vcl::Window* pParentWin);
virtual ~OTableEditorCtrl(); virtual ~OTableEditorCtrl();
virtual void dispose() SAL_OVERRIDE; virtual void dispose() SAL_OVERRIDE;
virtual bool CursorMoving(long nNewRow, sal_uInt16 nNewCol) SAL_OVERRIDE; virtual bool CursorMoving(long nNewRow, sal_uInt16 nNewCol) SAL_OVERRIDE;

2
dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx
View File

@@ -53,7 +53,7 @@ namespace dbaui
virtual void Paint( vcl::RenderContext& rRenderContext, const Rectangle& rRect ) SAL_OVERRIDE; virtual void Paint( vcl::RenderContext& rRenderContext, const Rectangle& rRect ) SAL_OVERRIDE;
public: public:
OTableFieldDescWin( vcl::Window* pParent); explicit OTableFieldDescWin( vcl::Window* pParent);
virtual ~OTableFieldDescWin(); virtual ~OTableFieldDescWin();
virtual void dispose() SAL_OVERRIDE; virtual void dispose() SAL_OVERRIDE;

2
dbaccess/source/ui/tabledesign/TableUndo.hxx
View File

@@ -98,7 +98,7 @@ namespace dbaui
virtual void Redo() SAL_OVERRIDE; virtual void Redo() SAL_OVERRIDE;
public: public:
TYPEINFO_OVERRIDE(); TYPEINFO_OVERRIDE();
OTableEditorDelUndoAct( OTableEditorCtrl* pOwner ); explicit OTableEditorDelUndoAct( OTableEditorCtrl* pOwner );
virtual ~OTableEditorDelUndoAct(); virtual ~OTableEditorDelUndoAct();
}; };

2
dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx
View File

@@ -39,7 +39,7 @@ namespace dbaui
{ {
protected: protected:
OAdvancedSettingsDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); explicit OAdvancedSettingsDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB);
public: public:
// XTypeProvider // XTypeProvider

2
dbaccess/source/ui/uno/ColumnControl.hxx
View File

@@ -33,7 +33,7 @@ namespace dbaui
private: private:
::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext> m_xContext; ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext> m_xContext;
public: public:
OColumnControl(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext>& rxContext); explicit OColumnControl(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext>& rxContext);
// UnoControl // UnoControl
virtual OUString GetComponentServiceName() SAL_OVERRIDE; virtual OUString GetComponentServiceName() SAL_OVERRIDE;

2
dbaccess/source/ui/uno/ColumnModel.hxx
View File

@@ -68,7 +68,7 @@ protected:
OColumnControlModel(const OColumnControlModel* _pSource OColumnControlModel(const OColumnControlModel* _pSource
,const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory); ,const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory);
public: public:
OColumnControlModel(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory); explicit OColumnControlModel(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory);
// UNO Anbindung // UNO Anbindung
DECLARE_XINTERFACE( ) DECLARE_XINTERFACE( )

2
dbaccess/source/ui/uno/DBTypeWizDlg.hxx
View File

@@ -31,7 +31,7 @@ class ODBTypeWizDialog
{ {
protected: protected:
ODBTypeWizDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); explicit ODBTypeWizDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB);
public: public:
// XTypeProvider // XTypeProvider