mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:constantparam in extensions

Browse Source 
Change-Id: Icdfde86b1291a9b831f6eac4d8c00faa326106b7
This commit is contained in:
Noel Grandin
2016-03-09 14:31:56 +02:00
parent 7da15debe3
commit 451dd39089
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/source/dbpilots/listcombowizard.cxx
View File

@@ -231,9 +231,9 @@ namespace dbp
} }
Sequence< OUString > OLCPage::getTableFields(bool _bNeedIt) Sequence< OUString > OLCPage::getTableFields()
{ {
Reference< XNameAccess > xTables = getTables(_bNeedIt); Reference< XNameAccess > xTables = getTables(true);
Sequence< OUString > aColumnNames; Sequence< OUString > aColumnNames;
if (xTables.is()) if (xTables.is())
{ {
@@ -242,7 +242,7 @@ namespace dbp
// the list table as XColumnsSupplier // the list table as XColumnsSupplier
Reference< XColumnsSupplier > xSuppCols; Reference< XColumnsSupplier > xSuppCols;
xTables->getByName(getSettings().sListContentTable) >>= xSuppCols; xTables->getByName(getSettings().sListContentTable) >>= xSuppCols;
DBG_ASSERT(!_bNeedIt || xSuppCols.is(), "OLCPage::getTableFields: no columns supplier!"); DBG_ASSERT(xSuppCols.is(), "OLCPage::getTableFields: no columns supplier!");
// the columns // the columns
Reference< XNameAccess > xColumns; Reference< XNameAccess > xColumns;
@@ -255,7 +255,7 @@ namespace dbp
} }
catch(const Exception&) catch(const Exception&)
{ {
DBG_ASSERT(!_bNeedIt, "OLinkFieldsPage::initializePage: caught an exception while retrieving the columns!"); DBG_ASSERT(false, "OLinkFieldsPage::initializePage: caught an exception while retrieving the columns!");
} }
} }
return aColumnNames; return aColumnNames;
@@ -384,7 +384,7 @@ namespace dbp
OLCPage::initializePage(); OLCPage::initializePage();
// fill the list of fields // fill the list of fields
fillListBox(*m_pSelectTableField, getTableFields(true)); fillListBox(*m_pSelectTableField, getTableFields());
m_pSelectTableField->SelectEntry(getSettings().sListContentField); m_pSelectTableField->SelectEntry(getSettings().sListContentField);
m_pDisplayedField->SetText(getSettings().sListContentField); m_pDisplayedField->SetText(getSettings().sListContentField);
@@ -462,7 +462,7 @@ namespace dbp
// fill the value list // fill the value list
fillListBox(*m_pValueListField, getContext().aFieldNames); fillListBox(*m_pValueListField, getContext().aFieldNames);
// fill the table field list // fill the table field list
fillListBox(*m_pTableField, getTableFields(true)); fillListBox(*m_pTableField, getTableFields());
// the initial selections // the initial selections
m_pValueListField->SetText(getSettings().sLinkedFormField); m_pValueListField->SetText(getSettings().sLinkedFormField);

2
extensions/source/dbpilots/listcombowizard.hxx
View File

@@ -90,7 +90,7 @@ namespace dbp
protected: protected:
css::uno::Reference< css::container::XNameAccess > getTables(bool _bNeedIt); css::uno::Reference< css::container::XNameAccess > getTables(bool _bNeedIt);
css::uno::Sequence< OUString > getTableFields(bool _bNeedIt); css::uno::Sequence< OUString > getTableFields();
}; };
class OContentTableSelection : public OLCPage class OContentTableSelection : public OLCPage