mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in LoggedStream::lcl_info

Browse Source 
which means the whole method is actually unused

Change-Id: I72d33ab6e260012b82002ceae7ff9e54e2ea6349
Reviewed-on: https://gerrit.libreoffice.org/80953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-17 12:30:38 +02:00
parent 0b3db87249
commit 45eeefb064
9 changed files with 2 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -439,6 +439,3 @@ writerfilter/inc/dmapper/resourcemodel.hxx:173
writerfilter/inc/ooxml/OOXMLDocument.hxx:216 writerfilter/inc/ooxml/OOXMLDocument.hxx:216
void writerfilter::ooxml::OOXMLDocument::setXNoteType(unsigned int,) void writerfilter::ooxml::OOXMLDocument::setXNoteType(unsigned int,)
0 0
writerfilter/source/dmapper/LoggedResources.hxx:93
void writerfilter::LoggedStream::lcl_info(const class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > &,)
0

4
writerfilter/source/dmapper/DomainMapper.cxx
View File

@@ -3454,10 +3454,6 @@ void DomainMapper::lcl_substream(Id rName, ::writerfilter::Reference<Stream>::Po
m_pImpl->substream(rName, ref); m_pImpl->substream(rName, ref);
} }
void DomainMapper::lcl_info(const std::string & /*info_*/)
{
}
void DomainMapper::lcl_startGlossaryEntry() void DomainMapper::lcl_startGlossaryEntry()
{ {
uno::Reference< text::XTextRange > xTextRange = GetCurrentTextRange(); uno::Reference< text::XTextRange > xTextRange = GetCurrentTextRange();

1
writerfilter/source/dmapper/DomainMapper.hxx
View File

@@ -151,7 +151,6 @@ private:
writerfilter::Reference<Table>::Pointer_t ref) override; writerfilter::Reference<Table>::Pointer_t ref) override;
virtual void lcl_substream(Id name, virtual void lcl_substream(Id name,
::writerfilter::Reference<Stream>::Pointer_t ref) override; ::writerfilter::Reference<Stream>::Pointer_t ref) override;
virtual void lcl_info(const std::string & info) override;
virtual void lcl_startGlossaryEntry() override; virtual void lcl_startGlossaryEntry() override;
virtual void lcl_endGlossaryEntry() override; virtual void lcl_endGlossaryEntry() override;

4
writerfilter/source/dmapper/FontTable.cxx
View File

@@ -205,10 +205,6 @@ void FontTable::lcl_substream(Id, ::writerfilter::Reference<Stream>::Pointer_t)
{ {
} }
void FontTable::lcl_info(const std::string& )
{
}
void FontTable::lcl_startShape(uno::Reference<drawing::XShape> const&) void FontTable::lcl_startShape(uno::Reference<drawing::XShape> const&)
{ {
} }

1
writerfilter/source/dmapper/FontTable.hxx
View File

@@ -76,7 +76,6 @@ class FontTable : public LoggedProperties, public LoggedTable
writerfilter::Reference<Table>::Pointer_t ref) override; writerfilter::Reference<Table>::Pointer_t ref) override;
virtual void lcl_substream(Id name, virtual void lcl_substream(Id name,
::writerfilter::Reference<Stream>::Pointer_t ref) override; ::writerfilter::Reference<Stream>::Pointer_t ref) override;
virtual void lcl_info(const std::string & info) override;
virtual void lcl_startShape(css::uno::Reference<css::drawing::XShape> const& xShape) override; virtual void lcl_startShape(css::uno::Reference<css::drawing::XShape> const& xShape) override;
virtual void lcl_endShape( ) override; virtual void lcl_endShape( ) override;

4
writerfilter/source/dmapper/GraphicImport.cxx
View File

@@ -1481,10 +1481,6 @@ void GraphicImport::lcl_substream(Id /*name*/, ::writerfilter::Reference<Stream>
{ {
} }
void GraphicImport::lcl_info(const std::string& /*info*/)
{
}
void GraphicImport::lcl_startShape(uno::Reference<drawing::XShape> const&) void GraphicImport::lcl_startShape(uno::Reference<drawing::XShape> const&)
{ {
} }

1
writerfilter/source/dmapper/GraphicImport.hxx
View File

@@ -119,7 +119,6 @@ public:
virtual void lcl_table(Id name, virtual void lcl_table(Id name,
writerfilter::Reference<Table>::Pointer_t ref) override; writerfilter::Reference<Table>::Pointer_t ref) override;
virtual void lcl_substream(Id name, writerfilter::Reference<Stream>::Pointer_t ref) override; virtual void lcl_substream(Id name, writerfilter::Reference<Stream>::Pointer_t ref) override;
virtual void lcl_info(const std::string & info) override;
virtual void lcl_startShape(css::uno::Reference<css::drawing::XShape> const& xShape) override; virtual void lcl_startShape(css::uno::Reference<css::drawing::XShape> const& xShape) override;
virtual void lcl_endShape() override; virtual void lcl_endShape() override;

4
writerfilter/source/dmapper/LoggedResources.cxx
View File

@@ -289,10 +289,10 @@ void LoggedStream::info(const std::string & _info)
#ifdef DBG_UTIL #ifdef DBG_UTIL
mHelper.startElement("info"); mHelper.startElement("info");
LoggedResourcesHelper::attribute("text", _info); LoggedResourcesHelper::attribute("text", _info);
#else
(void)_info;
#endif #endif
lcl_info(_info);
#ifdef DBG_UTIL #ifdef DBG_UTIL
LoggedResourcesHelper::endElement(); LoggedResourcesHelper::endElement();
#endif #endif

1
writerfilter/source/dmapper/LoggedResources.hxx
View File

@@ -90,7 +90,6 @@ protected:
virtual void lcl_props(writerfilter::Reference<Properties>::Pointer_t ref) = 0; virtual void lcl_props(writerfilter::Reference<Properties>::Pointer_t ref) = 0;
virtual void lcl_table(Id name, writerfilter::Reference<Table>::Pointer_t ref) = 0; virtual void lcl_table(Id name, writerfilter::Reference<Table>::Pointer_t ref) = 0;
virtual void lcl_substream(Id name, writerfilter::Reference<Stream>::Pointer_t ref) = 0; virtual void lcl_substream(Id name, writerfilter::Reference<Stream>::Pointer_t ref) = 0;
virtual void lcl_info(const std::string & info) = 0;
virtual void lcl_startGlossaryEntry() { } virtual void lcl_startGlossaryEntry() { }
virtual void lcl_endGlossaryEntry() { } virtual void lcl_endGlossaryEntry() { }