mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up odd function definitions

Browse Source 
...that were like that ever since c25ec0608a
"initial import", but which when called would run into the assert(false)/
"!!br0ken!!" code in rtl::str::newFromSubString (sal/rtl/strtmpl.hxx), as the
count argument to OUString::copy is -1.  So just return an empty OUString,
similar to what the getTimeDateFunctions and getNumericFunctions functions
always did.

(Stumbled across this when it got flagged by loplugin:stringviewvar with
clang-cl.)

Change-Id: Ief23c7e0c7712dd65e6213c9e7db3a10d276eaa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133226
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2022-04-20 21:44:13 +02:00
parent 2dce675435
commit 481e2bc6f7
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
connectivity/source/drivers/ado/ADatabaseMetaData.cxx
View File

@@ -896,8 +896,7 @@ OUString SAL_CALL ODatabaseMetaData::getSearchStringEscape( )
OUString SAL_CALL ODatabaseMetaData::getStringFunctions( ) OUString SAL_CALL ODatabaseMetaData::getStringFunctions( )
{ {
OUString aValue; return OUString();
return aValue.copy(0,aValue.lastIndexOf(','));
} }
OUString SAL_CALL ODatabaseMetaData::getTimeDateFunctions( ) OUString SAL_CALL ODatabaseMetaData::getTimeDateFunctions( )
@@ -907,8 +906,7 @@ OUString SAL_CALL ODatabaseMetaData::getTimeDateFunctions( )
OUString SAL_CALL ODatabaseMetaData::getSystemFunctions( ) OUString SAL_CALL ODatabaseMetaData::getSystemFunctions( )
{ {
OUString aValue; return OUString();
return aValue.copy(0,aValue.lastIndexOf(','));
} }
OUString SAL_CALL ODatabaseMetaData::getNumericFunctions( ) OUString SAL_CALL ODatabaseMetaData::getNumericFunctions( )