mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in ThumbnailViewItem::calculateItemsPosition

Browse Source 
Change-Id: I8db99a3672e3603a25ee1f6ca4741a02b73c9516
Reviewed-on: https://gerrit.libreoffice.org/81184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-18 10:55:51 +02:00
parent 2302674d6c
commit 4a20922e0e
6 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -148,9 +148,6 @@ include/sfx2/sidebar/TitleBar.hxx:61
include/sfx2/stbitem.hxx:100 include/sfx2/stbitem.hxx:100
_Bool SfxStatusBarControl::MouseButtonUp(const class MouseEvent &,) _Bool SfxStatusBarControl::MouseButtonUp(const class MouseEvent &,)
0 0
include/sfx2/thumbnailviewitem.hxx:118
void ThumbnailViewItem::calculateItemsPosition(const long,const long,const long,unsigned int,const struct ThumbnailItemAttributes *,)
10111
include/svl/svdde.hxx:228 include/svl/svdde.hxx:228
_Bool DdeGetPutItem::Put(const class DdeData *,) _Bool DdeGetPutItem::Put(const class DdeData *,)
0 0

2
include/sfx2/emojiviewitem.hxx
View File

@@ -26,7 +26,7 @@ public:
virtual void Paint (drawinglayer::processor2d::BaseProcessor2D *pProcessor, virtual void Paint (drawinglayer::processor2d::BaseProcessor2D *pProcessor,
const ThumbnailItemAttributes *pAttrs) override; const ThumbnailItemAttributes *pAttrs) override;
virtual void calculateItemsPosition (const long nThumbnailHeight, const long nDisplayHeight, virtual void calculateItemsPosition (const long nThumbnailHeight,
const long nPadding, sal_uInt32 nMaxTextLength, const long nPadding, sal_uInt32 nMaxTextLength,
const ThumbnailItemAttributes *pAttrs) override; const ThumbnailItemAttributes *pAttrs) override;
private: private:

2
include/sfx2/thumbnailviewitem.hxx
View File

@@ -115,7 +115,7 @@ public:
const tools::Rectangle& getDrawArea () const { return maDrawArea; } const tools::Rectangle& getDrawArea () const { return maDrawArea; }
virtual void calculateItemsPosition (const long nThumbnailHeight, const long nDisplayHeight, virtual void calculateItemsPosition (const long nThumbnailHeight,
const long nPadding, sal_uInt32 nMaxTextLength, const long nPadding, sal_uInt32 nMaxTextLength,
const ThumbnailItemAttributes *pAttrs); const ThumbnailItemAttributes *pAttrs);

2
sfx2/source/control/emojiviewitem.cxx
View File

@@ -37,7 +37,7 @@ EmojiViewItem::~EmojiViewItem ()
} }
void EmojiViewItem::calculateItemsPosition (const long /*nThumbnailHeight*/, const long, void EmojiViewItem::calculateItemsPosition (const long /*nThumbnailHeight*/,
const long /*nPadding*/, sal_uInt32 nMaxTextLength, const long /*nPadding*/, sal_uInt32 nMaxTextLength,
const ThumbnailItemAttributes *pAttrs) const ThumbnailItemAttributes *pAttrs)
{ {

4
sfx2/source/control/thumbnailview.cxx
View File

@@ -354,7 +354,7 @@ void ThumbnailView::CalculateItemPositions (bool bScrollBarUsed)
} }
pItem->setDrawArea(::tools::Rectangle( Point(x,y), Size(mnItemWidth, mnItemHeight) )); pItem->setDrawArea(::tools::Rectangle( Point(x,y), Size(mnItemWidth, mnItemHeight) ));
pItem->calculateItemsPosition(mnThumbnailHeight,mnDisplayHeight,mnItemPadding,mpItemAttrs->nMaxTextLength,mpItemAttrs.get()); pItem->calculateItemsPosition(mnThumbnailHeight,mnItemPadding,mpItemAttrs->nMaxTextLength,mpItemAttrs.get());
if ( !((nCurCount+1) % mnCols) ) if ( !((nCurCount+1) % mnCols) )
{ {
@@ -1510,7 +1510,7 @@ void SfxThumbnailView::CalculateItemPositions(bool bScrollBarUsed)
} }
pItem->setDrawArea(::tools::Rectangle( Point(x,y), Size(mnItemWidth, mnItemHeight) )); pItem->setDrawArea(::tools::Rectangle( Point(x,y), Size(mnItemWidth, mnItemHeight) ));
pItem->calculateItemsPosition(mnThumbnailHeight,mnDisplayHeight,mnItemPadding,mpItemAttrs->nMaxTextLength,mpItemAttrs.get()); pItem->calculateItemsPosition(mnThumbnailHeight,mnItemPadding,mpItemAttrs->nMaxTextLength,mpItemAttrs.get());
if ( !((nCurCount+1) % mnCols) ) if ( !((nCurCount+1) % mnCols) )
{ {

2
sfx2/source/control/thumbnailviewitem.cxx
View File

@@ -120,7 +120,7 @@ void ThumbnailViewItem::setDrawArea (const ::tools::Rectangle &area)
maDrawArea = area; maDrawArea = area;
} }
void ThumbnailViewItem::calculateItemsPosition (const long nThumbnailHeight, const long, void ThumbnailViewItem::calculateItemsPosition (const long nThumbnailHeight,
const long nPadding, sal_uInt32 nMaxTextLength, const long nPadding, sal_uInt32 nMaxTextLength,
const ThumbnailItemAttributes *pAttrs) const ThumbnailItemAttributes *pAttrs)
{ {