mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#705112 Using invalid iterator

Browse Source 
Change-Id: I6d05e418436b9d0b12be977b7842e1230ba3c7b1
This commit is contained in:
Caolán McNamara
2014-02-11 10:00:41 +00:00
parent 7c19ff431b
commit 4ba25fbab6
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
reportdesign/source/ui/dlg/GroupsSorting.cxx
View File

@@ -772,12 +772,15 @@ void OFieldExpressionControl::DeleteRows()
m_pParent->m_pController->executeChecked(SID_GROUP_REMOVE,aArgs); m_pParent->m_pController->executeChecked(SID_GROUP_REMOVE,aArgs);
::std::vector<sal_Int32>::iterator aFind = ::std::find(m_aGroupPositions.begin(),m_aGroupPositions.end(),nGroupPos); ::std::vector<sal_Int32>::iterator aFind = ::std::find(m_aGroupPositions.begin(),m_aGroupPositions.end(),nGroupPos);
if (aFind != m_aGroupPositions.end())
{
*aFind = NO_GROUP; *aFind = NO_GROUP;
::std::vector<sal_Int32>::iterator aEnd = m_aGroupPositions.end(); ::std::vector<sal_Int32>::iterator aEnd = m_aGroupPositions.end();
for(++aFind;aFind != aEnd;++aFind) for(++aFind;aFind != aEnd;++aFind)
if ( *aFind != NO_GROUP ) if ( *aFind != NO_GROUP )
--*aFind; --*aFind;
} }
}
nIndex = NextSelectedRow(); nIndex = NextSelectedRow();
} }