mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adapt structurallyIdentical to current needs

Browse Source 
...since aad94d48b19135a2e46ac7b2c0f41f3bb29bb5a7 "Silence warnings in
salvtables.hxx", where --enable-compiler-plugins=debug had started to fail with

> In file included from vcl/source/app/salvtables.cxx:75:
> vcl/inc/salvtables.hxx:128:69: fatal error: TODO: Unexpected 'IdenticalDefaultArgumentsResult::Maybe' [loplugin:overrideparam]
>     weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr,
>                                                                     ^~~~~~~
> include/vcl/weld.hxx:2138:69: note: TODO: second argument is here [loplugin:overrideparam]
>     weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr,
>                                                                     ^~~~~~~
> MaterializeTemporaryExpr 0x7fdff3111360 'const a11yref':'const class com::sun:⭐:uno::Reference<class com::sun:⭐:accessibility::XAccessible>' lvalue
> `-CXXBindTemporaryExpr 0x7fdff3111340 'const a11yref':'const class com::sun:⭐:uno::Reference<class com::sun:⭐:accessibility::XAccessible>' (CXXTemporary 0x7fdff3111340)
>   `-CXXConstructExpr 0x7fdff3111308 'const a11yref':'const class com::sun:⭐:uno::Reference<class com::sun:⭐:accessibility::XAccessible>' 'void (class com::sun:⭐:accessibility::XAccessible *)'
>     `-ImplicitCastExpr 0x7fdff31112f0 'class com::sun:⭐:accessibility::XAccessible *' <NullToPointer>
>       `-CXXNullPtrLiteralExpr 0x7fdff31112b0 'nullptr_t'
> MaterializeTemporaryExpr 0x7fdff39275d8 'const a11yref':'const class com::sun:⭐:uno::Reference<class com::sun:⭐:accessibility::XAccessible>' lvalue
> `-CXXBindTemporaryExpr 0x7fdff39275b8 'const a11yref':'const class com::sun:⭐:uno::Reference<class com::sun:⭐:accessibility::XAccessible>' (CXXTemporary 0x7fdff39275b8)
>   `-CXXConstructExpr 0x7fdff3927580 'const a11yref':'const class com::sun:⭐:uno::Reference<class com::sun:⭐:accessibility::XAccessible>' 'void (class com::sun:⭐:accessibility::XAccessible *)'
>     `-ImplicitCastExpr 0x7fdff3927568 'class com::sun:⭐:accessibility::XAccessible *' <NullToPointer>
>       `-CXXNullPtrLiteralExpr 0x7fdff3927528 'nullptr_t'

Change-Id: I2603180571df2248d4697ba63e1a8391d0dfc596
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89157
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann 2020-02-20 21:04:11 +01:00
parent 358146bbbd
commit 4c11b51b34
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/plugin.cxx
View File

@ -95,8 +95,11 @@ bool structurallyIdentical(Stmt const * stmt1, Stmt const * stmt2) {
}
break;
case Stmt::MaterializeTemporaryExprClass:
case Stmt::CXXBindTemporaryExprClass:
case Stmt::ParenExprClass:
break;
case Stmt::CXXNullPtrLiteralExprClass:
return true;
default:
// Conservatively assume non-identical for expressions that don't happen for us in practice
// when compiling the LO code base (and for which the above set of supported classes would