mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1326994 SBSC: String concatenation in loop using + operator

Browse Source 
Change-Id: I4fdd7388012b8773b59a69589c06d95d5d51f389
This commit is contained in:
Caolán McNamara
2015-12-30 13:50:07 +00:00
parent 5640826c0d
commit 4d4114668e
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
wizards/com/sun/star/wizards/db/QueryMetaData.java
View File

@@ -147,14 +147,15 @@ public class QueryMetaData extends CommandMetaData
ArrayList<String> CommandNames = new ArrayList<String>(1); ArrayList<String> CommandNames = new ArrayList<String>(1);
for (int i = 0; i < _FieldNames.length; i++) for (int i = 0; i < _FieldNames.length; i++)
{ {
String CurCommandName = PropertyNames.EMPTY_STRING;
String[] MetaList = JavaTools.ArrayoutofString(_FieldNames[i], "."); String[] MetaList = JavaTools.ArrayoutofString(_FieldNames[i], ".");
if (MetaList.length > 1) if (MetaList.length > 1)
{ {
StringBuilder sb = new StringBuilder(PropertyNames.EMPTY_STRING);
for (int a = 0; a < MetaList.length - 1; a++) for (int a = 0; a < MetaList.length - 1; a++)
{ {
CurCommandName += MetaList[a]; sb.append(MetaList[a]);
} }
String CurCommandName = sb.toString();
if (!CommandNames.contains(CurCommandName)) if (!CommandNames.contains(CurCommandName))
{ {
CommandNames.add(CurCommandName); CommandNames.add(CurCommandName);
@@ -166,8 +167,6 @@ public class QueryMetaData extends CommandMetaData
return sIncludedCommandNames; return sIncludedCommandNames;
} }
public void initializeFieldTitleSet() public void initializeFieldTitleSet()
{ {
try try