mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Let loplugin:passstuffbyref also look at fn defn not preceded by any decl

Browse Source 
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
This commit is contained in:
Stephan Bergmann
2016-06-08 17:14:34 +02:00
parent 46c7ecf760
commit 4d49c9601c
35 changed files with 71 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
compilerplugins/clang/passstuffbyref.cxx
View File

@@ -58,8 +58,11 @@ bool PassStuffByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
if (ignoreLocation(functionDecl)) {
return true;
}
if (functionDecl->isDeleted())
if (functionDecl->isDeleted()
|| functionDecl->isFunctionTemplateSpecialization())
{
return true;
}
// only consider base declarations, not overriden ones, or we warn on methods that
// are overriding stuff from external libraries
const CXXMethodDecl * methodDecl = dyn_cast<CXXMethodDecl>(functionDecl);
@@ -73,9 +76,8 @@ bool PassStuffByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
}
void PassStuffByRef::checkParams(const FunctionDecl * functionDecl) {
// only warn on the definition/prototype of the function,
// not on the function implementation
if (functionDecl->isThisDeclarationADefinition()) {
// Only warn on the definition of the function:
if (!functionDecl->isThisDeclarationADefinition()) {
return;
}
unsigned n = functionDecl->getNumParams();
@@ -109,6 +111,13 @@ void PassStuffByRef::checkParams(const FunctionDecl * functionDecl) {
("passing primitive type param %0 by const &, rather pass by value"),
pvDecl->getLocation())
<< t << pvDecl->getSourceRange();
auto can = functionDecl->getCanonicalDecl();
if (can->getLocation() != functionDecl->getLocation()) {
report(
DiagnosticsEngine::Note, "function is declared here:",
can->getLocation())
<< can->getSourceRange();
}
}
}
}
@@ -223,10 +232,10 @@ bool PassStuffByRef::isPrimitiveConstRef(QualType type) {
if (type->isIncompleteType()) {
return false;
}
if (!type->isReferenceType()) {
const clang::ReferenceType* referenceType = type->getAs<ReferenceType>();
if (referenceType == nullptr) {
return false;
}
const clang::ReferenceType* referenceType = dyn_cast<ReferenceType>(type);
QualType pointeeQT = referenceType->getPointeeType();
if (!pointeeQT.isConstQualified()) {
return false;