mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:simplifybool improve search for negated operator

Browse Source 
Change-Id: Id6ac35fefa5c3e1f64c222713791e849b3cb4d34
Reviewed-on: https://gerrit.libreoffice.org/68379
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-02-26 12:07:24 +02:00
parent 19240f625f
commit 4d502ef355
15 changed files with 146 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
compilerplugins/clang/test/simplifybool.cxx
View File

@@ -9,6 +9,12 @@
#include <rtl/ustring.hxx>
// expected-note@rtl/ustring.hxx:* 2 {{the presumed corresponding negated operator is declared here [loplugin:simplifybool]}}
#include <rtl/string.hxx>
// expected-note@rtl/string.hxx:* {{the presumed corresponding negated operator is declared here [loplugin:simplifybool]}}
#include <basegfx/vector/b3dvector.hxx>
// expected-note@basegfx/tuple/b3dtuple.hxx:* {{the presumed corresponding negated operator is declared here [loplugin:simplifybool]}}
#include <map>
namespace group1
{
@@ -105,6 +111,16 @@ void testRecord()
OUString d2;
v = !(d1 == d2);
// expected-error@-1 {{logical negation of comparison operator, can be simplified by inverting operator [loplugin:simplifybool]}}
OString e1;
OString e2;
v = !(e1 == e2);
// expected-error@-1 {{logical negation of comparison operator, can be simplified by inverting operator [loplugin:simplifybool]}}
// the operator != is in a base-class, and the param is a base-type
basegfx::B3DVector f1;
basegfx::B3DVector f2;
v = !(f1 == f2);
// expected-error@-1 {{logical negation of comparison operator, can be simplified by inverting operator [loplugin:simplifybool]}}
}
struct Record4
@@ -143,4 +159,15 @@ bool foo3(int a, bool b)
}
};
namespace group5
{
bool foo1(std::map<int, int>* pActions, int aKey)
{
auto aIter = pActions->find(aKey);
//TODO this doesn't work yet because I'd need to implement conversion operators during method/func lookup
return !(aIter == pActions->end());
// expected-error@-1 {{logical negation of comparison operator, can be simplified by inverting operator [loplugin:simplifybool]}}
}
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */