From 4ded63a1aaf3a8ca7916e822a8e7eb342d21929d Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Wed, 3 Jul 2019 22:13:59 +0200 Subject: [PATCH] cid#1448341: perf inefficient map iterator Change-Id: I5b5ba2b6ed370765e38b51a23175c73dc0e2c8f8 Reviewed-on: https://gerrit.libreoffice.org/75061 Tested-by: Jenkins Reviewed-by: Julien Nabet --- .../star/lib/uno/helper/MultiTypeInterfaceContainer.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java b/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java index 803c02e8340c..9b061f81c217 100644 --- a/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java +++ b/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java @@ -80,10 +80,9 @@ public class MultiTypeInterfaceContainer synchronized public InterfaceContainer getContainer(Object key) { InterfaceContainer retVal= null; - Iterator it= map.keySet().iterator(); - while (it.hasNext()) + for (Map.Entry entry : map.entrySet()) { - Object obj= it.next(); + Object obj= entry.getKey(); if (obj == null && key == null) { retVal= map.get(null); @@ -91,7 +90,7 @@ public class MultiTypeInterfaceContainer } else if( obj != null && obj.equals(key)) { - retVal= map.get(obj); + retVal= entry.getValue(); break; } }