new loplugin:unuseddefaultparams

Change-Id: I2c3e7d66be9e3883ea2801ff394948cc580d1e44
2016-02-25 11:33:33 +02:00
parent f66d734bcd
commit 4fbf95deba
14 changed files with 347 additions and 91 deletions
--- a/compilerplugins/clang/unusedfields.cxx
+++ b/compilerplugins/clang/unusedfields.cxx
@@ -47,17 +47,16 @@ struct MyFieldInfo
    std::string fieldName;
    std::string fieldType;
    std::string sourceLocation;
-
-    bool operator < (const MyFieldInfo &other) const
-    {
-        if (parentClass < other.parentClass)
-            return true;
-        else if (parentClass == other.parentClass)
-            return fieldName < other.fieldName;
-        else
-            return false;
-    }
 };
+bool operator < (const MyFieldInfo &lhs, const MyFieldInfo &rhs)
+{
+    if (lhs.parentClass < rhs.parentClass)
+        return true;
+    else if (lhs.parentClass == rhs.parentClass)
+         return lhs.fieldName < rhs.fieldName;
+    else
+        return false;
+}


 // try to limit the voluminous output a little