loplugin:countusersofdefaultparams in vcl..xmlsecurity

Change-Id: I538596a99e632178d928ff7e66ad45c71b73c6fd
Reviewed-on: https://gerrit.libreoffice.org/28018
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
This commit is contained in:
Noel Grandin 2016-08-10 13:48:02 +02:00 committed by Noel Grandin
parent 8806a86c9d
commit 500a3be0ea
29 changed files with 39 additions and 39 deletions

View File

@ -81,7 +81,7 @@ private:
int mnReqGlyphCount;
protected:
bool CreateFontSubsetFromCff( sal_Int32* pOutGlyphWidths = nullptr );
bool CreateFontSubsetFromCff( sal_Int32* pOutGlyphWidths );
bool CreateFontSubsetFromSfnt( sal_Int32* pOutGlyphWidths );
static bool CreateFontSubsetFromType1( sal_Int32* pOutGlyphWidths );
};

View File

@ -113,7 +113,7 @@ public:
virtual void AdjustLayout( ImplLayoutArgs& ) override; // adjusting positions
// methods using string indexing
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra=0, int nFactor=1) const override;
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra, int nFactor) const override;
virtual DeviceCoordinate FillDXArray( DeviceCoordinate* pDXArray ) const override;
void ApplyDXArray(ImplLayoutArgs &rArgs, std::vector<int> & rDeltaWidth);

View File

@ -111,7 +111,7 @@ public:
/// GetAddedHeight( 0 ) @return 0
/// GetAddedHeight( LISTBOX_ENTRY_NOTFOUND ) @return 0
/// GetAddedHeight( i, k ) with k > i is equivalent -GetAddedHeight( k, i )
long GetAddedHeight( sal_Int32 nEndIndex, sal_Int32 nBeginIndex = 0 ) const;
long GetAddedHeight( sal_Int32 nEndIndex, sal_Int32 nBeginIndex ) const;
long GetEntryHeight( sal_Int32 nPos ) const;
sal_Int32 GetEntryCount() const { return (sal_Int32 )maEntries.size(); }
@ -561,7 +561,7 @@ public:
bool IsUserDrawEnabled() const { return mbUserDrawEnabled; }
void DrawEntry(vcl::RenderContext& rRenderContext, bool bDrawImage,
bool bDrawTextAtImagePos = false, bool bLayout = false);
bool bDrawTextAtImagePos, bool bLayout = false);
bool GetEdgeBlending() const { return mbEdgeBlending; }
void SetEdgeBlending(bool bNew) { mbEdgeBlending = bNew; }

View File

@ -104,7 +104,7 @@ protected:
void ImplInitClipRegion();
void ImplSetClipBit( const vcl::Region& rClip, GLuint nMask );
void ImplDrawLineAA( double nX1, double nY1, double nX2, double nY2, bool edge = false );
void ImplDrawLineAA( double nX1, double nY1, double nX2, double nY2, bool edge );
bool CheckOffscreenTexture();
void ApplyProgramMatrices(float fPixelOffset = 0.0);
@ -121,7 +121,7 @@ public:
bool UseInvert(SalInvert nFlags);
void DrawConvexPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry, bool blockAA = false );
void DrawConvexPolygon( const tools::Polygon& rPolygon, bool blockAA = false );
void DrawConvexPolygon( const tools::Polygon& rPolygon, bool blockAA );
void DrawTrapezoid( const basegfx::B2DTrapezoid& trapezoid, bool blockAA );
void DrawRect( long nX, long nY, long nWidth, long nHeight );
void DrawRect( const Rectangle& rRect );
@ -133,7 +133,7 @@ public:
void DrawTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false );
void DrawTransformedTexture( OpenGLTexture& rTexture, OpenGLTexture& rMask, const basegfx::B2DPoint& rNull, const basegfx::B2DPoint& rX, const basegfx::B2DPoint& rY );
void DrawAlphaTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted, bool pPremultiplied );
void DrawTextureDiff( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry, bool bInverted = false );
void DrawTextureDiff( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry, bool bInverted );
void DrawTextureWithMask( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry );
void DrawBlendedTexture( OpenGLTexture& rTexture, OpenGLTexture& rMask, OpenGLTexture& rAlpha, const SalTwoRect& rPosAry );
void DrawMask( OpenGLTexture& rTexture, SalColor nMaskColor, const SalTwoRect& rPosAry );
@ -162,7 +162,7 @@ public:
enum XOROption { IGNORE_XOR, IMPLEMENT_XOR };
// initialize pre-draw state
void InitializePreDrawState(XOROption eOpt = IGNORE_XOR);
void InitializePreDrawState(XOROption eOpt);
// operations to do before painting
void PreDraw(XOROption eOpt = IGNORE_XOR);

View File

@ -174,7 +174,7 @@ public:
int GetOrientation() const { return mnOrientation; }
// methods using string indexing
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra=0, int nFactor=1) const = 0;
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra, int nFactor) const = 0;
virtual DeviceCoordinate FillDXArray( DeviceCoordinate* pDXArray ) const = 0;
virtual DeviceCoordinate GetTextWidth() const { return FillDXArray( nullptr ); }
virtual void GetCaretPositions( int nArraySize, long* pCaretXArray ) const = 0;
@ -234,7 +234,7 @@ class VCL_PLUGIN_PUBLIC MultiSalLayout : public SalLayout
{
public:
virtual void DrawText( SalGraphics& ) const override;
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra=0, int nFactor=1) const override;
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra, int nFactor) const override;
virtual DeviceCoordinate FillDXArray( DeviceCoordinate* pDXArray ) const override;
virtual void GetCaretPositions( int nArraySize, long* pCaretXArray ) const override;
virtual int GetNextGlyphs( int nLen, sal_GlyphId* pGlyphIdxAry, Point& rPos,
@ -336,7 +336,7 @@ public:
// used by upper layers
virtual DeviceCoordinate GetTextWidth() const override;
virtual DeviceCoordinate FillDXArray( DeviceCoordinate* pDXArray ) const override;
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra=0, int nFactor=1) const override;
virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, DeviceCoordinate nCharExtra, int nFactor) const override;
virtual void GetCaretPositions( int nArraySize, long* pCaretXArray ) const override;
// used by display layers

View File

@ -34,7 +34,7 @@ void ImplDrawSpinButton(vcl::RenderContext& rRenderContext, vcl::Window* pWindow
// Draw Up/Down buttons suitable for use in any context
void ImplDrawUpDownButtons(vcl::RenderContext& rRenderContext,
const Rectangle& rUpperRect, const Rectangle& rLowerRect,
bool bUpperIn, bool bLowerIn, bool bUpperEnabled = true, bool bLowerEnabled = true,
bool bUpperIn, bool bLowerIn, bool bUpperEnabled, bool bLowerEnabled = true,
bool bHorz = false, bool bMirrorHorz = false);

View File

@ -245,7 +245,7 @@ public:
void PSUploadPS1Font (sal_Int32 nFontID);
void PSSetFont (const OString& rName,
rtl_TextEncoding nEncoding = RTL_TEXTENCODING_DONTKNOW)
rtl_TextEncoding nEncoding)
{ maVirtualStatus.maFont = rName; maVirtualStatus.maEncoding = nEncoding; }
/* graphics status stack */

View File

@ -162,8 +162,8 @@ public:
virtual ~X11SalFrame();
long Dispatch( XEvent *pEvent );
void Init( SalFrameStyleFlags nSalFrameStyle, SalX11Screen nScreen = SalX11Screen( -1 ),
SystemParentData* pParentData = nullptr, bool bUseGeometry = false );
void Init( SalFrameStyleFlags nSalFrameStyle, SalX11Screen nScreen,
SystemParentData* pParentData, bool bUseGeometry = false );
SalDisplay* GetDisplay() const
{

View File

@ -61,7 +61,7 @@ public:
bool mbVisible;
static VCL_DLLPUBLIC bool Dispatch( XEvent* pEvent );
static VCL_DLLPUBLIC X11SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true );
static VCL_DLLPUBLIC X11SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow );
X11SalObject();
virtual ~X11SalObject();

View File

@ -258,7 +258,7 @@ public:
* set hints what decoration is needed;
* must be called before showing the frame
*/
virtual void setFrameTypeAndDecoration( X11SalFrame* pFrame, WMWindowType eType, int nDecorationFlags, X11SalFrame* pTransientFrame = nullptr ) const;
virtual void setFrameTypeAndDecoration( X11SalFrame* pFrame, WMWindowType eType, int nDecorationFlags, X11SalFrame* pTransientFrame ) const;
/*
* tells whether there is WM support for splash screens

View File

@ -122,7 +122,7 @@ bool ImplNumericProcessKeyInput( Edit*, const KeyEvent& rKEvt,
bool ImplNumericGetValue( const OUString& rStr, BigInt& rValue,
sal_uInt16 nDecDigits, const LocaleDataWrapper& rLocaleDataWrapper,
bool bCurrency = false )
bool bCurrency )
{
OUString aStr = rStr;
OUStringBuffer aStr1;

View File

@ -49,7 +49,7 @@ class XBMReader : public GraphicReader
void InitTable();
OString FindTokenLine( SvStream* pInStm, const char* pTok1,
const char* pTok2 = nullptr, const char* pTok3 = nullptr );
const char* pTok2, const char* pTok3 = nullptr );
long ParseDefine( const sal_Char* pDefine );
bool ParseData( SvStream* pInStm, const OString& aLastLine, XBMFormat eFormat );

View File

@ -621,8 +621,8 @@ public:
bool bRecordPath = false
);
void DrawPolyBezier( tools::Polygon& rPolygin,
bool bDrawTo = false,
bool bRecordPath = false
bool bDrawTo,
bool bRecordPath
);
void DrawText( Point& rPosition,
OUString& rString,

View File

@ -199,7 +199,7 @@ private:
public:
WMFWriter();
bool WriteWMF(const GDIMetaFile & rMTF, SvStream & rTargetStream, FilterConfigItem* pFilterConfigItem, bool bPlaceable=true);
bool WriteWMF(const GDIMetaFile & rMTF, SvStream & rTargetStream, FilterConfigItem* pFilterConfigItem, bool bPlaceable);
};
#endif

View File

@ -898,7 +898,7 @@ static void appendDouble( double fValue, OStringBuffer& rBuffer, sal_Int32 nPrec
}
}
static void appendColor( const Color& rColor, OStringBuffer& rBuffer, bool bConvertToGrey = false )
static void appendColor( const Color& rColor, OStringBuffer& rBuffer, bool bConvertToGrey )
{
if( rColor != Color( COL_TRANSPARENT ) )

View File

@ -1176,7 +1176,7 @@ public:
// links
sal_Int32 createLink( const Rectangle& rRect, sal_Int32 nPageNr );
sal_Int32 createDest( const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ );
sal_Int32 createDest( const Rectangle& rRect, sal_Int32 nPageNr, PDFWriter::DestAreaType eType );
sal_Int32 registerDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr, PDFWriter::DestAreaType eType );
void setLinkDest( sal_Int32 nLinkId, sal_Int32 nDestId );
void setLinkURL( sal_Int32 nLinkId, const OUString& rURL );

View File

@ -45,7 +45,7 @@ public:
void DataChanged( const DataChangedEvent& rDCEvt ) override;
void SetImages( long nMaxHeight = 0, bool bForce = false );
void SetImages( long nMaxHeight, bool bForce = false );
void calcMinSize();
const Size& getMinSize() { return maMinSize;}

View File

@ -55,7 +55,7 @@ public:
virtual void setWMName( X11SalFrame* pFrame, const OUString& rWMName ) const override;
virtual void maximizeFrame( X11SalFrame* pFrame, bool bHorizontal = true, bool bVertical = true ) const override;
virtual void shade( X11SalFrame* pFrame, bool bToShaded ) const override;
virtual void setFrameTypeAndDecoration( X11SalFrame* pFrame, WMWindowType eType, int nDecorationFlags, X11SalFrame* pTransientFrame = nullptr ) const override;
virtual void setFrameTypeAndDecoration( X11SalFrame* pFrame, WMWindowType eType, int nDecorationFlags, X11SalFrame* pTransientFrame ) const override;
virtual void enableAlwaysOnTop( X11SalFrame* pFrame, bool bEnable ) const override;
virtual int handlePropertyNotify( X11SalFrame* pFrame, XPropertyEvent* pEvent ) const override;
virtual void showFullScreen( X11SalFrame* pFrame, bool bFullScreen ) const override;

View File

@ -135,7 +135,7 @@ inline void XRenderPeer::CompositeTrapezoids( int nOp,
nXSrc, nYSrc, pXT, nCount );
}
inline XRenderColor GetXRenderColor( SalColor rSalColor, double fTransparency = 0.0 )
inline XRenderColor GetXRenderColor( SalColor rSalColor, double fTransparency )
{
XRenderColor aRetVal;
// convert the SalColor

View File

@ -106,7 +106,7 @@ public:
void DrawText (PrinterGfx &rGfx, const Point& rPoint,
const sal_Unicode* pStr, sal_Int16 nLen,
const sal_Int32* pDeltaArray = nullptr);
const sal_Int32* pDeltaArray);
void DrawGlyphs (PrinterGfx& rGfx,
const Point& rPoint,
const sal_GlyphId* pGlyphIds,

View File

@ -84,13 +84,13 @@ namespace psp
const OUString& i_rOption,
const OUString& i_rValue,
const OUString& i_rTranslation,
const css::lang::Locale& i_rLocale = css::lang::Locale()
const css::lang::Locale& i_rLocale
);
void insertOption( const OUString& i_rKey,
const OUString& i_rOption,
const OUString& i_rTranslation,
const css::lang::Locale& i_rLocale = css::lang::Locale() )
const css::lang::Locale& i_rLocale )
{
insertValue( i_rKey, i_rOption, OUString(), i_rTranslation, i_rLocale );
}

View File

@ -242,7 +242,7 @@ public:
static OOXMLStream::Pointer_t
createStream(const OOXMLStream::Pointer_t& pStream,
OOXMLStream::StreamType_t nStreamType = OOXMLStream::DOCUMENT);
OOXMLStream::StreamType_t nStreamType);
static OOXMLStream::Pointer_t
createStream(const OOXMLStream::Pointer_t& pStream, const OUString & rId);

View File

@ -435,7 +435,7 @@ namespace chelp {
private:
css::uno::Reference< css::container::XHierarchicalNameAccess >
implGetJarFromPackage(const css::uno::Reference< css::deployment::XPackage >& xPackage,
OUString* o_pExtensionPath = nullptr, OUString* o_pExtensionRegistryPath = nullptr );
OUString* o_pExtensionPath, OUString* o_pExtensionRegistryPath );
}; // end class JarFileIterator

View File

@ -88,7 +88,7 @@ namespace helpdatafileproxy {
~Hdf()
{ releaseHashMap(); }
void createHashMap( bool bOptimizeForPerformance = false );
void createHashMap( bool bOptimizeForPerformance );
void releaseHashMap();
bool getValueForKey( const OString& rKey, HDFData& rValue );

View File

@ -326,7 +326,7 @@ protected:
enum ::xmloff::token::XMLTokenEnum eXMLName, /// attribute token
double dValue, /// date/time value
bool bIsDate, /// export as date (rather than date/time)?
bool bIsDuration = false, /// export as duration
bool bIsDuration, /// export as duration
bool bOmitDurationIfZero = true, /// omit zero-length durat.
sal_uInt16 nPrefix = XML_NAMESPACE_TEXT); /// attribute name prefix

View File

@ -44,7 +44,7 @@ class XMLTextListsHelper
/// list stack for importing:
/// push a list context on the list context stack
void PushListContext(XMLTextListBlockContext *i_pListBlock = nullptr);
void PushListContext(XMLTextListBlockContext *i_pListBlock);
void PushListContext(XMLNumberedParaContext *i_pNumberedParagraph);
/// pop the list context stack
void PopListContext();

View File

@ -123,7 +123,7 @@ namespace SchXMLTools
bool getXMLRangePropertyFromDataSequence(
const css::uno::Reference< css::chart2::data::XDataSequence > & xDataSequence,
OUString & rOutXMLRange,
bool bClearProp = false );
bool bClearProp );
css::uno::Reference< css::chart2::data::XDataProvider > getDataProviderFromParent( const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc );

View File

@ -153,9 +153,9 @@ public:
sal_uInt16 nPrefixOnly=0xffffU ) const;
bool ConvertURIToOASIS( OUString& rURI,
bool bSupportPackage=false ) const;
bool bSupportPackage ) const;
bool ConvertURIToOOo( OUString& rURI,
bool bSupportPackage=false ) const;
bool bSupportPackage ) const;
/** renames the given rOutAttributeValue if one of the parameters contains a
matching token in its lower 16 bits. The value is converted to the

View File

@ -47,7 +47,7 @@ namespace XmlSec
const OUString & rRawString);
OUString GetContentPart( const OUString& _rRawString );
OUString GetHexString( const css::uno::Sequence< sal_Int8 >& _rSeq, const char* _pSep = ":", sal_uInt16 _nLineBreak = 0xFFFF );
OUString GetHexString( const css::uno::Sequence< sal_Int8 >& _rSeq, const char* _pSep, sal_uInt16 _nLineBreak = 0xFFFF );
}
#define XMLSEC_RES(id) ResId(id,*XmlSec::GetResMgr())