mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Take array-to-pointer decay into account in loplugin:redundantcast

Browse Source 
Change-Id: I3c5bace180605d1a72a74feb1bf9f9b184a16d83
Reviewed-on: https://gerrit.libreoffice.org/63545
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2018-11-19 08:16:12 +01:00
parent adc8dfe0fa
commit 50e644253f
3 changed files with 55 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
compilerplugins/clang/redundantcast.cxx
View File

@@ -358,6 +358,28 @@ bool RedundantCast::VisitCXXStaticCastExpr(CXXStaticCastExpr const * expr) {
<< expr->getSourceRange();
return true;
}
if (auto const impl = dyn_cast<ImplicitCastExpr>(expr->getSubExpr())) {
if (impl->getCastKind() == CK_ArrayToPointerDecay && impl->getType() == t2)
//TODO: instead of exact QualType match, allow some variation?
{
auto const fn = handler.getMainFileName();
if (!(loplugin::isSamePathname(
fn, SRCDIR "/sal/qa/rtl/strings/test_ostring_concat.cxx")
|| loplugin::isSamePathname(
fn, SRCDIR "/sal/qa/rtl/strings/test_ostring_stringliterals.cxx")
|| loplugin::isSamePathname(
fn, SRCDIR "/sal/qa/rtl/strings/test_oustring_concat.cxx")
|| loplugin::isSamePathname(
fn, SRCDIR "/sal/qa/rtl/strings/test_oustring_stringliterals.cxx")))
{
report(
DiagnosticsEngine::Warning, "redundant static_cast from %0 to %1",
expr->getExprLoc())
<< expr->getSubExprAsWritten()->getType() << t2 << expr->getSourceRange();
}
return true;
}
}
auto const t3 = expr->getType();
auto const c1 = t1.getCanonicalType();
auto const c3 = t3.getCanonicalType();
@@ -471,6 +493,30 @@ bool RedundantCast::VisitCXXReinterpretCastExpr(
if (ignoreLocation(expr)) {
return true;
}
if (auto const sub = dyn_cast<ImplicitCastExpr>(expr->getSubExpr())) {
if (sub->getCastKind() == CK_ArrayToPointerDecay && sub->getType() == expr->getType())
//TODO: instead of exact QualType match, allow some variation?
{
if (loplugin::TypeCheck(sub->getType()).Pointer().Const().Char()) {
if (auto const lit = dyn_cast<clang::StringLiteral>(expr->getSubExprAsWritten())) {
if (lit->getKind() == clang::StringLiteral::UTF8) {
// Don't warn about
//
// redundant_cast<char const *>(u8"...")
//
// in pre-C++2a code:
return true;
}
}
}
report(
DiagnosticsEngine::Warning, "redundant reinterpret_cast from %0 to %1",
expr->getExprLoc())
<< expr->getSubExprAsWritten()->getType() << expr->getTypeAsWritten()
<< expr->getSourceRange();
return true;
}
}
if (expr->getSubExpr()->getType()->isVoidPointerType()) {
auto t = expr->getType()->getAs<clang::PointerType>();
if (t == nullptr || !t->getPointeeType()->isObjectType()) {

7
compilerplugins/clang/test/redundantcast.cxx
View File

@@ -386,6 +386,12 @@ void testIntermediaryStaticCast() {
d = int(d) + 1.0; // expected-error {{suspicious functional cast from 'double' to 'int', result is implicitly cast to 'double' [loplugin:redundantcast]}}
};
void testArrayDecay() {
(void) static_cast<char const *>(""); // expected-error {{redundant static_cast from 'const char [1]' to 'const char *' [loplugin:redundantcast]}}
(void) reinterpret_cast<char const *>(""); // expected-error {{redundant reinterpret_cast from 'const char [1]' to 'const char *' [loplugin:redundantcast]}}
(void) reinterpret_cast<char const *>(u8"");
}
int main() {
testConstCast();
testStaticCast();
@@ -395,6 +401,7 @@ int main() {
testReinterpretConstCast();
testDynamicCast();
testIntermediaryStaticCast();
testArrayDecay();
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */