mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not call getOrigName ever

Browse Source 
When one take look on what the code did:

   name = nameA;
   origName = nameA;

   GooString *getOrigName() { return origName; }
   GooString *getName() { return name; }

This code is used even with poppler 10 which was branched 4 years ago.
So simply do not bother with this code at all.

Change-Id: Iba877e765fb763878f5ccd3e1fa62c29cadc9085
This commit is contained in:
Tomas Chvatal
2012-05-15 15:05:38 +02:00
parent a490c01978
commit 516f81a176
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
View File

@@ -406,10 +406,6 @@ int PDFOutDev::parseFont( long long nNewId, GfxFont* gfxFont, GfxState* state )
int nSize = 0; int nSize = 0;
GooString* pFamily = gfxFont->getName(); GooString* pFamily = gfxFont->getName();
#if !POPPLER_CHECK_VERSION(0, 20, 0)
if( ! pFamily )
pFamily = gfxFont->getOrigName();
#endif
if( pFamily ) if( pFamily )
{ {
aNewFont.familyName.clear(); aNewFont.familyName.clear();