mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unnecessaryvirtual

Browse Source 
Change-Id: I4ca101ba838afecbbc8e841a6a9fa6c9c0460f14
Reviewed-on: https://gerrit.libreoffice.org/65497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2018-12-20 14:33:02 +02:00
parent d9d8ec2521
commit 526387b96e
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
compilerplugins/clang/unnecessaryvirtual.results
View File

@@ -20,8 +20,6 @@ basic/source/comp/codegen.cxx:524
_Bool BufferTransformer::processParams() _Bool BufferTransformer::processParams()
chart2/source/inc/WeakListenerAdapter.hxx:57 chart2/source/inc/WeakListenerAdapter.hxx:57
void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
cppcanvas/source/inc/implrenderer.hxx:69
void cppcanvas::internal::EMFPObject::~EMFPObject()
extensions/source/dbpilots/unoautopilot.hxx:99 extensions/source/dbpilots/unoautopilot.hxx:99
class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const
extensions/source/propctrlr/commoncontrol.hxx:127 extensions/source/propctrlr/commoncontrol.hxx:127
@@ -112,8 +110,10 @@ include/vbahelper/vbareturntypes.hxx:40
void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,) void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,)
include/vbahelper/vbareturntypes.hxx:41 include/vbahelper/vbareturntypes.hxx:41
type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
include/vcl/tabctrl.hxx:113 include/vcl/combobox.hxx:86
_Bool TabControl::DeactivatePage() int ComboBox::InsertEntry(const class rtl::OUString &,int,)
include/vcl/combobox.hxx:90
void ComboBox::RemoveEntryAt(int,)
sc/source/core/opencl/formulagroupcl.cxx:1051 sc/source/core/opencl/formulagroupcl.cxx:1051
_Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const
sc/source/core/opencl/formulagroupcl.cxx:1059 sc/source/core/opencl/formulagroupcl.cxx:1059

4
include/vcl/combobox.hxx
View File

@@ -83,11 +83,11 @@ public:
virtual void SetText( const OUString& rStr ) override; virtual void SetText( const OUString& rStr ) override;
virtual void SetText( const OUString& rStr, const Selection& rNewSelection ) override; virtual void SetText( const OUString& rStr, const Selection& rNewSelection ) override;
virtual sal_Int32 InsertEntry(const OUString& rStr, sal_Int32 nPos = COMBOBOX_APPEND); sal_Int32 InsertEntry(const OUString& rStr, sal_Int32 nPos = COMBOBOX_APPEND);
sal_Int32 InsertEntryWithImage( const OUString& rStr, const Image& rImage, sal_Int32 nPos = COMBOBOX_APPEND ); sal_Int32 InsertEntryWithImage( const OUString& rStr, const Image& rImage, sal_Int32 nPos = COMBOBOX_APPEND );
void RemoveEntry( const OUString& rStr ); void RemoveEntry( const OUString& rStr );
virtual void RemoveEntryAt(sal_Int32 nPos); void RemoveEntryAt(sal_Int32 nPos);
void Clear(); void Clear();
void EnableSelectAll(); void EnableSelectAll();

4
vcl/source/control/combobox.cxx
View File

@@ -921,8 +921,10 @@ void ComboBox::RemoveEntryAt(sal_Int32 const nPos)
{ {
const sal_Int32 nMRUCount = m_pImpl->m_pImplLB->GetEntryList()->GetMRUCount(); const sal_Int32 nMRUCount = m_pImpl->m_pImplLB->GetEntryList()->GetMRUCount();
if (nPos < 0 || nPos > COMBOBOX_MAX_ENTRIES - nMRUCount) if (nPos < 0 || nPos > COMBOBOX_MAX_ENTRIES - nMRUCount)
{
assert("bad position");
return; return;
}
m_pImpl->m_pImplLB->RemoveEntry( nPos + nMRUCount ); m_pImpl->m_pImplLB->RemoveEntry( nPos + nMRUCount );
CallEventListeners( VclEventId::ComboboxItemRemoved, reinterpret_cast<void*>(nPos) ); CallEventListeners( VclEventId::ComboboxItemRemoved, reinterpret_cast<void*>(nPos) );
} }