mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

extract some common code for checking if a functions address was taken

Browse Source 
Change-Id: I292b4e9bf17c83f83ff43ac4c5870d33092d0c71
This commit is contained in:
Noel Grandin
2017-10-27 10:54:31 +02:00
parent 5670f65cce
commit 569c7da252
4 changed files with 138 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
compilerplugins/clang/constantparam.cxx
View File

@@ -15,6 +15,7 @@
#include "plugin.hxx"
#include "compat.hxx"
#include "check.hxx"
#include "functionaddress.hxx"
/*
Find params on methods where the param is only ever passed as a single constant value.
@@ -53,10 +54,10 @@ bool operator < (const MyCallSiteInfo &lhs, const MyCallSiteInfo &rhs)
static std::set<MyCallSiteInfo> callSet;
class ConstantParam:
public RecursiveASTVisitor<ConstantParam>, public loplugin::Plugin
public loplugin::FunctionAddress<ConstantParam>
{
public:
explicit ConstantParam(InstantiationData const & data): Plugin(data) {}
explicit ConstantParam(InstantiationData const & data): loplugin::FunctionAddress<ConstantParam>(data) {}
virtual void run() override
{
@@ -70,6 +71,13 @@ public:
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
// this catches places that take the address of a method
for (auto functionDecl : getFunctionsWithAddressTaken())
{
for (unsigned i = 0; i < functionDecl->getNumParams(); ++i)
addToCallSet(functionDecl, i, functionDecl->getParamDecl(i)->getName(), "unknown3");
}
// dump all our output in one write call - this is to try and limit IO "crosstalk" between multiple processes
// writing to the same logfile
@@ -87,7 +95,6 @@ public:
bool shouldVisitImplicitCode () const { return true; }
bool VisitCallExpr( const CallExpr* );
bool VisitDeclRefExpr( const DeclRefExpr* );
bool VisitCXXConstructExpr( const CXXConstructExpr* );
private:
void addToCallSet(const FunctionDecl* functionDecl, int paramIndex, llvm::StringRef paramName, const std::string& callValue);
@@ -277,21 +284,6 @@ bool ConstantParam::VisitCallExpr(const CallExpr * callExpr) {
return true;
}
// this catches places that take the address of a method
bool ConstantParam::VisitDeclRefExpr( const DeclRefExpr* declRefExpr )
{
const Decl* decl = declRefExpr->getDecl();
const FunctionDecl* functionDecl = dyn_cast<FunctionDecl>(decl);
if (!functionDecl)
return true;
functionDecl = functionDecl->getCanonicalDecl();
for (unsigned i = 0; i < functionDecl->getNumParams(); ++i)
{
addToCallSet(functionDecl, i, functionDecl->getParamDecl(i)->getName(), "unknown3");
}
return true;
}
bool ConstantParam::VisitCXXConstructExpr( const CXXConstructExpr* constructExpr )
{
const CXXConstructorDecl* constructorDecl = constructExpr->getConstructor();