From 58b56f8c78eef15c70e1afd6b52c79a800a185ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Wed, 5 Apr 2017 10:00:13 +0100 Subject: [PATCH] add a clearDocumentHandler for null document handler case Change-Id: I661a2fd5381013056c69b379792560aed7121214 --- include/oox/core/fastparser.hxx | 2 ++ oox/source/core/fastparser.cxx | 7 +++++++ oox/source/core/xmlfilterbase.cxx | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/oox/core/fastparser.hxx b/include/oox/core/fastparser.hxx index 6af112d18d93..b2a9bab30ab6 100644 --- a/include/oox/core/fastparser.hxx +++ b/include/oox/core/fastparser.hxx @@ -78,6 +78,8 @@ public: void setDocumentHandler( const css::uno::Reference< css::xml::sax::XFastDocumentHandler >& rxDocHandler ); + void clearDocumentHandler(); + /** Parses the passed SAX input source. @param bCloseStream True = closes the stream in the input source after parsing. @throws css::xml::sax::SAXException diff --git a/oox/source/core/fastparser.cxx b/oox/source/core/fastparser.cxx index 4ce9d9f37cf7..d31ee7067f1c 100644 --- a/oox/source/core/fastparser.cxx +++ b/oox/source/core/fastparser.cxx @@ -107,6 +107,13 @@ void FastParser::setDocumentHandler( const Reference< XFastDocumentHandler >& rx mxParser->setFastDocumentHandler( rxDocHandler ); } +void FastParser::clearDocumentHandler() +{ + if (!mxParser.is()) + return; + mxParser->setFastDocumentHandler(nullptr); +} + void FastParser::parseStream( const InputSource& rInputSource, bool bCloseStream ) { // guard closing the input stream also when exceptions are thrown diff --git a/oox/source/core/xmlfilterbase.cxx b/oox/source/core/xmlfilterbase.cxx index 393911c97699..8401dd7ce59d 100644 --- a/oox/source/core/xmlfilterbase.cxx +++ b/oox/source/core/xmlfilterbase.cxx @@ -211,7 +211,7 @@ XmlFilterBase::~XmlFilterBase() // the following implicit destruction chain of ~XmlFilterBaseImpl, but in that // case it's member RelationsMap maRelationsMap will be destroyed, but maybe // still be used by ~FragmentHandler -> crash. - mxImpl->maFastParser.setDocumentHandler( nullptr ); + mxImpl->maFastParser.clearDocumentHandler(); } void XmlFilterBase::checkDocumentProperties(const Reference& xDocProps)