mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unusedfields all-can-be-private

Browse Source 
these fields can be private

Change-Id: I74423a9ae2ef0263a28c8a716ab1c55861e453d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154092
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2023-07-06 08:59:18 +02:00
parent a62af04445
commit 58d155b8be
18 changed files with 23 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/xmloff/XMLCharContext.hxx
View File

@ -29,7 +29,6 @@ class XMLOFF_DLLPUBLIC XMLCharContext : public SvXMLImportContext
XMLCharContext(const XMLCharContext&) = delete;
void operator =(const XMLCharContext&) = delete;
sal_Int16 m_nControl;
protected:
sal_uInt16 m_nCount;
sal_Unicode m_c;
public:

3
include/xmloff/XMLShapeStyleContext.hxx
View File

@ -33,10 +33,9 @@ class XMLOFF_DLLPUBLIC XMLShapeStyleContext: public XMLPropStyleContext
{
OUString m_sControlDataStyleName;
bool m_bIsNumRuleAlreadyConverted;
protected:
OUString m_sListStyleName;
protected:
virtual void SetAttribute( sal_Int32 nElement, const OUString& rValue ) override;
public:

3
include/xmlscript/xml_helper.hxx
View File

@ -88,10 +88,9 @@ public:
virtual OUString SAL_CALL getValueByIndex( sal_Int16 nPos ) override;
virtual OUString SAL_CALL getValueByName( OUString const & rName ) override;
protected:
private:
::std::vector< css::uno::Reference<
css::xml::sax::XAttributeList > > _subElems;
private:
OUString const _name;
::std::vector< OUString > _attrNames;
::std::vector< OUString > _attrValues;

2
sc/source/ui/inc/TableFillingAndNavigationTools.hxx
View File

@ -71,11 +71,11 @@ public:
class AddressWalkerWriter : public AddressWalker
{
public:
ScDocShell* mpDocShell;
ScDocument& mrDocument;
formula::FormulaGrammar::Grammar meGrammar;
public:
AddressWalkerWriter(const ScAddress& aInitialAddress, ScDocShell* pDocShell, ScDocument& rDocument,
formula::FormulaGrammar::Grammar eGrammar );

2
sc/source/ui/inc/docfunc.hxx
View File

@ -61,9 +61,9 @@ namespace sc
class ScDocFunc
{
protected:
ScDocShell& rDocShell;
protected:
bool AdjustRowHeight( const ScRange& rRange, bool bPaint, bool bApi );
void CreateOneName( ScRangeName& rList,
SCCOL nPosX, SCROW nPosY, SCTAB nTab,

3
sfx2/source/appl/shutdownicon.hxx
View File

@ -66,6 +66,7 @@ class ShutdownIcon : public ShutdownIconServiceBase
bool m_bSystemDialogs;
std::unique_ptr<sfx2::FileDialogHelper> m_pFileDlg;
css::uno::Reference< css::uno::XComponentContext > m_xContext;
css::uno::Reference< css::frame::XDesktop2 > m_xDesktop;
static rtl::Reference<ShutdownIcon> pShutdownIcon; // one instance
@ -135,8 +136,6 @@ class ShutdownIcon : public ShutdownIconServiceBase
const css::uno::Any& aValue ) override;
virtual css::uno::Any SAL_CALL getFastPropertyValue( ::sal_Int32 nHandle ) override;
css::uno::Reference< css::frame::XDesktop2 > m_xDesktop;
#ifdef _WIN32
static void EnableAutostartW32( const OUString &aShortcutName );
static OUString GetAutostartFolderNameW32();

3
svx/inc/sdr/properties/cellproperties.hxx
View File

@ -70,9 +70,8 @@ public:
void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem = nullptr) override;
sdr::table::CellRef mxCell;
private:
sdr::table::CellRef mxCell;
const CellTextProvider maTextProvider;
};

4
sw/inc/accessibilityoptions.hxx
View File

@ -18,11 +18,11 @@
*/
#pragma once
struct SwAccessibilityOptions
class SwAccessibilityOptions
{
bool bIsAlwaysAutoColor :1;
bool bIsStopAnimatedGraphics :1;
public:
SwAccessibilityOptions() :
bIsAlwaysAutoColor(false),
bIsStopAnimatedGraphics(false) {}

2
sw/inc/viewsh.hxx
View File

@ -59,7 +59,7 @@ class SvtAccessibilityOptions;
class SwPagePreviewLayout;
class SwTextFrame;
struct SwAccessibilityOptions;
class SwAccessibilityOptions;
namespace vcl { class Region; }
class SwPostItMgr;
class SdrPaintWindow;

4
sw/source/core/inc/drawfont.hxx
View File

@ -86,8 +86,6 @@ class SW_DLLPUBLIC SwDrawTextInfo
// inside second half of bound rect, used for Accessibility
bool m_bPosMatchesBounds :1;
public:
#ifdef DBG_UTIL
// These flags should control that the appropriate Set-function has been
// called before calling the Get-function of a member
@ -107,6 +105,8 @@ public:
bool m_bDrawSp: 1;
#endif
public:
/// constructor for simple strings
SwDrawTextInfo( SwViewShell const *pSh, OutputDevice &rOut,
const OUString &rText, sal_Int32 const nIdx, sal_Int32 const nLen,

3
sw/source/filter/html/wrthtml.hxx
View File

@ -647,7 +647,7 @@ inline void SwHTMLWriter::OutCSS1_Property( std::string_view pProp,
// positions in the document.
// In dtor all data is restored and the created PaM is deleted again.
struct HTMLSaveData
class HTMLSaveData
{
SwHTMLWriter& rWrt;
std::shared_ptr<SwUnoCursor> pOldPam;
@ -661,6 +661,7 @@ struct HTMLSaveData
bool bOldOutFooter : 1;
bool bOldOutFlyFrame : 1;
public:
HTMLSaveData( SwHTMLWriter&, SwNodeOffset nStt, SwNodeOffset nEnd,
bool bSaveNum=true,
const SwFrameFormat *pFrameFormat=nullptr );

2
sw/source/ui/dialog/swdlgfact.hxx
View File

@ -539,7 +539,6 @@ public:
class SwInsTableDlg;
class AbstractInsTableDlg_Impl : public AbstractInsTableDlg
{
protected:
std::shared_ptr<weld::DialogController> m_xDlg;
public:
explicit AbstractInsTableDlg_Impl(std::shared_ptr<weld::DialogController> p)
@ -620,7 +619,6 @@ public:
class SwMultiTOXTabDialog;
class AbstractMultiTOXTabDialog_Impl : public AbstractMultiTOXTabDialog
{
protected:
std::shared_ptr<SwMultiTOXTabDialog> m_xDlg;
public:
explicit AbstractMultiTOXTabDialog_Impl(std::shared_ptr<SwMultiTOXTabDialog> p)

11
vcl/source/filter/idxf/dxfentrd.hxx
View File

@ -360,18 +360,19 @@ struct DXFEdgeTypeLine : public DXFEdgeType
virtual bool EvaluateGroup( DXFGroupReader & rDGR ) override;
};
struct DXFEdgeTypeCircularArc : public DXFEdgeType
class DXFEdgeTypeCircularArc : public DXFEdgeType
{
DXFVector aCenter; // 10,20
double fRadius; // 40
double fStartAngle; // 50
double fEndAngle; // 51
sal_Int32 nIsCounterClockwiseFlag; // 73
public:
DXFEdgeTypeCircularArc();
virtual bool EvaluateGroup( DXFGroupReader & rDGR ) override;
};
struct DXFEdgeTypeEllipticalArc : public DXFEdgeType
class DXFEdgeTypeEllipticalArc : public DXFEdgeType
{
DXFVector aCenter; // 10,20
DXFVector aEndPoint; // 11,21
@ -379,19 +380,19 @@ struct DXFEdgeTypeEllipticalArc : public DXFEdgeType
double fStartAngle; // 50
double fEndAngle; // 51
sal_Int32 nIsCounterClockwiseFlag; // 73
public:
DXFEdgeTypeEllipticalArc();
virtual bool EvaluateGroup( DXFGroupReader & rDGR ) override;
};
struct DXFEdgeTypeSpline : public DXFEdgeType
class DXFEdgeTypeSpline : public DXFEdgeType
{
sal_Int32 nDegree; // 94
sal_Int32 nRational; // 73
sal_Int32 nPeriodic; // 74
sal_Int32 nKnotCount; // 75
sal_Int32 nControlCount; // 76
public:
DXFEdgeTypeSpline();
virtual bool EvaluateGroup( DXFGroupReader & rDGR ) override;
};

3
writerfilter/source/dmapper/LoggedResources.hxx
View File

@ -101,6 +101,7 @@ protected:
virtual void lcl_endGlossaryEntry() {}
virtual void lcl_checkId(const sal_Int32) {}
private:
#ifdef DBG_UTIL
LoggedResourcesHelper mHelper;
#endif
@ -119,6 +120,7 @@ protected:
virtual void lcl_attribute(Id name, Value& val) = 0;
virtual void lcl_sprm(Sprm& sprm) = 0;
private:
#ifdef DBG_UTIL
LoggedResourcesHelper mHelper;
#endif
@ -135,6 +137,7 @@ public:
protected:
virtual void lcl_entry(writerfilter::Reference<Properties>::Pointer_t ref) = 0;
private:
#ifdef DBG_UTIL
LoggedResourcesHelper mHelper;
#endif

1
xmloff/source/chart/contexts.hxx
View File

@ -35,7 +35,6 @@ namespace com::sun::star::xml::sax {
class SchXMLDocContext : public virtual SvXMLImportContext
{
protected:
SchXMLImportHelper& mrImportHelper;
public:

2
xmloff/source/core/SvXMLAttrCollection.hxx
View File

@ -18,10 +18,10 @@
class SvXMLAttrCollection
{
public:
SvXMLNamespaceMap aNamespaceMap;
std::vector<SvXMLAttr> aAttrs;
public:
bool operator==(const SvXMLAttrCollection &rCmp) const;
bool AddAttr( const OUString& rLName,
const OUString& rValue );

1
xmloff/source/forms/elementexport.hxx
View File

@ -39,7 +39,6 @@ namespace xmloff
//= OElementExport
class OElementExport : public OPropertyExport
{
protected:
css::uno::Sequence< css::script::ScriptEventDescriptor >
m_aEvents;

1
xmloff/source/forms/elementimport.hxx
View File

@ -437,7 +437,6 @@ namespace xmloff
friend class OListOptionImport;
friend class OComboItemImport;
protected:
std::vector<OUString >
m_aListSource;
std::vector< OUString >