mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NFC: unassigned variable pNewItem is always nullptr

Browse Source 
In 2015 commit 2ebd79b3d214c62c0997606115ebc50700d6a760 a
possible initialization of the variable was removed. So
at this point pNewItem must return false.

Change-Id: I5af9d8440463c96323c38a01f255c1dbb0113e09
Reviewed-on: https://gerrit.libreoffice.org/54395
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
This commit is contained in:
Justin Luth 2018-05-15 10:15:01 +03:00 committed by Justin Luth
parent d57c6f5d44
commit 5dcb065d24
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
svl/source/items/itemprop.cxx
View File

@ -218,7 +218,7 @@ void SfxItemPropertySet::setPropertyValue( const SfxItemPropertySimpleEntry& rEn
SfxItemState eState = rSet.GetItemState( rEntry.nWID, true, &pItem ); SfxItemState eState = rSet.GetItemState( rEntry.nWID, true, &pItem );
if (SfxItemState::SET != eState && SfxItemPool::IsWhich(rEntry.nWID)) if (SfxItemState::SET != eState && SfxItemPool::IsWhich(rEntry.nWID))
pItem = &rSet.GetPool()->GetDefaultItem(rEntry.nWID); pItem = &rSet.GetPool()->GetDefaultItem(rEntry.nWID);
if(!pNewItem && pItem) if (pItem)
{ {
pNewItem.reset(pItem->Clone()); pNewItem.reset(pItem->Clone());
} }