mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in IControlActionListener

Browse Source 
Change-Id: I2ce8df6a9a1ac2e6d6c5de08b32fb671bf10cd17
Reviewed-on: https://gerrit.libreoffice.org/81244
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-18 15:45:43 +02:00
parent 501233bf55
commit 5dcee37fc4
7 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -49,9 +49,6 @@ dbaccess/source/core/api/CacheSet.hxx:176
dbaccess/source/core/inc/containerapprove.hxx:53 dbaccess/source/core/inc/containerapprove.hxx:53
void dbaccess::IContainerApprove::approveElement(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> &,) void dbaccess::IContainerApprove::approveElement(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> &,)
10 10
dbaccess/source/ui/inc/callbacks.hxx:53
_Bool dbaui::IControlActionListener::requestDrag(signed char,const class Point &,)
01
desktop/source/deployment/registry/inc/dp_backend.h:84 desktop/source/deployment/registry/inc/dp_backend.h:84
void dp_registry::backend::Package::processPackage_(class osl::ResettableGuard<class osl::Mutex> &,_Bool,_Bool,const class rtl::Reference<class dp_misc::AbortChannel> &,const class com::sun::star::uno::Reference<class com::sun::star::ucb::XCommandEnvironment> &,) void dp_registry::backend::Package::processPackage_(class osl::ResettableGuard<class osl::Mutex> &,_Bool,_Bool,const class rtl::Reference<class dp_misc::AbortChannel> &,const class com::sun::star::uno::Reference<class com::sun::star::ucb::XCommandEnvironment> &,)
01111 01111

2
dbaccess/source/ui/app/AppController.cxx
View File

@@ -2267,7 +2267,7 @@ bool OApplicationController::requestQuickHelp( const SvTreeListEntry* /*_pEntry*
return false; return false;
} }
bool OApplicationController::requestDrag( sal_Int8 /*_nAction*/, const Point& /*_rPosPixel*/ ) bool OApplicationController::requestDrag( const Point& /*_rPosPixel*/ )
{ {
rtl::Reference<TransferableHelper> pTransfer; rtl::Reference<TransferableHelper> pTransfer;
if ( getContainer() && getContainer()->getSelectionCount() ) if ( getContainer() && getContainer()->getSelectionCount() )

2
dbaccess/source/ui/app/AppController.hxx
View File

@@ -484,7 +484,7 @@ namespace dbaui
// IControlActionListener overridables // IControlActionListener overridables
virtual bool requestQuickHelp( const SvTreeListEntry* _pEntry, OUString& _rText ) const override; virtual bool requestQuickHelp( const SvTreeListEntry* _pEntry, OUString& _rText ) const override;
virtual bool requestDrag( sal_Int8 _nAction, const Point& _rPosPixel ) override; virtual bool requestDrag( const Point& _rPosPixel ) override;
virtual sal_Int8 queryDrop( const AcceptDropEvent& _rEvt, const DataFlavorExVector& _rFlavors ) override; virtual sal_Int8 queryDrop( const AcceptDropEvent& _rEvt, const DataFlavorExVector& _rFlavors ) override;
virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) override; virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) override;

2
dbaccess/source/ui/browser/dsbrowserDnD.cxx
View File

@@ -173,7 +173,7 @@ namespace dbaui
return DND_ACTION_NONE; return DND_ACTION_NONE;
} }
bool SbaTableQueryBrowser::requestDrag( sal_Int8 /*_nAction*/, const Point& _rPosPixel ) bool SbaTableQueryBrowser::requestDrag( const Point& _rPosPixel )
{ {
// get the affected list entry // get the affected list entry
// ensure that the entry which the user clicked at is selected // ensure that the entry which the user clicked at is selected

4
dbaccess/source/ui/control/dbtreelistbox.cxx
View File

@@ -268,12 +268,12 @@ sal_Int8 DBTreeListBox::ExecuteDrop( const ExecuteDropEvent& _rEvt )
return DND_ACTION_NONE; return DND_ACTION_NONE;
} }
void DBTreeListBox::StartDrag( sal_Int8 _nAction, const Point& _rPosPixel ) void DBTreeListBox::StartDrag( sal_Int8 /*_nAction*/, const Point& _rPosPixel )
{ {
if ( m_pActionListener ) if ( m_pActionListener )
{ {
m_pDragedEntry = GetEntry(_rPosPixel); m_pDragedEntry = GetEntry(_rPosPixel);
if ( m_pDragedEntry && m_pActionListener->requestDrag( _nAction, _rPosPixel ) ) if ( m_pDragedEntry && m_pActionListener->requestDrag( _rPosPixel ) )
{ {
// if the (asynchronous) drag started, stop the selection timer // if the (asynchronous) drag started, stop the selection timer
implStopSelectionTimer(); implStopSelectionTimer();

2
dbaccess/source/ui/inc/callbacks.hxx
View File

@@ -50,7 +50,7 @@ namespace dbaui
/** handler for StartDrag requests /** handler for StartDrag requests
@return <TRUE/> if a drag operation was started @return <TRUE/> if a drag operation was started
*/ */
virtual bool requestDrag( sal_Int8 _nAction, const Point& _rPosPixel ) = 0; virtual bool requestDrag( const Point& _rPosPixel ) = 0;
/** check whether or not a drop request should be accepted /** check whether or not a drop request should be accepted
*/ */

2
dbaccess/source/ui/inc/unodatbr.hxx
View File

@@ -226,7 +226,7 @@ namespace dbaui
// IControlActionListener overridables // IControlActionListener overridables
virtual bool requestQuickHelp( const SvTreeListEntry* _pEntry, OUString& _rText ) const override; virtual bool requestQuickHelp( const SvTreeListEntry* _pEntry, OUString& _rText ) const override;
virtual bool requestDrag( sal_Int8 _nAction, const Point& _rPosPixel ) override; virtual bool requestDrag( const Point& _rPosPixel ) override;
virtual sal_Int8 queryDrop( const AcceptDropEvent& _rEvt, const DataFlavorExVector& _rFlavors ) override; virtual sal_Int8 queryDrop( const AcceptDropEvent& _rEvt, const DataFlavorExVector& _rFlavors ) override;
virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) override; virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) override;