mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disable this chunk of loplugin code on clang < 3.8

Browse Source 
not worth the spaghetti of making it work across version

Change-Id: I0de923b16fb6d58cbad55adc9878ab39bc0c86ae
This commit is contained in:
Noel Grandin 2016-11-01 12:58:17 +02:00
parent 458a9fd806
commit 5e997f4dba
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
compilerplugins/clang/unnecessaryoverride.cxx
View File

@ -222,13 +222,12 @@ const CXXMethodDecl* UnnecessaryOverride::findOverriddenOrSimilarMethodInSupercl
return nullptr; return nullptr;
} }
#if CLANG_VERSION < 30800
return nullptr;
#else
std::vector<const CXXMethodDecl*> maSimilarMethods; std::vector<const CXXMethodDecl*> maSimilarMethods;
#if CLANG_VERSION >= 30800
auto BaseMatchesCallback = [&](const CXXBaseSpecifier *cxxBaseSpecifier, CXXBasePath& ) auto BaseMatchesCallback = [&](const CXXBaseSpecifier *cxxBaseSpecifier, CXXBasePath& )
#else
auto BaseMatchesCallback = [&](const CXXBaseSpecifier *cxxBaseSpecifier, CXXBasePath&, void* )
#endif
{ {
if (cxxBaseSpecifier->getAccessSpecifier() != AS_public && cxxBaseSpecifier->getAccessSpecifier() != AS_protected) if (cxxBaseSpecifier->getAccessSpecifier() != AS_public && cxxBaseSpecifier->getAccessSpecifier() != AS_protected)
return false; return false;
@ -269,16 +268,13 @@ const CXXMethodDecl* UnnecessaryOverride::findOverriddenOrSimilarMethodInSupercl
}; };
CXXBasePaths aPaths; CXXBasePaths aPaths;
#if CLANG_VERSION >= 30800
methodDecl->getParent()->lookupInBases(BaseMatchesCallback, aPaths); methodDecl->getParent()->lookupInBases(BaseMatchesCallback, aPaths);
#else
methodDecl->getParent()->lookupInBases(BaseMatchesCallback, nullptr, aPaths);
#endif
if (maSimilarMethods.size() == 1) { if (maSimilarMethods.size() == 1) {
return maSimilarMethods[0]; return maSimilarMethods[0];
} }
return nullptr; return nullptr;
#endif
} }