mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1326973 SBSC: String concatenation in loop using + operator

Browse Source 
Change-Id: I8fb8afa2951201106443f76fde3f55ead24d43c2
This commit is contained in:
Caolán McNamara
2015-12-30 14:56:20 +00:00
parent f852edc6db
commit 5ff0c0c283
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javaunohelper/com/sun/star/lib/uno/helper/UnoUrl.java
View File

@@ -250,19 +250,21 @@ public class UnoUrl {
while (true) { while (true) {
char c = ','; char c = ',';
String aKey = "";
String aValue = "";
StringBuffer sb = new StringBuffer();
while ((pos < paramString.length()) while ((pos < paramString.length())
&& ((c = paramString.charAt(pos++)) != '=')) { && ((c = paramString.charAt(pos++)) != '=')) {
aKey += c; sb.append(c);
} }
String aKey = sb.toString();
sb = new StringBuffer();
while ((pos < paramString.length()) while ((pos < paramString.length())
&& ((c = paramString.charAt(pos++)) != ',') && ((c = paramString.charAt(pos++)) != ',')
&& c != ';') { && c != ';') {
aValue += c; sb.append(c);
} }
String aValue = sb.toString();
if ((aKey.length() > 0) && (aValue.length() > 0)) { if ((aKey.length() > 0) && (aValue.length() > 0)) {