loplugin:privatebase: Make various derivations public

...assuming they were implicitly made private by accident rather than by design.
(And private derivation can cause unexpected failure of dynamic_cast, cf.
63b67ab5ca "Use public derivation, and remove
then-unnecessary downcasts.")

Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde

chart2/source/controller/main/ElementSelector.hxx

@@ -67,7 +67,7 @@ class SelectorListBox : public ListBox
 typedef ::cppu::ImplHelper1 < ::com::sun::star::lang::XServiceInfo> ElementSelectorToolbarController_BASE;
 
 class ElementSelectorToolbarController : public ::svt::ToolboxController
-                                                , ElementSelectorToolbarController_BASE
+                                                , public ElementSelectorToolbarController_BASE
 {
 public:
     explicit ElementSelectorToolbarController();

dbaccess/source/ui/inc/sqledit.hxx

@@ -33,7 +33,7 @@ namespace com { namespace sun { namespace star { namespace beans {
 namespace dbaui
 {
     class OQueryTextView;
-    class OSqlEdit : public MultiLineEditSyntaxHighlight, utl::ConfigurationListener
+    class OSqlEdit : public MultiLineEditSyntaxHighlight, public utl::ConfigurationListener
     {
     private:
         class ChangesListener;

forms/source/xforms/datatypes.hxx

@@ -224,7 +224,7 @@ namespace xforms
     */
     template< typename CONCRETE_DATA_TYPE_IMPL, typename SUPERCLASS = OXSDDataType >
     class ODerivedDataType  :public SUPERCLASS
-                            ,::comphelper::OPropertyArrayUsageHelper< CONCRETE_DATA_TYPE_IMPL >
+                            ,public ::comphelper::OPropertyArrayUsageHelper< CONCRETE_DATA_TYPE_IMPL >
     {
     private:
         bool    m_bPropertiesRegistered;

sc/inc/chart2uno.hxx

@@ -62,7 +62,7 @@ class ScChart2DataProvider : public
                     css::chart2::data::XRangeXMLConversion,
                     css::beans::XPropertySet,
                     css::lang::XServiceInfo>,
-                SfxListener
+                public SfxListener
 {
 public:
 
@@ -188,7 +188,7 @@ class ScChart2DataSource : public
                 ::cppu::WeakImplHelper<
                     css::chart2::data::XDataSource,
                     css::lang::XServiceInfo>,
-                SfxListener
+                public SfxListener
 {
 public:
 
@@ -235,7 +235,7 @@ class ScChart2DataSequence : public
                     css::util::XModifyBroadcaster,
                     css::beans::XPropertySet,
                     css::lang::XServiceInfo>,
-                SfxListener,
+                public SfxListener,
                 private boost::noncopyable
 {
 public:

sc/inc/externalrefmgr.hxx

@@ -358,7 +358,7 @@ private:
     mutable DocDataType maDocs;
 };
 
-class SC_DLLPUBLIC ScExternalRefManager : public formula::ExternalReferenceHelper, SfxListener
+class SC_DLLPUBLIC ScExternalRefManager : public formula::ExternalReferenceHelper, public SfxListener
 {
 public:
 

sc/inc/scmod.hxx

@@ -79,7 +79,7 @@ struct ScClipData;
 #define SC_DROP_NAVIGATOR       1
 #define SC_DROP_TABLE           2
 
-class ScModule: public SfxModule, public SfxListener, utl::ConfigurationListener
+class ScModule: public SfxModule, public SfxListener, public utl::ConfigurationListener
 {
     Timer               aIdleTimer;
     Idle                aSpellIdle;

sc/qa/unit/subsequent_export-test.cxx

@@ -74,7 +74,7 @@
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
 
-class ScExportTest : public ScBootstrapFixture, XmlTestTools
+class ScExportTest : public ScBootstrapFixture, public XmlTestTools
 {
 protected:
     virtual void registerNamespaces(xmlXPathContextPtr& pXmlXPathCtx) override;

sc/source/filter/xml/XMLExportIterator.hxx

@@ -72,7 +72,7 @@ struct ScMyShape
 
 typedef std::list<ScMyShape>    ScMyShapeList;
 
-class ScMyShapesContainer : ScMyIteratorBase
+class ScMyShapesContainer : public ScMyIteratorBase
 {
 private:
     ScMyShapeList               aShapeList;
@@ -101,7 +101,7 @@ struct ScMyNoteShape
 
 typedef std::list<ScMyNoteShape>    ScMyNoteShapeList;
 
-class ScMyNoteShapesContainer : ScMyIteratorBase
+class ScMyNoteShapesContainer : public ScMyIteratorBase
 {
 private:
     ScMyNoteShapeList           aNoteShapeList;
@@ -129,7 +129,7 @@ struct ScMyMergedRange
 
 typedef std::list<ScMyMergedRange>  ScMyMergedRangeList;
 
-class ScMyMergedRangesContainer : ScMyIteratorBase
+class ScMyMergedRangesContainer : public ScMyIteratorBase
 {
 private:
     ScMyMergedRangeList         aRangeList;
@@ -166,7 +166,7 @@ struct ScMyAreaLink
 
 typedef ::std::list< ScMyAreaLink > ScMyAreaLinkList;
 
-class ScMyAreaLinksContainer : ScMyIteratorBase
+class ScMyAreaLinksContainer : public ScMyIteratorBase
 {
 private:
     ScMyAreaLinkList            aAreaLinkList;
@@ -193,7 +193,7 @@ struct ScMyCellRangeAddress : css::table::CellRangeAddress
 
 typedef std::list<ScMyCellRangeAddress> ScMyEmptyDatabaseRangeList;
 
-class ScMyEmptyDatabaseRangesContainer : ScMyIteratorBase
+class ScMyEmptyDatabaseRangesContainer : public ScMyIteratorBase
 {
 private:
     ScMyEmptyDatabaseRangeList  aDatabaseList;
@@ -222,7 +222,7 @@ struct ScMyDetectiveObj
 typedef ::std::list< ScMyDetectiveObj > ScMyDetectiveObjList;
 typedef ::std::vector< ScMyDetectiveObj > ScMyDetectiveObjVec;
 
-class ScMyDetectiveObjContainer : ScMyIteratorBase
+class ScMyDetectiveObjContainer : public ScMyIteratorBase
 {
 private:
     ScMyDetectiveObjList        aDetectiveObjList;
@@ -256,7 +256,7 @@ struct ScMyDetectiveOp
 typedef ::std::list< ScMyDetectiveOp > ScMyDetectiveOpList;
 typedef ::std::vector< ScMyDetectiveOp > ScMyDetectiveOpVec;
 
-class ScMyDetectiveOpContainer : ScMyIteratorBase
+class ScMyDetectiveOpContainer : public ScMyIteratorBase
 {
 private:
     ScMyDetectiveOpList         aDetectiveOpList;

sd/source/ui/view/DocumentRenderer.cxx

@@ -330,7 +330,7 @@ namespace {
     /** Read the resource file and process it into a sequence of properties
         that can be passed to the printing dialog.
     */
-    class DialogCreator : Resource
+    class DialogCreator : public Resource
     {
     public:
         DialogCreator (bool bImpress, sal_Int32 nCurPage)

starmath/inc/smmod.hxx

@@ -85,7 +85,7 @@ public:
     static const OUString GetExportSymbolSetName( const OUString &rUiName );
 };
 
-class SmModule : public SfxModule, utl::ConfigurationListener
+class SmModule : public SfxModule, public utl::ConfigurationListener
 {
     std::unique_ptr<svtools::ColorConfig> mpColorConfig;
     std::unique_ptr<SmMathConfig> mpConfig;

svx/source/gallery2/galbrws1.hxx

@@ -70,7 +70,7 @@ class SfxItemSet;
 
 namespace svx { namespace sidebar { class GalleryControl; } }
 
-class GalleryBrowser1 : public Control, SfxListener
+class GalleryBrowser1 : public Control, public SfxListener
 {
     friend class GalleryBrowser;
     friend class svx::sidebar::GalleryControl;

svx/source/inc/GraphCtlAccessibleContext.hxx

@@ -79,7 +79,7 @@ typedef ::cppu::WeakAggComponentImplHelper7<
 
 class SvxGraphCtrlAccessibleContext:
     private comphelper::OBaseMutex, public SvxGraphCtrlAccessibleContext_Base,
-    SfxListener, accessibility::IAccessibleViewForwarder
+    public SfxListener, public accessibility::IAccessibleViewForwarder
 {
 public:
     friend class GraphCtrl;

vcl/unx/generic/app/i18n_im.cxx

@@ -48,7 +48,7 @@ using namespace vcl;
 // kinput2 IME needs special key handling since key release events are filtered in
 // preeditmode and XmbResetIC does not work
 
-class XKeyEventOp : XKeyEvent
+class XKeyEventOp : public XKeyEvent
 {
     private:
         void            init();