mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cid#1470396 Unchecked dynamic_cast

Browse Source 
a static_cast should be sufficient here after the GetObjIdentifier() ==
OBJ_MEASURE check

Change-Id: Idaded0a08fd908f3fa62acfe0d6efd98e8b1503a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107169
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2020-12-03 14:52:22 +00:00
parent a18217c04b
commit 60ae45f584
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sc/source/core/data/drwlayer.cxx
View File

@@ -934,7 +934,7 @@ void ScDrawLayer::InitializeCellAnchoredObj(SdrObject* pObj, ScDrawObjData& rDat
{ {
// Measure lines might have got wrong start and end anchor from XML import. Recreate // Measure lines might have got wrong start and end anchor from XML import. Recreate
// anchor from start and end point. // anchor from start and end point.
SdrMeasureObj* pMeasureObj = dynamic_cast<SdrMeasureObj*>(pObj); SdrMeasureObj* pMeasureObj = static_cast<SdrMeasureObj*>(pObj);
// tdf#137576. The logic rectangle has likely no current values here, but only the // tdf#137576. The logic rectangle has likely no current values here, but only the
// 1cm x 1cm default size. The call of TakeUnrotatedSnapRect is currently (LO 7.2) // 1cm x 1cm default size. The call of TakeUnrotatedSnapRect is currently (LO 7.2)
// the only way to force a recalc of the logic rectangle. // the only way to force a recalc of the logic rectangle.
@@ -2231,7 +2231,7 @@ void ScDrawLayer::SetCellAnchoredFromPosition( SdrObject &rObj, const ScDocument
{ {
// tdf#137576. A SdrMeasureObj might have a wrong logic rect here. TakeUnrotatedSnapRect // tdf#137576. A SdrMeasureObj might have a wrong logic rect here. TakeUnrotatedSnapRect
// calculates the current unrotated snap rectangle, sets logic rectangle and returns it. // calculates the current unrotated snap rectangle, sets logic rectangle and returns it.
static_cast<SdrMeasureObj*>(&rObj)->TakeUnrotatedSnapRect(aObjRect2); static_cast<SdrMeasureObj&>(rObj).TakeUnrotatedSnapRect(aObjRect2);
} }
else else
aObjRect2 = rObj.GetLogicRect(); aObjRect2 = rObj.GetLogicRect();