mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lokdocview: Protect set_part from setting an invalid part number

Browse Source 
Change-Id: Iffbe71ab161d5c50a98fd17ee0fdd0ab4d065e9d
This commit is contained in:
Pranav Kant 2016-02-20 23:45:24 +05:30
parent 69c5252a63
commit 60b1fb6edb
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libreofficekit/source/gtk/lokdocview.cxx
View File

@ -67,6 +67,8 @@ struct LOKDocViewPrivateImpl
gboolean m_bEdit;
/// LOK Features
guint64 m_nLOKFeatures;
/// Number of parts in currently loaded document
gint m_nParts;
/// Position and size of the visible cursor.
GdkRectangle m_aVisibleCursor;
/// Cursor overlay is visible or hidden (for blinking).
@ -825,6 +827,7 @@ static gboolean postDocumentLoad(gpointer pData)
priv->m_pDocument->pClass->initializeForRendering(priv->m_pDocument, priv->m_aRenderingArguments.c_str());
priv->m_pDocument->pClass->registerCallback(priv->m_pDocument, callbackWorker, pLOKDocView);
priv->m_pDocument->pClass->getDocumentSize(priv->m_pDocument, &priv->m_nDocumentWidthTwips, &priv->m_nDocumentHeightTwips);
priv->m_nParts = priv->m_pDocument->pClass->getParts(priv->m_pDocument);
g_timeout_add(600, handleTimeout, pLOKDocView);
float zoom = priv->m_fZoom;
@ -2759,6 +2762,12 @@ lok_doc_view_set_part (LOKDocView* pDocView, int nPart)
if (!priv->m_pDocument)
return;
if (nPart < 0 || nPart >= priv->m_nParts)
{
g_warning("Invalid part request : %d", nPart);
return;
}
GTask* task = g_task_new(pDocView, nullptr, nullptr, nullptr);
LOEvent* pLOEvent = new LOEvent(LOK_SET_PART);
GError* error = nullptr;