mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xmlsecurity PDF sign: don't crash on missing trailer

Browse Source 
This will need cross-reference stream write support, just don't crash
for now.

Change-Id: Id48c131b22d4ed96174693f3e96b14c273d596a8
Reviewed-on: https://gerrit.libreoffice.org/30702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
This commit is contained in:
Miklos Vajna 2016-11-08 15:54:15 +01:00
parent 5d80555938
commit 62401ba3c9
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
xmlsecurity/source/pdfio/pdfdocument.cxx
View File

@ -478,6 +478,11 @@ bool PDFDocument::Sign(const uno::Reference<security::XCertificate>& xCertificat
m_aEditBuffer.WriteCharPtr("\nendobj\n\n"); m_aEditBuffer.WriteCharPtr("\nendobj\n\n");
// Write the updated Catalog object, references nAnnotId. // Write the updated Catalog object, references nAnnotId.
if (!m_pTrailer)
{
SAL_WARN("xmlsecurity.pdfio", "PDFDocument::Sign: found no trailer");
return false;
}
auto pRoot = dynamic_cast<PDFReferenceElement*>(m_pTrailer->Lookup("Root")); auto pRoot = dynamic_cast<PDFReferenceElement*>(m_pTrailer->Lookup("Root"));
if (!pRoot) if (!pRoot)
{ {