From 62b58e88d897f51a7c4e12b41d14121ab8d3396f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Wed, 9 Jun 2021 17:10:42 +0200 Subject: [PATCH] allow altering the max size of o3tl::lru_cache MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Id119b70275e1c88a8c57f89d915241427be9dbf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116927 Tested-by: Jenkins Reviewed-by: Luboš Luňák --- include/o3tl/lru_map.hxx | 9 ++++++++- o3tl/qa/test-lru_map.cxx | 14 ++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/include/o3tl/lru_map.hxx b/include/o3tl/lru_map.hxx index dc8a102977dd..41c215255c7a 100644 --- a/include/o3tl/lru_map.hxx +++ b/include/o3tl/lru_map.hxx @@ -50,7 +50,7 @@ private: list_t mLruList; map_t mLruMap; - const size_t mMaxSize; + size_t mMaxSize; void checkLRU() { @@ -80,6 +80,13 @@ public: list_t().swap(mLruList); } + void setMaxSize(size_t nMaxSize) + { + mMaxSize = nMaxSize ? nMaxSize : std::min(mLruMap.max_size(), mLruList.max_size()); + while (mLruMap.size() > mMaxSize) + checkLRU(); + } + void insert(key_value_pair_t& rPair) { map_iterator_t i = mLruMap.find(rPair.first); diff --git a/o3tl/qa/test-lru_map.cxx b/o3tl/qa/test-lru_map.cxx index ef46f44d17b9..aac8a3e25283 100644 --- a/o3tl/qa/test-lru_map.cxx +++ b/o3tl/qa/test-lru_map.cxx @@ -29,6 +29,7 @@ public: void testCustomHash(); void testRemoveIf(); void testNoAutoCleanup(); + void testChangeMaxSize(); CPPUNIT_TEST_SUITE(lru_map_test); CPPUNIT_TEST(testBaseUsage); @@ -38,6 +39,7 @@ public: CPPUNIT_TEST(testCustomHash); CPPUNIT_TEST(testRemoveIf); CPPUNIT_TEST(testNoAutoCleanup); + CPPUNIT_TEST(testChangeMaxSize); CPPUNIT_TEST_SUITE_END(); }; @@ -310,6 +312,18 @@ void lru_map_test::testNoAutoCleanup() } } +void lru_map_test::testChangeMaxSize() +{ + o3tl::lru_map lru(3); + CPPUNIT_ASSERT_EQUAL(size_t(0), lru.size()); + lru.insert({ 0, 0 }); + lru.insert({ 1, 1 }); + lru.insert({ 2, 2 }); + CPPUNIT_ASSERT_EQUAL(size_t(3), lru.size()); + lru.setMaxSize(1); + CPPUNIT_ASSERT_EQUAL(size_t(1), lru.size()); +} + CPPUNIT_TEST_SUITE_REGISTRATION(lru_map_test); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */