mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:useuniqueptr update exclusions

Browse Source 
Change-Id: I9c741dbaba772550b4d68406fff50d8b0ac60874
Reviewed-on: https://gerrit.libreoffice.org/59923
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2018-09-03 09:58:12 +02:00
parent 4b5fcd4175
commit 651a2dee1c
1 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
compilerplugins/clang/useuniqueptr.cxx
View File

@@ -116,6 +116,9 @@ public:
// WW8TabBandDesc // WW8TabBandDesc
if (fn == SRCDIR "/sw/source/filter/ww8/ww8par2.cxx") if (fn == SRCDIR "/sw/source/filter/ww8/ww8par2.cxx")
return; return;
// ZipOutputStream, ownership of ZipEntry is horribly complicated here
if (fn == SRCDIR "/package/source/zipapi/ZipOutputStream.cxx")
return;
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
} }
@@ -410,6 +413,12 @@ void UseUniquePtr::CheckLoopDelete(const CXXMethodDecl* methodDecl, const CXXDel
if (!memberExpr) if (!memberExpr)
return; return;
std::string fn(handler.getMainFileName());
loplugin::normalizeDotDotInFilePath(fn);
// OStorage_Impl::Commit very complicated ownership passing going on
if (fn == SRCDIR "/package/source/xstor/xstorage.cxx")
return;
CheckDeleteExpr(methodDecl, deleteExpr, memberExpr, "rather manage with std::some_container<std::unique_ptr<T>>"); CheckDeleteExpr(methodDecl, deleteExpr, memberExpr, "rather manage with std::some_container<std::unique_ptr<T>>");
} }
@@ -433,6 +442,12 @@ void UseUniquePtr::CheckCXXForRangeStmt(const CXXMethodDecl* methodDecl, const C
if (!fieldDecl) if (!fieldDecl)
return; return;
std::string fn(handler.getMainFileName());
loplugin::normalizeDotDotInFilePath(fn);
// appears to just randomly leak stuff, and it involves some lex/yacc stuff
if (fn == SRCDIR "/idlc/source/aststack.cxx")
return;
CheckDeleteExpr(methodDecl, deleteExpr, memberExpr, "rather manage with std::some_container<std::unique_ptr<T>>"); CheckDeleteExpr(methodDecl, deleteExpr, memberExpr, "rather manage with std::some_container<std::unique_ptr<T>>");
} }
@@ -654,9 +669,6 @@ bool UseUniquePtr::VisitCXXDeleteExpr(const CXXDeleteExpr* deleteExpr)
// SAXEventKeeperImpl::smashBufferNode // SAXEventKeeperImpl::smashBufferNode
if (fn == SRCDIR "/xmlsecurity/source/framework/saxeventkeeperimpl.cxx") if (fn == SRCDIR "/xmlsecurity/source/framework/saxeventkeeperimpl.cxx")
return true; return true;
// ZipOutputStream, ownership of ZipEntry is horribly complicated here
if (fn == SRCDIR "/package/source/zipapi/ZipOutputStream.cxx")
return true;
// SwDoc::DeleteExtTextInput // SwDoc::DeleteExtTextInput
if (fn == SRCDIR "/sw/source/core/doc/extinput.cxx") if (fn == SRCDIR "/sw/source/core/doc/extinput.cxx")
return true; return true;
@@ -720,12 +732,22 @@ bool UseUniquePtr::TraverseConstructorInitializer(CXXCtorInitializer * ctorInit)
return true; return true;
if (!loplugin::TypeCheck(ctorInit->getMember()->getType()).Class("unique_ptr").StdNamespace()) if (!loplugin::TypeCheck(ctorInit->getMember()->getType()).Class("unique_ptr").StdNamespace())
return true; return true;
auto constructExpr = dyn_cast<CXXConstructExpr>(ctorInit->getInit()); auto constructExpr = dyn_cast_or_null<CXXConstructExpr>(ctorInit->getInit());
if (!constructExpr) if (!constructExpr || constructExpr->getNumArgs() == 0)
return true; return true;
auto init = constructExpr->getArg(0)->IgnoreImpCasts(); auto init = constructExpr->getArg(0)->IgnoreImpCasts();
if (!isa<DeclRefExpr>(init)) if (!isa<DeclRefExpr>(init))
return true; return true;
StringRef fn = getFileNameOfSpellingLoc(compiler.getSourceManager().getSpellingLoc(ctorInit->getSourceLocation()));
// don't feel like fiddling with the yacc parser
if (loplugin::hasPathnamePrefix(fn, SRCDIR "/idlc/"))
return true;
// cannot change URE
if (loplugin::hasPathnamePrefix(fn, SRCDIR "/cppu/source/helper/purpenv/helper_purpenv_Environment.cxx"))
return true;
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"should be passing via std::unique_ptr param", "should be passing via std::unique_ptr param",