mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xmlsecurity: fix loplugin:passstuffbyref warnings

Browse Source 
Change-Id: I627abfe33e9c2fc4243276706c1624ce19943678
This commit is contained in:
Miklos Vajna 2017-06-22 09:06:31 +02:00
parent 6025b2b2e2
commit 686dfc5ed5
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xmlsecurity/inc/digitalsignaturesdialog.hxx
View File

@ -103,7 +103,7 @@ private:
css::uno::Reference<css::security::XCertificate> getCertificate(const SignatureInformation& rInfo); css::uno::Reference<css::security::XCertificate> getCertificate(const SignatureInformation& rInfo);
css::uno::Reference<css::xml::crypto::XSecurityEnvironment> getSecurityEnvironmentForCertificate( css::uno::Reference<css::xml::crypto::XSecurityEnvironment> getSecurityEnvironmentForCertificate(
css::uno::Reference<css::security::XCertificate> xCert); const css::uno::Reference<css::security::XCertificate>& xCert);
//Checks if adding is allowed. //Checks if adding is allowed.
//See the spec at specs/www/appwide/security/Electronic_Signatures_and_Security.sxw //See the spec at specs/www/appwide/security/Electronic_Signatures_and_Security.sxw

2
xmlsecurity/inc/documentsignaturemanager.hxx
View File

@ -62,7 +62,7 @@ public:
SignatureStreamHelper ImplOpenSignatureStream(sal_Int32 eStreamMode, bool bTempStream); SignatureStreamHelper ImplOpenSignatureStream(sal_Int32 eStreamMode, bool bTempStream);
/// Add a new signature, using xCert as a signing certificate, and rDescription as description. /// Add a new signature, using xCert as a signing certificate, and rDescription as description.
bool add(const css::uno::Reference<css::security::XCertificate>& xCert, bool add(const css::uno::Reference<css::security::XCertificate>& xCert,
const css::uno::Reference<css::xml::crypto::XXMLSecurityContext> xSecurityContext, const css::uno::Reference<css::xml::crypto::XXMLSecurityContext>& xSecurityContext,
const OUString& rDescription, sal_Int32& nSecurityId, bool bAdESCompliant); const OUString& rDescription, sal_Int32& nSecurityId, bool bAdESCompliant);
/// Remove signature at nPosition. /// Remove signature at nPosition.
void remove(sal_uInt16 nPosition); void remove(sal_uInt16 nPosition);

2
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
View File

@ -675,7 +675,7 @@ uno::Reference<security::XCertificate> DigitalSignaturesDialog::getCertificate(c
return xCert; return xCert;
} }
uno::Reference<xml::crypto::XSecurityEnvironment> DigitalSignaturesDialog::getSecurityEnvironmentForCertificate(uno::Reference<security::XCertificate> xCert) uno::Reference<xml::crypto::XSecurityEnvironment> DigitalSignaturesDialog::getSecurityEnvironmentForCertificate(const uno::Reference<security::XCertificate>& xCert)
{ {
if (xCert->getCertificateKind() == CertificateKind_OPENPGP) if (xCert->getCertificateKind() == CertificateKind_OPENPGP)
return maSignatureManager.getGpgSecurityEnvironment(); return maSignatureManager.getGpgSecurityEnvironment();

2
xmlsecurity/source/helper/documentsignaturemanager.cxx
View File

@ -254,7 +254,7 @@ SignatureStreamHelper DocumentSignatureManager::ImplOpenSignatureStream(sal_Int3
} }
bool DocumentSignatureManager::add(const uno::Reference<security::XCertificate>& xCert, bool DocumentSignatureManager::add(const uno::Reference<security::XCertificate>& xCert,
const uno::Reference<xml::crypto::XXMLSecurityContext> xSecurityContext, const uno::Reference<xml::crypto::XXMLSecurityContext>& xSecurityContext,
const OUString& rDescription, const OUString& rDescription,
sal_Int32& nSecurityId, sal_Int32& nSecurityId,
bool bAdESCompliant) bool bAdESCompliant)