From 6b709b27b3552ced17b612b78f1c8cadc81f620c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Mon, 17 Nov 2014 12:40:45 +0000 Subject: [PATCH] coverity#735399 Logically dead code we can only enter the bAssumeExprLParenMode controlled block once because the block sets bAssumeExprLParenMode to false bAssumeExprLParenMode is only true if the first token read in the method is LPAREN so we can only enter this block if the current token is LPAREN and its the first token processed, so the token can't be BYVAL Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d --- basic/source/comp/exprtree.cxx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx index d004b0974010..c01a729125d9 100644 --- a/basic/source/comp/exprtree.cxx +++ b/basic/source/comp/exprtree.cxx @@ -1071,10 +1071,6 @@ SbiParameters::SbiParameters( SbiParser* p, bool bStandaloneExpression, bool bPa { bBracket = true; delete pExpr; - if( bByVal ) - { - pParser->Error( SbERR_LVALUE_EXPECTED ); - } return; } }