mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in TitleBar::PaintDecoration

Browse Source 
Change-Id: I3dd8ee6492be1a4b3d1032c4d50cc01111d748cb
Reviewed-on: https://gerrit.libreoffice.org/81185
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-18 10:59:06 +02:00
parent 67d5fbe0d0
commit 729989d485
7 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -142,9 +142,6 @@ include/sfx2/sfxstatuslistener.hxx:49
include/sfx2/sidebar/ControllerItem.hxx:44 include/sfx2/sidebar/ControllerItem.hxx:44
void sfx2::sidebar::ControllerItem::ItemUpdateReceiverInterface::NotifyItemUpdate(const unsigned short,const enum SfxItemState,const class SfxPoolItem *,const _Bool,) void sfx2::sidebar::ControllerItem::ItemUpdateReceiverInterface::NotifyItemUpdate(const unsigned short,const enum SfxItemState,const class SfxPoolItem *,const _Bool,)
1110 1110
include/sfx2/sidebar/TitleBar.hxx:61
void sfx2::sidebar::TitleBar::PaintDecoration(class OutputDevice &,const class tools::Rectangle &,)
10
include/sfx2/stbitem.hxx:100 include/sfx2/stbitem.hxx:100
_Bool SfxStatusBarControl::MouseButtonUp(const class MouseEvent &,) _Bool SfxStatusBarControl::MouseButtonUp(const class MouseEvent &,)
0 0

2
include/sfx2/sidebar/DeckTitleBar.hxx
View File

@@ -38,7 +38,7 @@ public:
protected: protected:
virtual tools::Rectangle GetTitleArea(const tools::Rectangle& rTitleBarBox) override; virtual tools::Rectangle GetTitleArea(const tools::Rectangle& rTitleBarBox) override;
virtual void PaintDecoration(vcl::RenderContext& rRenderContext, const tools::Rectangle& rTitleBarBox) override; virtual void PaintDecoration(vcl::RenderContext& rRenderContext) override;
virtual sidebar::Paint GetBackgroundPaint() override; virtual sidebar::Paint GetBackgroundPaint() override;
virtual void HandleToolBoxItemClick(const sal_uInt16 nItemIndex) override; virtual void HandleToolBoxItemClick(const sal_uInt16 nItemIndex) override;
virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override; virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override;

2
include/sfx2/sidebar/PanelTitleBar.hxx
View File

@@ -46,7 +46,7 @@ public:
protected: protected:
virtual tools::Rectangle GetTitleArea(const tools::Rectangle& rTitleBarBox) override; virtual tools::Rectangle GetTitleArea(const tools::Rectangle& rTitleBarBox) override;
virtual void PaintDecoration(vcl::RenderContext& rRenderContext, const tools::Rectangle& rTitleBarBox) override; virtual void PaintDecoration(vcl::RenderContext& rRenderContext) override;
virtual sidebar::Paint GetBackgroundPaint() override; virtual sidebar::Paint GetBackgroundPaint() override;
virtual void HandleToolBoxItemClick (const sal_uInt16 nItemIndex) override; virtual void HandleToolBoxItemClick (const sal_uInt16 nItemIndex) override;
virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override; virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override;

2
include/sfx2/sidebar/TitleBar.hxx
View File

@@ -58,7 +58,7 @@ protected:
OUString msTitle; OUString msTitle;
virtual tools::Rectangle GetTitleArea (const tools::Rectangle& rTitleBarBox) = 0; virtual tools::Rectangle GetTitleArea (const tools::Rectangle& rTitleBarBox) = 0;
virtual void PaintDecoration (vcl::RenderContext& rRenderContext, const tools::Rectangle& rTitleBarBox) = 0; virtual void PaintDecoration (vcl::RenderContext& rRenderContext) = 0;
void PaintFocus(vcl::RenderContext& rRenderContext, const tools::Rectangle& rFocusBox); void PaintFocus(vcl::RenderContext& rRenderContext, const tools::Rectangle& rFocusBox);
virtual sidebar::Paint GetBackgroundPaint() = 0; virtual sidebar::Paint GetBackgroundPaint() = 0;
virtual void HandleToolBoxItemClick (const sal_uInt16 nItemIndex); virtual void HandleToolBoxItemClick (const sal_uInt16 nItemIndex);

2
sfx2/source/sidebar/DeckTitleBar.cxx
View File

@@ -93,7 +93,7 @@ tools::Rectangle DeckTitleBar::GetDragArea()
); );
} }
void DeckTitleBar::PaintDecoration(vcl::RenderContext& rRenderContext, const tools::Rectangle& /*rTitleBarBox*/) void DeckTitleBar::PaintDecoration(vcl::RenderContext& rRenderContext)
{ {
Image aImage (Theme::GetImage(Theme::Image_Grip)); Image aImage (Theme::GetImage(Theme::Image_Grip));
const Point aTopLeft(gaLeftGripPadding, const Point aTopLeft(gaLeftGripPadding,

2
sfx2/source/sidebar/PanelTitleBar.cxx
View File

@@ -120,7 +120,7 @@ tools::Rectangle PanelTitleBar::GetTitleArea (const tools::Rectangle& rTitleBarB
return rTitleBarBox; return rTitleBarBox;
} }
void PanelTitleBar::PaintDecoration (vcl::RenderContext& rRenderContext, const tools::Rectangle& /*rTitleBarBox*/) void PanelTitleBar::PaintDecoration (vcl::RenderContext& rRenderContext)
{ {
if (mpPanel != nullptr) if (mpPanel != nullptr)
{ {

2
sfx2/source/sidebar/TitleBar.cxx
View File

@@ -82,7 +82,7 @@ void TitleBar::Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle&
Size aWindowSize (GetSizePixel()); Size aWindowSize (GetSizePixel());
tools::Rectangle aTitleBarBox(0,0, aWindowSize.Width(), aWindowSize.Height()); tools::Rectangle aTitleBarBox(0,0, aWindowSize.Width(), aWindowSize.Height());
PaintDecoration(rRenderContext, aTitleBarBox); PaintDecoration(rRenderContext);
const tools::Rectangle aTitleBox(GetTitleArea(aTitleBarBox)); const tools::Rectangle aTitleBox(GetTitleArea(aTitleBarBox));
PaintTitle(rRenderContext, aTitleBox); PaintTitle(rRenderContext, aTitleBox);
PaintFocus(rRenderContext, aTitleBox); PaintFocus(rRenderContext, aTitleBox);