mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qadevOOo: _XPropertySet.java: fix unrealistic expectations:

Browse Source 
We can't assume that when setting properties whose semantics we don't
know to random values in an arbitrary order, a non-changing value
indicates any kind of error.
The only real error this test can detect is if setting a property
crashes.
This commit is contained in:
Michael Stahl
2012-03-06 23:51:54 +01:00
parent 86d316f973
commit 73867da369
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
qadevOOo/tests/java/ifc/beans/_XPropertySet.java
View File

@@ -319,11 +319,15 @@ public class _XPropertySet extends MultiMethodTest {
"property '"+ propertyName+"'"); "property '"+ propertyName+"'");
e.printStackTrace(log); e.printStackTrace(log);
} // end of try-catch } // end of try-catch
/* this is stupid: we can't set properties whose semantics we
* don't know to random values in an arbitrary order and
* expect that to actually work.
if( gValue.equals(sValue) ) if( gValue.equals(sValue) )
{ {
log.println("setting property '"+ propertyName+"' failed"); log.println("setting property '"+ propertyName+"' failed");
error = true; error = true;
} }
*/
} }
tRes.tested("setPropertyValue()",!error); tRes.tested("setPropertyValue()",!error);
} //endif } //endif