mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

small optimisations

Browse Source 
remove a couple of string copies in the XML parser, which is always a
hot path

Change-Id: I84460ce13fb197bc7a3d354ff4c39d6939ff1d7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96313
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2020-06-15 09:26:24 +02:00
parent b314735568
commit 786d0b9abf
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
sax/source/fastparser/fastparser.cxx
View File

@@ -1227,9 +1227,12 @@ void FastSaxParserImpl::callbackStartElement(const xmlChar *localName , const xm
nNamespaceToken = GetNamespaceToken( sNamespace ); nNamespaceToken = GetNamespaceToken( sNamespace );
aElementPrefix = OUString( XML_CAST( prefix ), strlen( XML_CAST( prefix )), RTL_TEXTENCODING_UTF8 ); aElementPrefix = OUString( XML_CAST( prefix ), strlen( XML_CAST( prefix )), RTL_TEXTENCODING_UTF8 );
} }
const OUString& rElementLocalName = OUString( XML_CAST( localName ), strlen( XML_CAST( localName )), RTL_TEXTENCODING_UTF8 ); OUString aElementLocalName( XML_CAST( localName ), strlen( XML_CAST( localName )), RTL_TEXTENCODING_UTF8 );
rEvent.msNamespace = sNamespace; rEvent.msNamespace = sNamespace;
rEvent.msElementName = (aElementPrefix.isEmpty())? rElementLocalName : aElementPrefix + ":" + rElementLocalName; if( aElementPrefix.isEmpty() )
rEvent.msElementName = std::move(aElementLocalName);
else
rEvent.msElementName = aElementPrefix + ":" + aElementLocalName;
} }
else // token is always preferred. else // token is always preferred.
rEvent.msElementName.clear(); rEvent.msElementName.clear();
@@ -1305,7 +1308,7 @@ void FastSaxParserImpl::sendPendingCharacters()
if (rEntity.mbEnableThreads) if (rEntity.mbEnableThreads)
{ {
Event& rEvent = rEntity.getEvent( CallbackType::CHARACTERS ); Event& rEvent = rEntity.getEvent( CallbackType::CHARACTERS );
rEvent.msChars = sChars; rEvent.msChars = std::move(sChars);
produce(); produce();
} }
else else